All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Marciniszyn <mike.marciniszyn@intel.com>
To: jgg@ziepe.ca, dledford@redhat.com
Cc: linux-rdma@vger.kernel.org
Subject: [PATCH 3/6] IB/hfi1: Field not zero-ed when allocating TID flow memory
Date: Mon, 15 Jul 2019 12:45:34 -0400	[thread overview]
Message-ID: <20190715164534.74174.6177.stgit@awfm-01.aw.intel.com> (raw)
In-Reply-To: <20190715164423.74174.4994.stgit@awfm-01.aw.intel.com>

From: Kaike Wan <kaike.wan@intel.com>

The field flow->resync_npkts is added for TID RDMA WRITE request and
zero-ed when a TID RDMA WRITE RESP packet is received by the requester.
This field is used to rewind a request during retry in the function
hfi1_tid_rdma_restart_req() shared by both TID RDMA WRITE and TID RDMA
READ requests. Therefore, when a TID RDMA READ request is retried,
this field may not be initialized at all, which causes the retry to
start at an incorrect psn, leading to the drop of the retry request
by the responder.

This patch fixes the problem by zeroing out the field when the flow
memory is allocated.

Fixes: 838b6fd2d9ca ("IB/hfi1: TID RDMA RcvArray programming and TID allocation")
Cc: <stable@vger.kernel.org>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
---
 drivers/infiniband/hw/hfi1/tid_rdma.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c
index 92accca..7fcbeee 100644
--- a/drivers/infiniband/hw/hfi1/tid_rdma.c
+++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
@@ -1620,6 +1620,7 @@ static int hfi1_kern_exp_rcv_alloc_flows(struct tid_rdma_request *req,
 		flows[i].req = req;
 		flows[i].npagesets = 0;
 		flows[i].pagesets[0].mapped =  0;
+		flows[i].resync_npkts = 0;
 	}
 	req->flows = flows;
 	return 0;


  parent reply	other threads:[~2019-07-15 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 16:45 [PATCH 0/6] More 5.3 patches Mike Marciniszyn
2019-07-15 16:45 ` [PATCH 1/6] IB/hfi1: Check for error on call to alloc_rsm_map_table Mike Marciniszyn
2019-07-15 16:45 ` [PATCH 2/6] IB/hfi1: Unreserve a flushed OPFN request Mike Marciniszyn
2019-07-15 16:45 ` Mike Marciniszyn [this message]
2019-07-15 16:45 ` [PATCH 4/6] IB/hfi1: Drop all TID RDMA READ RESP packets after r_next_psn Mike Marciniszyn
2019-07-15 16:45 ` [PATCH 5/6] IB/hfi1: Do not update hcrc for a KDETH packet during fault injection Mike Marciniszyn
2019-07-15 16:45 ` [PATCH 6/6] IB/hfi1: Remove unused define Mike Marciniszyn
2019-07-15 17:54 ` [PATCH 0/6] More 5.3 patches Jason Gunthorpe
2019-07-15 17:55   ` Marciniszyn, Mike
2019-07-15 18:04     ` Jason Gunthorpe
2019-07-15 18:05       ` Marciniszyn, Mike
2019-07-22 18:03 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190715164534.74174.6177.stgit@awfm-01.aw.intel.com \
    --to=mike.marciniszyn@intel.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.