From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Philipp Tomsich <philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>, Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, YouMin Chen <cym-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, gajjar04akash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org, Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>, Manivannan Sadhasivam <manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Subject: [PATCH v3 03/18] ram: rk3399: Use rank mask in ca data training Date: Mon, 15 Jul 2019 23:58:41 +0530 [thread overview] Message-ID: <20190715182856.21688-4-jagan@amarulasolutions.com> (raw) In-Reply-To: <20190715182856.21688-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Add rank_mask based on the rank number, this would keep the ca data training loop based on the desired rank mask value instead of looping for all values. Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Signed-off-by: YouMin Chen <cym-TNX95d0MmH7DzftRWevZcw@public.gmane.org> --- drivers/ram/rockchip/sdram_rk3399.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index fe26144f27..b98df20fa5 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -626,11 +626,17 @@ static int data_training_ca(const struct chan_info *chan, u32 channel, u32 i, tmp; u32 obs_0, obs_1, obs_2, obs_err = 0; u32 rank = params->ch[channel].cap_info.rank; + u32 rank_mask; /* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */ writel(0x00003f7c, (&denali_pi[175])); - for (i = 0; i < rank; i++) { + rank_mask = (rank == 1) ? 0x1 : 0x3; + + for (i = 0; i < 4; i++) { + if (!(rank_mask & (1 << i))) + continue; + select_per_cs_training_index(chan, i); /* PI_100 PI_CALVL_EN:RW:8:2 */ -- 2.18.0.321.gffc6fa0e3
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com> To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v3 03/18] ram: rk3399: Use rank mask in ca data training Date: Mon, 15 Jul 2019 23:58:41 +0530 [thread overview] Message-ID: <20190715182856.21688-4-jagan@amarulasolutions.com> (raw) In-Reply-To: <20190715182856.21688-1-jagan@amarulasolutions.com> Add rank_mask based on the rank number, this would keep the ca data training loop based on the desired rank mask value instead of looping for all values. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Signed-off-by: YouMin Chen <cym@rock-chips.com> --- drivers/ram/rockchip/sdram_rk3399.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c index fe26144f27..b98df20fa5 100644 --- a/drivers/ram/rockchip/sdram_rk3399.c +++ b/drivers/ram/rockchip/sdram_rk3399.c @@ -626,11 +626,17 @@ static int data_training_ca(const struct chan_info *chan, u32 channel, u32 i, tmp; u32 obs_0, obs_1, obs_2, obs_err = 0; u32 rank = params->ch[channel].cap_info.rank; + u32 rank_mask; /* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */ writel(0x00003f7c, (&denali_pi[175])); - for (i = 0; i < rank; i++) { + rank_mask = (rank == 1) ? 0x1 : 0x3; + + for (i = 0; i < 4; i++) { + if (!(rank_mask & (1 << i))) + continue; + select_per_cs_training_index(chan, i); /* PI_100 PI_CALVL_EN:RW:8:2 */ -- 2.18.0.321.gffc6fa0e3
next prev parent reply other threads:[~2019-07-15 18:28 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-15 18:28 [PATCH v3 00/18] ram: rk3399: Add rank detection Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-15 18:28 ` [PATCH v3 01/18] ram: rk3399: Handle data training return types Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-2-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:36 ` Kever Yang 2019-07-16 7:36 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 02/18] ram: rk3399: Clear PI_175 interrupts in data training Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-3-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:36 ` Kever Yang 2019-07-16 7:36 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` Jagan Teki [this message] 2019-07-15 18:28 ` [U-Boot] [PATCH v3 03/18] ram: rk3399: Use rank mask in ca " Jagan Teki [not found] ` <20190715182856.21688-4-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:38 ` Kever Yang 2019-07-16 7:38 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 04/18] ram: rk3399: Use rank mask in wdql " Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-5-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:38 ` Kever Yang 2019-07-16 7:38 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 05/18] ram: rk3399: Add phy pctrl reset support Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:39 ` Kever Yang 2019-07-16 7:39 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 06/18] ram: rk3399: Move pwrup_srefresh_exit to dram_info Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-7-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:39 ` Kever Yang 2019-07-16 7:39 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 07/18] ram: rk3399: Add pctl start support Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-8-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:40 ` Kever Yang 2019-07-16 7:40 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 08/18] ram: rockchip: Add initial Kconfig Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-9-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:41 ` Kever Yang 2019-07-16 7:41 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 09/18] debug_uart: Add printdec Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-10-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:41 ` Kever Yang 2019-07-16 7:41 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 10/18] ram: rockchip: Add debug sdram driver Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-11-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:42 ` Kever Yang 2019-07-16 7:42 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 11/18] ram: rockchip: debug: Add sdram_print_ddr_info Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-12-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:42 ` Kever Yang 2019-07-16 7:42 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 12/18] ram: rockchip: debug: Get the cs capacity Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-13-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:43 ` Kever Yang 2019-07-16 7:43 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 13/18] ram: rk3399: debug: Add sdram_print_stride Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-14-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:43 ` Kever Yang 2019-07-16 7:43 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 14/18] ram: rk3399: Compute stride for 2 channels Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-15-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:44 ` Kever Yang 2019-07-16 7:44 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 15/18] ram: rk3399: Compute stride for 1 channel a Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-16-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:44 ` Kever Yang 2019-07-16 7:44 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 16/18] ram: rk3399: Add rank detection support Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-17-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:45 ` Kever Yang 2019-07-16 7:45 ` [U-Boot] " Kever Yang 2019-07-17 12:53 ` Kever Yang 2019-07-17 12:53 ` [U-Boot] " Kever Yang 2019-07-18 9:30 ` Jagan Teki 2019-07-18 9:30 ` [U-Boot] " Jagan Teki 2019-07-15 18:28 ` [PATCH v3 17/18] ram: rk3399: Enable sdram debug functions Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-18-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:49 ` Kever Yang 2019-07-16 7:49 ` [U-Boot] " Kever Yang 2019-07-15 18:28 ` [PATCH v3 18/18] rockchip: dts: rk3399: nanopi-neo4: Use DDR3-1866 dtsi Jagan Teki 2019-07-15 18:28 ` [U-Boot] " Jagan Teki [not found] ` <20190715182856.21688-19-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2019-07-16 7:47 ` Kever Yang 2019-07-16 7:47 ` [U-Boot] " Kever Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190715182856.21688-4-jagan@amarulasolutions.com \ --to=jagan-dyjbcgdgk7pe9whmmfpqlfatqe2ktcn/@public.gmane.org \ --cc=cym-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=gajjar04akash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \ --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.