All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keyon Jie <yang.jie@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: kai.vehmanen@linux.intel.com,
	Marcin Rajwa <marcin.rajwa@linux.intel.com>,
	marcin.rajwa@intel.com, Keyon Jie <yang.jie@linux.intel.com>,
	ranjani.sridharan@linux.intel.com,
	pierre-louis.bossart@linux.intel.com
Subject: [PATCH v3 1/2] ASoC: SOF: add flag for position update ipc
Date: Thu, 18 Jul 2019 11:11:12 +0800	[thread overview]
Message-ID: <20190718031113.25040-1-yang.jie@linux.intel.com> (raw)

From: Marcin Rajwa <marcin.rajwa@linux.intel.com>

In some cases, FW might need to use the host_period_bytes field to
synchronize the DMA copying (with host side) but the driver does not
need any position information returned over the IPC channel by the
firmware. The current IPC definition prevents this capability, so add
new field.

Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
 include/sound/sof/stream.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/sound/sof/stream.h b/include/sound/sof/stream.h
index 643f175cb479..06af4ecb2584 100644
--- a/include/sound/sof/stream.h
+++ b/include/sound/sof/stream.h
@@ -83,10 +83,10 @@ struct sof_ipc_stream_params {
 	uint16_t sample_valid_bytes;
 	uint16_t sample_container_bytes;
 
-	/* for notifying host period has completed - 0 means no period IRQ */
 	uint32_t host_period_bytes;
+	uint32_t no_position_ipc; /* 1 means no IPC for position upadte */
 
-	uint32_t reserved[2];
+	uint16_t reserved[3];
 	uint16_t chmap[SOF_IPC_MAX_CHANNELS];	/**< channel map - SOF_CHMAP_ */
 } __packed;
 
-- 
2.20.1

             reply	other threads:[~2019-07-18  3:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  3:11 Keyon Jie [this message]
2019-07-18  3:11 ` [PATCH v3 2/2] ASoC: SOF: Intel: fix reset of host_period_bytes Keyon Jie
2019-07-18  3:35 ` [PATCH v3 1/2] ASoC: SOF: add flag for position update ipc Pierre-Louis Bossart
2019-07-18  5:06   ` Keyon Jie
2019-07-18  8:42     ` Rajwa, Marcin
2019-07-18 15:24       ` Pierre-Louis Bossart
2019-07-19 10:32         ` Rajwa, Marcin
2019-07-19 14:25           ` Pierre-Louis Bossart
2019-07-19 14:59             ` Rajwa, Marcin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718031113.25040-1-yang.jie@linux.intel.com \
    --to=yang.jie@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=marcin.rajwa@intel.com \
    --cc=marcin.rajwa@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.