From: Xavier Ruppen <xruppen@gmail.com>
To: khilman@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, narmstrong@baylibre.com,
martin.blumenstingl@googlemail.com,
Xavier Ruppen <xruppen@gmail.com>
Subject: [PATCH] arm64: dts: meson: odroid-n2: keep SD card regulator always on
Date: Fri, 19 Jul 2019 21:29:54 +0200 [thread overview]
Message-ID: <20190719192954.26481-1-xruppen@gmail.com> (raw)
When powering off the Odroid N2, the tflash_vdd regulator is
automatically turned off by the kernel. This is a problem
when issuing the "reboot" command while using an SD card.
The boot ROM does not power this regulator back on, blocking
the reboot process at the boot ROM stage, preventing the
SD card from being detected.
Adding the "regulator-always-on" property fixes the problem.
Signed-off-by: Xavier Ruppen <xruppen@gmail.com>
---
Here is what the boot ROM output looks like without this patch:
[root@alarm ~]# reboot
[...]
[ 24.275860] shutdown[1]: All loop devices detached.
[ 24.278864] shutdown[1]: Detaching DM devices.
[ 24.287105] kvm: exiting hardware virtualization
[ 24.318776] reboot: Restarting system
bl31 reboot reason: 0xd
bl31 reboot reason: 0x0
system cmd 1.
G12B:BL:6e7c85:7898ac;FEAT:E0F83180:2000;POC:F;RCY:0;
EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:1;EMMC:800;
NAND:81;SD?:0;SD:400;USB:8;LOOP:2;EMMC:800;NAND:81;
SD?:0;SD:400;USB:8;LOOP:3; [...]
Other people can be seen having this problem on the odroid
forum [1].
The cause of the problem was found by Martin Blumenstingl
on #linux-amlogic. We may want to add his Suggested-by tag
if he agrees.
[1] https://forum.odroid.com/viewtopic.php?f=176&t=33993
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 81780ffcc7f0..4e916e1f71f7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -53,6 +53,7 @@
gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>;
enable-active-high;
+ regulator-always-on;
};
tf_io: gpio-regulator-tf_io {
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Xavier Ruppen <xruppen@gmail.com>
To: khilman@baylibre.com
Cc: narmstrong@baylibre.com, martin.blumenstingl@googlemail.com,
linux-kernel@vger.kernel.org, Xavier Ruppen <xruppen@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: meson: odroid-n2: keep SD card regulator always on
Date: Fri, 19 Jul 2019 21:29:54 +0200 [thread overview]
Message-ID: <20190719192954.26481-1-xruppen@gmail.com> (raw)
When powering off the Odroid N2, the tflash_vdd regulator is
automatically turned off by the kernel. This is a problem
when issuing the "reboot" command while using an SD card.
The boot ROM does not power this regulator back on, blocking
the reboot process at the boot ROM stage, preventing the
SD card from being detected.
Adding the "regulator-always-on" property fixes the problem.
Signed-off-by: Xavier Ruppen <xruppen@gmail.com>
---
Here is what the boot ROM output looks like without this patch:
[root@alarm ~]# reboot
[...]
[ 24.275860] shutdown[1]: All loop devices detached.
[ 24.278864] shutdown[1]: Detaching DM devices.
[ 24.287105] kvm: exiting hardware virtualization
[ 24.318776] reboot: Restarting system
bl31 reboot reason: 0xd
bl31 reboot reason: 0x0
system cmd 1.
G12B:BL:6e7c85:7898ac;FEAT:E0F83180:2000;POC:F;RCY:0;
EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:1;EMMC:800;
NAND:81;SD?:0;SD:400;USB:8;LOOP:2;EMMC:800;NAND:81;
SD?:0;SD:400;USB:8;LOOP:3; [...]
Other people can be seen having this problem on the odroid
forum [1].
The cause of the problem was found by Martin Blumenstingl
on #linux-amlogic. We may want to add his Suggested-by tag
if he agrees.
[1] https://forum.odroid.com/viewtopic.php?f=176&t=33993
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 81780ffcc7f0..4e916e1f71f7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -53,6 +53,7 @@
gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>;
enable-active-high;
+ regulator-always-on;
};
tf_io: gpio-regulator-tf_io {
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Xavier Ruppen <xruppen@gmail.com>
To: khilman@baylibre.com
Cc: narmstrong@baylibre.com, martin.blumenstingl@googlemail.com,
linux-kernel@vger.kernel.org, Xavier Ruppen <xruppen@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: meson: odroid-n2: keep SD card regulator always on
Date: Fri, 19 Jul 2019 21:29:54 +0200 [thread overview]
Message-ID: <20190719192954.26481-1-xruppen@gmail.com> (raw)
When powering off the Odroid N2, the tflash_vdd regulator is
automatically turned off by the kernel. This is a problem
when issuing the "reboot" command while using an SD card.
The boot ROM does not power this regulator back on, blocking
the reboot process at the boot ROM stage, preventing the
SD card from being detected.
Adding the "regulator-always-on" property fixes the problem.
Signed-off-by: Xavier Ruppen <xruppen@gmail.com>
---
Here is what the boot ROM output looks like without this patch:
[root@alarm ~]# reboot
[...]
[ 24.275860] shutdown[1]: All loop devices detached.
[ 24.278864] shutdown[1]: Detaching DM devices.
[ 24.287105] kvm: exiting hardware virtualization
[ 24.318776] reboot: Restarting system
bl31 reboot reason: 0xd
bl31 reboot reason: 0x0
system cmd 1.
G12B:BL:6e7c85:7898ac;FEAT:E0F83180:2000;POC:F;RCY:0;
EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:1;EMMC:800;
NAND:81;SD?:0;SD:400;USB:8;LOOP:2;EMMC:800;NAND:81;
SD?:0;SD:400;USB:8;LOOP:3; [...]
Other people can be seen having this problem on the odroid
forum [1].
The cause of the problem was found by Martin Blumenstingl
on #linux-amlogic. We may want to add his Suggested-by tag
if he agrees.
[1] https://forum.odroid.com/viewtopic.php?f=176&t=33993
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 81780ffcc7f0..4e916e1f71f7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -53,6 +53,7 @@
gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>;
enable-active-high;
+ regulator-always-on;
};
tf_io: gpio-regulator-tf_io {
--
2.21.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2019-07-19 19:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 19:29 Xavier Ruppen [this message]
2019-07-19 19:29 ` [PATCH] arm64: dts: meson: odroid-n2: keep SD card regulator always on Xavier Ruppen
2019-07-19 19:29 ` Xavier Ruppen
2019-07-22 7:21 ` Neil Armstrong
2019-07-22 7:21 ` Neil Armstrong
2019-07-22 7:21 ` Neil Armstrong
2019-07-24 5:30 ` Anand Moon
2019-07-24 5:30 ` Anand Moon
2019-07-24 5:30 ` Anand Moon
2019-07-24 6:49 ` Neil Armstrong
2019-07-24 6:49 ` Neil Armstrong
2019-07-24 6:49 ` Neil Armstrong
2019-07-24 9:00 ` Anand Moon
2019-07-24 9:00 ` Anand Moon
2019-07-24 9:00 ` Anand Moon
2019-07-23 19:48 ` Martin Blumenstingl
2019-07-23 19:48 ` Martin Blumenstingl
2019-07-23 19:48 ` Martin Blumenstingl
2019-07-25 23:41 ` Kevin Hilman
2019-07-25 23:41 ` Kevin Hilman
2019-07-25 23:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719192954.26481-1-xruppen@gmail.com \
--to=xruppen@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.