From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH v3 6/6] t6200: use test_commit_bulk
Date: Fri, 19 Jul 2019 17:56:23 -0400 [thread overview]
Message-ID: <20190719215623.GF32188@sigill.intra.peff.net> (raw)
In-Reply-To: <20190719215417.GA31841@sigill.intra.peff.net>
There's a loop that creates 30 commits using test_commit. Using
test_commit_bulk speeds this up from:
Benchmark #1: ./t6200-fmt-merge-msg.sh --root=/var/ram/git-tests
Time (mean ± σ): 1.926 s ± 0.240 s [User: 1.055 s, System: 0.963 s]
Range (min … max): 1.431 s … 2.166 s 10 runs
to:
Benchmark #1: ./t6200-fmt-merge-msg.sh --root=/var/ram/git-tests
Time (mean ± σ): 1.343 s ± 0.179 s [User: 766.5 ms, System: 662.9 ms]
Range (min … max): 1.032 s … 1.664 s 10 runs
for an average savings of over 30%.
Signed-off-by: Jeff King <peff@peff.net>
---
t/t6200-fmt-merge-msg.sh | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/t/t6200-fmt-merge-msg.sh b/t/t6200-fmt-merge-msg.sh
index 93f23cfa82..8a72b4c43a 100755
--- a/t/t6200-fmt-merge-msg.sh
+++ b/t/t6200-fmt-merge-msg.sh
@@ -66,12 +66,7 @@ test_expect_success setup '
git commit -a -m "Right #5" &&
git checkout -b long &&
- i=0 &&
- while test $i -lt 30
- do
- test_commit $i one &&
- i=$(($i+1))
- done &&
+ test_commit_bulk --start=0 --message=%s --filename=one 30 &&
git show-branch &&
--
2.22.0.993.gcc1030c86b
next prev parent reply other threads:[~2019-07-19 21:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 20:27 What's cooking in git.git (Jul 2019, #05; Fri, 19) Junio C Hamano
2019-07-19 21:54 ` jk/test-commit-bulk, was: " Jeff King
2019-07-19 21:56 ` [PATCH v3 1/6] test-lib: introduce test_commit_bulk Jeff King
2019-07-19 21:56 ` [PATCH v3 2/6] t5310: increase the number of bitmapped commits Jeff King
2019-07-19 21:56 ` [PATCH v3 3/6] t3311: use test_commit_bulk Jeff King
2019-07-19 21:56 ` [PATCH v3 4/6] t5702: " Jeff King
2019-07-19 21:56 ` [PATCH v3 5/6] t5703: " Jeff King
2019-07-19 21:56 ` Jeff King [this message]
2019-07-23 15:42 ` jk/test-commit-bulk, Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719215623.GF32188@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.