From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <bgolaszewski@baylibre.com>
Cc: <linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: [PATCH 1/4] gpio: arizona: Use local copy of pdata
Date: Mon, 22 Jul 2019 10:07:45 +0100 [thread overview]
Message-ID: <20190722090748.20807-1-ckeepax@opensource.cirrus.com> (raw)
A local copy of the pdata exists and it should be used rather than
pulling a fresh copy.
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
drivers/gpio/gpio-arizona.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c
index c07fad975049d..5640efe5e7504 100644
--- a/drivers/gpio/gpio-arizona.c
+++ b/drivers/gpio/gpio-arizona.c
@@ -142,7 +142,7 @@ static const struct gpio_chip template_chip = {
static int arizona_gpio_probe(struct platform_device *pdev)
{
struct arizona *arizona = dev_get_drvdata(pdev->dev.parent);
- struct arizona_pdata *pdata = dev_get_platdata(arizona->dev);
+ struct arizona_pdata *pdata = &arizona->pdata;
struct arizona_gpio *arizona_gpio;
int ret;
@@ -177,7 +177,7 @@ static int arizona_gpio_probe(struct platform_device *pdev)
return -EINVAL;
}
- if (pdata && pdata->gpio_base)
+ if (pdata->gpio_base)
arizona_gpio->gpio_chip.base = pdata->gpio_base;
else
arizona_gpio->gpio_chip.base = -1;
--
2.11.0
next reply other threads:[~2019-07-22 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 9:07 Charles Keepax [this message]
2019-07-22 9:07 ` [PATCH 2/4] gpio: madera: Use local copy of pdata Charles Keepax
2019-08-05 9:43 ` Linus Walleij
2019-07-22 9:07 ` [PATCH 3/4] gpio: madera: Add support for Cirrus Logic CS47L15 Charles Keepax
2019-08-05 9:45 ` Linus Walleij
2019-07-22 9:07 ` [PATCH 4/4] gpio: madera: Add support for Cirrus Logic CS47L92 Charles Keepax
2019-08-05 9:45 ` Linus Walleij
2019-08-05 9:42 ` [PATCH 1/4] gpio: arizona: Use local copy of pdata Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722090748.20807-1-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.