From: "Artur Świgoń" <a.swigon@partner.samsung.com> To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: krzk@kernel.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, georgi.djakov@linaro.org, m.szyprowski@samsung.com Subject: [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect Date: Tue, 23 Jul 2019 14:20:05 +0200 [thread overview] Message-ID: <20190723122016.30279-1-a.swigon@partner.samsung.com> (raw) In-Reply-To: CGME20190723122022eucas1p2f568f74f981f9de9012eb693c3b446d5@eucas1p2.samsung.com The following patchset adds interconnect[1][2] framework support to the exynos-bus devfreq driver. Extending the devfreq driver with interconnect capabilities started as a response to the issue referenced in [3]. The patches can be subdivided into four logical groups: (a) Refactoring the existing devfreq driver in order to improve readability and accommodate for adding new code (patches 01--04/11). (b) Tweaking the interconnect framework to support the exynos-bus use case (patches 05--07/11). Exporting of_icc_get_from_provider() allows us to avoid hardcoding every single graph edge in the DT or driver source, and relaxing the requirement contained in that function removes the need to provide dummy node IDs in the DT. Adjusting the logic in apply_constraints() (drivers/interconnect/core.c) accounts for the fact that every bus is a separate entity and therefore a separate interconnect provider, albeit constituting a part of a larger hierarchy. (c) Implementing interconnect providers in the exynos-bus devfreq driver and adding required DT properties for one selected platform, namely Exynos4412 (patches 08--09/11). Due to the fact that this aims to be a generic driver for various Exynos SoCs, node IDs are generated dynamically rather than hardcoded. This has been determined to be a simpler approach, but depends on changes described in (b). (d) Implementing a sample interconnect consumer for exynos-mixer targeted at the issue referenced in [3], again with DT info only for Exynos4412 (patches 10--11/11). Integration of devfreq and interconnect functionalities comes down to one extra line in the devfreq target() callback, which selects either the frequency calculated by the devfreq governor, or the one requested with the interconnect API, whichever is higher. All new code works equally well when CONFIG_INTERCONNECT is 'n' (as in exynos_defconfig) in which case all interconnect API functions are no-ops. --- Artur Świgoń Samsung R&D Institute Poland Samsung Electronics --- References: [1] Documentation/interconnect/interconnect.rst [2] Documentation/devicetree/bindings/interconnect/interconnect.txt [3] https://patchwork.kernel.org/patch/10861757 Artur Świgoń (10): devfreq: exynos-bus: Extract exynos_bus_profile_init() devfreq: exynos-bus: Extract exynos_bus_profile_init_passive() devfreq: exynos-bus: Change goto-based logic to if-else logic devfreq: exynos-bus: Clean up code icc: Export of_icc_get_from_provider() icc: Relax requirement in of_icc_get_from_provider() icc: Relax condition in apply_constraints() arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412 devfreq: exynos-bus: Add interconnect functionality to exynos-bus arm: dts: exynos: Add interconnects to Exynos4412 mixer Marek Szyprowski (1): drm: exynos: mixer: Add interconnect support .../boot/dts/exynos4412-odroid-common.dtsi | 1 + arch/arm/boot/dts/exynos4412.dtsi | 10 + drivers/devfreq/exynos-bus.c | 296 ++++++++++++++---- drivers/gpu/drm/exynos/exynos_mixer.c | 68 +++- drivers/interconnect/core.c | 12 +- include/linux/interconnect-provider.h | 6 + 6 files changed, 314 insertions(+), 79 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "Artur Świgoń" <a.swigon@partner.samsung.com> To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: sw0312.kim@samsung.com, krzk@kernel.org, inki.dae@samsung.com, cw00.choi@samsung.com, myungjoo.ham@samsung.com, georgi.djakov@linaro.org, m.szyprowski@samsung.com Subject: [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect Date: Tue, 23 Jul 2019 14:20:05 +0200 [thread overview] Message-ID: <20190723122016.30279-1-a.swigon@partner.samsung.com> (raw) In-Reply-To: CGME20190723122022eucas1p2f568f74f981f9de9012eb693c3b446d5@eucas1p2.samsung.com The following patchset adds interconnect[1][2] framework support to the exynos-bus devfreq driver. Extending the devfreq driver with interconnect capabilities started as a response to the issue referenced in [3]. The patches can be subdivided into four logical groups: (a) Refactoring the existing devfreq driver in order to improve readability and accommodate for adding new code (patches 01--04/11). (b) Tweaking the interconnect framework to support the exynos-bus use case (patches 05--07/11). Exporting of_icc_get_from_provider() allows us to avoid hardcoding every single graph edge in the DT or driver source, and relaxing the requirement contained in that function removes the need to provide dummy node IDs in the DT. Adjusting the logic in apply_constraints() (drivers/interconnect/core.c) accounts for the fact that every bus is a separate entity and therefore a separate interconnect provider, albeit constituting a part of a larger hierarchy. (c) Implementing interconnect providers in the exynos-bus devfreq driver and adding required DT properties for one selected platform, namely Exynos4412 (patches 08--09/11). Due to the fact that this aims to be a generic driver for various Exynos SoCs, node IDs are generated dynamically rather than hardcoded. This has been determined to be a simpler approach, but depends on changes described in (b). (d) Implementing a sample interconnect consumer for exynos-mixer targeted at the issue referenced in [3], again with DT info only for Exynos4412 (patches 10--11/11). Integration of devfreq and interconnect functionalities comes down to one extra line in the devfreq target() callback, which selects either the frequency calculated by the devfreq governor, or the one requested with the interconnect API, whichever is higher. All new code works equally well when CONFIG_INTERCONNECT is 'n' (as in exynos_defconfig) in which case all interconnect API functions are no-ops. --- Artur Świgoń Samsung R&D Institute Poland Samsung Electronics --- References: [1] Documentation/interconnect/interconnect.rst [2] Documentation/devicetree/bindings/interconnect/interconnect.txt [3] https://patchwork.kernel.org/patch/10861757 Artur Świgoń (10): devfreq: exynos-bus: Extract exynos_bus_profile_init() devfreq: exynos-bus: Extract exynos_bus_profile_init_passive() devfreq: exynos-bus: Change goto-based logic to if-else logic devfreq: exynos-bus: Clean up code icc: Export of_icc_get_from_provider() icc: Relax requirement in of_icc_get_from_provider() icc: Relax condition in apply_constraints() arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412 devfreq: exynos-bus: Add interconnect functionality to exynos-bus arm: dts: exynos: Add interconnects to Exynos4412 mixer Marek Szyprowski (1): drm: exynos: mixer: Add interconnect support .../boot/dts/exynos4412-odroid-common.dtsi | 1 + arch/arm/boot/dts/exynos4412.dtsi | 10 + drivers/devfreq/exynos-bus.c | 296 ++++++++++++++---- drivers/gpu/drm/exynos/exynos_mixer.c | 68 +++- drivers/interconnect/core.c | 12 +- include/linux/interconnect-provider.h | 6 + 6 files changed, 314 insertions(+), 79 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2019-07-23 12:20 UTC|newest] Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20190723122022eucas1p2f568f74f981f9de9012eb693c3b446d5@eucas1p2.samsung.com> 2019-07-23 12:20 ` Artur Świgoń [this message] 2019-07-23 12:20 ` [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect Artur Świgoń [not found] ` <CGME20190723122022eucas1p1266d90873d564894bd852c20140f8474@eucas1p1.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init() Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:07 ` Krzysztof Kozlowski 2019-07-24 19:07 ` Krzysztof Kozlowski 2019-07-31 13:00 ` Artur Świgoń 2019-07-31 13:00 ` Artur Świgoń 2019-08-05 9:56 ` Krzysztof Kozlowski 2019-08-05 9:56 ` Krzysztof Kozlowski 2019-07-25 12:43 ` Chanwoo Choi 2019-07-25 12:43 ` Chanwoo Choi 2019-07-26 10:42 ` Krzysztof Kozlowski 2019-07-26 10:42 ` Krzysztof Kozlowski 2019-07-26 10:42 ` Krzysztof Kozlowski 2019-07-26 10:52 ` Chanwoo Choi 2019-07-26 10:52 ` Chanwoo Choi [not found] ` <CGME20190723122023eucas1p2ff56c00b60a676ed85d9fe159a1839f2@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 02/11] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive() Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:08 ` Krzysztof Kozlowski 2019-07-24 19:08 ` Krzysztof Kozlowski 2019-07-24 19:08 ` Krzysztof Kozlowski 2019-07-25 12:45 ` Chanwoo Choi 2019-07-25 12:45 ` Chanwoo Choi [not found] ` <CGME20190723122024eucas1p1ff060d072132bfbc8a8a1d10fa1f90f8@eucas1p1.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:10 ` Krzysztof Kozlowski 2019-07-24 19:10 ` Krzysztof Kozlowski 2019-07-25 12:56 ` Chanwoo Choi 2019-07-25 12:56 ` Chanwoo Choi 2019-07-25 13:02 ` Chanwoo Choi 2019-07-25 13:02 ` Chanwoo Choi [not found] ` <CGME20190723122024eucas1p25a480ccddaa69ee1d0f1a07960ca3f22@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 04/11] devfreq: exynos-bus: Clean up code Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:14 ` Krzysztof Kozlowski 2019-07-24 19:14 ` Krzysztof Kozlowski 2019-07-25 12:50 ` Chanwoo Choi 2019-07-25 12:50 ` Chanwoo Choi 2019-07-26 10:45 ` Krzysztof Kozlowski 2019-07-26 10:45 ` Krzysztof Kozlowski 2019-07-26 11:04 ` Chanwoo Choi 2019-07-26 11:04 ` Chanwoo Choi [not found] ` <CGME20190723122025eucas1p251df372451e0b27ad7f2e3c89df60b64@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 05/11] icc: Export of_icc_get_from_provider() Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:15 ` Krzysztof Kozlowski 2019-07-24 19:15 ` Krzysztof Kozlowski 2019-07-24 19:15 ` Krzysztof Kozlowski [not found] ` <CGME20190723122026eucas1p2acf705de2a47ba54f383d916f5383144@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 06/11] icc: Relax requirement in of_icc_get_from_provider() Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:16 ` Krzysztof Kozlowski 2019-07-24 19:16 ` Krzysztof Kozlowski [not found] ` <CGME20190723122027eucas1p124f44370a63b16dcb765585761d661a3@eucas1p1.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 07/11] icc: Relax condition in apply_constraints() Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń [not found] ` <CGME20190723122027eucas1p24b1d76e3139f7cc52614d7613ff9ba98@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412 Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 19:24 ` Krzysztof Kozlowski 2019-07-24 19:24 ` Krzysztof Kozlowski 2019-07-24 19:24 ` Krzysztof Kozlowski 2019-07-31 13:00 ` Artur Świgoń 2019-07-31 13:00 ` Artur Świgoń 2019-07-25 13:13 ` Chanwoo Choi 2019-07-25 13:13 ` Chanwoo Choi 2019-07-26 12:02 ` Marek Szyprowski 2019-07-26 12:02 ` Marek Szyprowski 2019-07-29 1:20 ` Chanwoo Choi 2019-07-29 1:20 ` Chanwoo Choi [not found] ` <CGME20190723122028eucas1p2eb75f35b810e71d6c590370aaff0997b@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 18:36 ` Krzysztof Kozlowski 2019-07-24 18:36 ` Krzysztof Kozlowski 2019-07-31 13:01 ` Artur Świgoń 2019-07-31 13:01 ` Artur Świgoń 2019-07-26 8:05 ` Georgi Djakov 2019-07-26 8:05 ` Georgi Djakov 2019-08-01 7:59 ` Artur Świgoń 2019-08-01 7:59 ` Artur Świgoń 2019-08-07 14:21 ` Georgi Djakov 2019-08-07 14:21 ` Georgi Djakov 2019-08-08 13:28 ` Artur Świgoń 2019-08-08 13:28 ` Artur Świgoń 2019-07-29 1:52 ` Chanwoo Choi 2019-07-29 1:52 ` Chanwoo Choi 2019-08-08 13:18 ` Artur Świgoń 2019-08-08 13:18 ` Artur Świgoń 2019-08-09 2:17 ` Chanwoo Choi 2019-08-09 2:17 ` Chanwoo Choi 2019-08-08 15:00 ` Leonard Crestez 2019-08-08 15:00 ` Leonard Crestez 2019-08-08 15:00 ` Leonard Crestez 2019-08-19 23:44 ` Chanwoo Choi 2019-08-19 23:44 ` Chanwoo Choi 2019-08-19 23:44 ` Chanwoo Choi 2019-08-06 13:41 ` Leonard Crestez 2019-08-06 13:41 ` Leonard Crestez 2019-08-06 13:41 ` Leonard Crestez 2019-08-08 13:19 ` Artur Świgoń 2019-08-08 13:19 ` Artur Świgoń 2019-08-08 13:19 ` Artur Świgoń [not found] ` <CGME20190723122029eucas1p21e1a51e759f9b605d2c89daf659af7bb@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 10/11] arm: dts: exynos: Add interconnects to Exynos4412 mixer Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń [not found] ` <CGME20190723122029eucas1p2915f536d9ef43a7bd043a878a553439f@eucas1p2.samsung.com> 2019-07-23 12:20 ` [RFC PATCH 11/11] drm: exynos: mixer: Add interconnect support Artur Świgoń 2019-07-23 12:20 ` Artur Świgoń 2019-07-24 18:52 ` Krzysztof Kozlowski 2019-07-24 18:52 ` Krzysztof Kozlowski 2019-07-24 18:53 ` [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect Krzysztof Kozlowski 2019-07-24 18:53 ` Krzysztof Kozlowski 2019-07-24 18:53 ` Krzysztof Kozlowski 2019-08-13 6:17 ` Chanwoo Choi 2019-08-13 6:17 ` Chanwoo Choi 2019-08-13 6:19 ` Chanwoo Choi 2019-08-13 6:19 ` Chanwoo Choi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190723122016.30279-1-a.swigon@partner.samsung.com \ --to=a.swigon@partner.samsung.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=georgi.djakov@linaro.org \ --cc=inki.dae@samsung.com \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=myungjoo.ham@samsung.com \ --cc=sw0312.kim@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.