All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org
Cc: pierre-louis.bossart@linux.intel.com,
	"Cezary Rojewski" <cezary.rojewski@intel.com>,
	lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org,
	"Amadeusz Sławiński" <amadeuszx.slawinski@intel.com>
Subject: [RESEND PATCH v2 2/7] ASoC: Intel: Skylake: Combine snd_soc_skl_ipc and snd_soc_skl
Date: Tue, 23 Jul 2019 16:58:49 +0200	[thread overview]
Message-ID: <20190723145854.8527-3-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20190723145854.8527-1-cezary.rojewski@intel.com>

From: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>

As both modules are core part of Skylake driver and none can live
without the other, combine snd_soc_skl_ipc and snd_soc_skl.

It's highly probable IPC module was to be treated as an interface for
platform specific code implementations e.g.: possibility of existence of
BXT specific code without SKL one. However, most funtionalities are
being inherited from one DSP firmware to another, and thus this
assumption fails.

skl-sst, bxt-sst and cnl-sst are not individuals pointing respectively
to SKL (cAVS 1.5), BXT (cAVS 1.5+) & CNL (cAVS 1.8) standalone
implementations. Code found within these is shared among all platforms
whenever necessary to avoid code duplication and reduce development
burden.

Merge also helps in cleaning up internal code in future changes.

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/soc/intel/skylake/Makefile | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/sound/soc/intel/skylake/Makefile b/sound/soc/intel/skylake/Makefile
index 86f6e1d801af..48544ff1a3e6 100644
--- a/sound/soc/intel/skylake/Makefile
+++ b/sound/soc/intel/skylake/Makefile
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
-snd-soc-skl-objs := skl.o skl-pcm.o skl-nhlt.o skl-messages.o \
-skl-topology.o
+snd-soc-skl-objs := skl.o skl-pcm.o skl-nhlt.o skl-messages.o skl-topology.o \
+		skl-sst-ipc.o skl-sst-dsp.o cnl-sst-dsp.o skl-sst-cldma.o \
+		skl-sst.o bxt-sst.o cnl-sst.o skl-sst-utils.o
 
 ifdef CONFIG_DEBUG_FS
   snd-soc-skl-objs += skl-debug.o
@@ -8,13 +9,6 @@ endif
 
 obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += snd-soc-skl.o
 
-# Skylake IPC Support
-snd-soc-skl-ipc-objs := skl-sst-ipc.o skl-sst-dsp.o cnl-sst-dsp.o \
-		skl-sst-cldma.o skl-sst.o bxt-sst.o cnl-sst.o \
-		skl-sst-utils.o
-
-obj-$(CONFIG_SND_SOC_INTEL_SKYLAKE) += snd-soc-skl-ipc.o
-
 #Skylake Clock device support
 snd-soc-skl-ssp-clk-objs := skl-ssp-clk.o
 
-- 
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-07-23 14:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 14:58 [RESEND PATCH v2 0/7] ASoC: Intel: Skylake: Driver fundaments overhaul Cezary Rojewski
2019-07-23 14:58 ` [RESEND PATCH v2 1/7] ASoC: Intel: Skylake: Merge skl_sst and skl into skl_dev struct Cezary Rojewski
2019-07-24 19:17   ` Applied "ASoC: Intel: Skylake: Merge skl_sst and skl into skl_dev struct" to the asoc tree Mark Brown
2019-07-23 14:58 ` Cezary Rojewski [this message]
2019-07-23 14:58 ` [RESEND PATCH v2 3/7] ASoC: Intel: Skylake: Remove MCPS available check Cezary Rojewski
2019-07-24 19:17   ` Applied "ASoC: Intel: Skylake: Remove MCPS available check" to the asoc tree Mark Brown
2019-07-23 14:58 ` [RESEND PATCH v2 4/7] ASoC: Intel: Skylake: Remove memory available check Cezary Rojewski
2019-07-24 19:17   ` Applied "ASoC: Intel: Skylake: Remove memory available check" to the asoc tree Mark Brown
2019-07-23 14:58 ` [RESEND PATCH v2 5/7] ASoC: Intel: Skylake: Do not disable FW notifications Cezary Rojewski
2019-07-23 14:58 ` [RESEND PATCH v2 6/7] ASoC: Intel: Skylake: Make MCPS and CPS params obsolete Cezary Rojewski
2019-07-24 19:17   ` Applied "ASoC: Intel: Skylake: Make MCPS and CPS params obsolete" to the asoc tree Mark Brown
2019-07-23 14:58 ` [RESEND PATCH v2 7/7] ASoC: Intel: Skylake: Cleanup skl_module_cfg declaration Cezary Rojewski
2019-07-24 19:17   ` Applied "ASoC: Intel: Skylake: Cleanup skl_module_cfg declaration" to the asoc tree Mark Brown
2019-07-23 15:44 ` [RESEND PATCH v2 0/7] ASoC: Intel: Skylake: Driver fundaments overhaul Mark Brown
2019-07-23 18:07   ` Pierre-Louis Bossart
2019-07-24 16:50     ` Mark Brown
2019-07-24 17:14     ` Cezary Rojewski
2019-07-24 18:10       ` Mark Brown
2019-07-24 12:39 ` Vinod Koul
2019-07-24 12:42 ` Vinod Koul
2019-07-26 11:31   ` Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723145854.8527-3-cezary.rojewski@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@intel.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.