From: john.hubbard@gmail.com To: Andrew Morton <akpm@linux-foundation.org> Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>, "Anna Schumaker" <anna.schumaker@netapp.com>, "David S . Miller" <davem@davemloft.net>, "Dominique Martinet" <asmadeus@codewreck.org>, "Eric Van Hensbergen" <ericvh@gmail.com>, "Jason Gunthorpe" <jgg@ziepe.ca>, "Jason Wang" <jasowang@redhat.com>, "Jens Axboe" <axboe@kernel.dk>, "Latchesar Ionkov" <lucho@ionkov.net>, "Michael S . Tsirkin" <mst@redhat.com>, "Miklos Szeredi" <miklos@szeredi.hu>, "Trond Myklebust" <trond.myklebust@hammerspace.com>, "Christoph Hellwig" <hch@lst.de>, "Matthew Wilcox" <willy@infradead.org>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, ceph-devel@vger.kernel.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, samba-technical@lists.samba.org, v9fs-developer@lists.sourceforge.net, virtualization@lists.linux-foundation.org, "Jérôme Glisse" <jglisse@redhat.com>, "John Hubbard" <jhubbard@nvidia.com>, "Jan Kara" <jack@suse.cz>, "Dan Williams" <dan.j.williams@intel.com>, "Johannes Thumshirn" <jthumshirn@suse.de>, "Ming Lei" <ming.lei@redhat.com>, "Dave Chinner" <david@fromorbit.com>, "Boaz Harrosh" <boaz@plexistor.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com> Subject: [PATCH 07/12] vhost-scsi: convert put_page() to put_user_page*() Date: Tue, 23 Jul 2019 21:25:13 -0700 [thread overview] Message-ID: <20190724042518.14363-8-jhubbard@nvidia.com> (raw) In-Reply-To: <20190724042518.14363-1-jhubbard@nvidia.com> From: Jérôme Glisse <jglisse@redhat.com> For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Changes from Jérôme's original patch: * Changed a WARN_ON to a BUG_ON. Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Signed-off-by: John Hubbard <jhubbard@nvidia.com> Cc: virtualization@lists.linux-foundation.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-block@vger.kernel.org Cc: linux-mm@kvack.org Cc: Jan Kara <jack@suse.cz> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Johannes Thumshirn <jthumshirn@suse.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Ming Lei <ming.lei@redhat.com> Cc: Dave Chinner <david@fromorbit.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Matthew Wilcox <willy@infradead.org> Cc: Boaz Harrosh <boaz@plexistor.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Jason Wang <jasowang@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> --- drivers/vhost/scsi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index a9caf1bc3c3e..282565ab5e3f 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -329,11 +329,11 @@ static void vhost_scsi_release_cmd(struct se_cmd *se_cmd) if (tv_cmd->tvc_sgl_count) { for (i = 0; i < tv_cmd->tvc_sgl_count; i++) - put_page(sg_page(&tv_cmd->tvc_sgl[i])); + put_user_page(sg_page(&tv_cmd->tvc_sgl[i])); } if (tv_cmd->tvc_prot_sgl_count) { for (i = 0; i < tv_cmd->tvc_prot_sgl_count; i++) - put_page(sg_page(&tv_cmd->tvc_prot_sgl[i])); + put_user_page(sg_page(&tv_cmd->tvc_prot_sgl[i])); } vhost_scsi_put_inflight(tv_cmd->inflight); @@ -630,6 +630,13 @@ vhost_scsi_map_to_sgl(struct vhost_scsi_cmd *cmd, size_t offset; unsigned int npages = 0; + /* + * Here in all cases we should have an IOVEC which use GUP. If that is + * not the case then we will wrongly call put_user_page() and the page + * refcount will go wrong (this is in vhost_scsi_release_cmd()) + */ + WARN_ON(!iov_iter_get_pages_use_gup(iter)); + bytes = iov_iter_get_pages(iter, pages, LONG_MAX, VHOST_SCSI_PREALLOC_UPAGES, &offset); /* No pages were pinned */ @@ -681,7 +688,7 @@ vhost_scsi_iov_to_sgl(struct vhost_scsi_cmd *cmd, bool write, while (p < sg) { struct page *page = sg_page(p++); if (page) - put_page(page); + put_user_page(page); } return ret; } -- 2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com To: Andrew Morton <akpm@linux-foundation.org> Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Anna Schumaker <anna.schumaker@netapp.com>, "David S . Miller" <davem@davemloft.net>, Dominique Martinet <asmadeus@codewreck.org>, Eric Van Hensbergen <ericvh@gmail.com>, Jason Gunthorpe <jgg@ziepe.ca>, Jason Wang <jasowang@redhat.com>, Jens Axboe <axboe@kernel.dk>, Latchesar Ionkov <lucho@ionkov.net>, "Michael S . Tsirkin" <mst@redhat.com>, Miklos Szeredi <miklos@szeredi.hu>, Trond Myklebust <trond.myklebust@hammerspace.com>, Christoph Hellwig <hch@lst.de>, Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, ceph-devel@vger.kernel.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.orglinu Subject: [PATCH 07/12] vhost-scsi: convert put_page() to put_user_page*() Date: Tue, 23 Jul 2019 21:25:13 -0700 [thread overview] Message-ID: <20190724042518.14363-8-jhubbard@nvidia.com> (raw) In-Reply-To: <20190724042518.14363-1-jhubbard@nvidia.com> From: Jérôme Glisse <jglisse@redhat.com> For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder versions"). Changes from Jérôme's original patch: * Changed a WARN_ON to a BUG_ON. Signed-off-by: Jérôme Glisse <jglisse@redhat.com> Signed-off-by: John Hubbard <jhubbard@nvidia.com> Cc: virtualization@lists.linux-foundation.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-block@vger.kernel.org Cc: linux-mm@kvack.org Cc: Jan Kara <jack@suse.cz> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Johannes Thumshirn <jthumshirn@suse.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Ming Lei <ming.lei@redhat.com> Cc: Dave Chinner <david@fromorbit.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Matthew Wilcox <willy@infradead.org> Cc: Boaz Harrosh <boaz@plexistor.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Jason Wang <jasowang@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> --- drivers/vhost/scsi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index a9caf1bc3c3e..282565ab5e3f 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -329,11 +329,11 @@ static void vhost_scsi_release_cmd(struct se_cmd *se_cmd) if (tv_cmd->tvc_sgl_count) { for (i = 0; i < tv_cmd->tvc_sgl_count; i++) - put_page(sg_page(&tv_cmd->tvc_sgl[i])); + put_user_page(sg_page(&tv_cmd->tvc_sgl[i])); } if (tv_cmd->tvc_prot_sgl_count) { for (i = 0; i < tv_cmd->tvc_prot_sgl_count; i++) - put_page(sg_page(&tv_cmd->tvc_prot_sgl[i])); + put_user_page(sg_page(&tv_cmd->tvc_prot_sgl[i])); } vhost_scsi_put_inflight(tv_cmd->inflight); @@ -630,6 +630,13 @@ vhost_scsi_map_to_sgl(struct vhost_scsi_cmd *cmd, size_t offset; unsigned int npages = 0; + /* + * Here in all cases we should have an IOVEC which use GUP. If that is + * not the case then we will wrongly call put_user_page() and the page + * refcount will go wrong (this is in vhost_scsi_release_cmd()) + */ + WARN_ON(!iov_iter_get_pages_use_gup(iter)); + bytes = iov_iter_get_pages(iter, pages, LONG_MAX, VHOST_SCSI_PREALLOC_UPAGES, &offset); /* No pages were pinned */ @@ -681,7 +688,7 @@ vhost_scsi_iov_to_sgl(struct vhost_scsi_cmd *cmd, bool write, while (p < sg) { struct page *page = sg_page(p++); if (page) - put_page(page); + put_user_page(page); } return ret; } -- 2.22.0
next prev parent reply other threads:[~2019-07-24 4:26 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-24 4:25 [PATCH 00/12] block/bio, fs: convert put_page() to put_user_page*() john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 01/12] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 02/12] iov_iter: add helper to test if an iter would use GUP v2 john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 03/12] block: bio_release_pages: use flags arg instead of bool john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 5:30 ` Christoph Hellwig 2019-07-24 5:30 ` Christoph Hellwig 2019-07-24 5:30 ` Christoph Hellwig 2019-07-29 20:57 ` Jerome Glisse 2019-07-29 20:57 ` Jerome Glisse 2019-07-30 10:25 ` Christoph Hellwig 2019-07-30 10:25 ` Christoph Hellwig 2019-07-30 15:57 ` Jerome Glisse 2019-07-30 15:57 ` Jerome Glisse 2019-07-30 15:57 ` Jerome Glisse 2019-08-01 8:20 ` Christoph Hellwig 2019-08-01 8:20 ` Christoph Hellwig 2019-08-01 8:20 ` Christoph Hellwig 2019-07-30 10:25 ` Christoph Hellwig 2019-07-29 20:57 ` Jerome Glisse 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 04/12] block: bio_release_pages: convert put_page() to put_user_page*() john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 05/12] block_dev: " john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 06/12] fs/nfs: " john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard [this message] 2019-07-24 4:25 ` [PATCH 07/12] vhost-scsi: " john.hubbard 2019-07-24 4:34 ` John Hubbard 2019-07-24 4:34 ` John Hubbard 2019-07-24 4:34 ` John Hubbard 2019-07-24 8:07 ` Michael S. Tsirkin 2019-07-24 8:07 ` Michael S. Tsirkin 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 08/12] fs/cifs: " john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 09/12] fs/fuse: " john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 10/12] fs/ceph: " john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 11/12] 9p/net: " john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` [PATCH 12/12] fs/ceph: fix a build warning: returning a value from void function john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 4:25 ` john.hubbard 2019-07-24 6:17 ` [PATCH 00/12] block/bio, fs: convert put_page() to put_user_page*() Christoph Hellwig 2019-07-24 6:17 ` Christoph Hellwig 2019-07-24 6:17 ` Christoph Hellwig 2019-07-24 23:23 ` John Hubbard 2019-07-24 23:23 ` John Hubbard 2019-08-05 22:54 ` John Hubbard 2019-08-05 22:54 ` John Hubbard 2019-08-07 6:34 ` Christoph Hellwig 2019-08-07 6:34 ` Christoph Hellwig 2019-08-07 6:34 ` Christoph Hellwig 2019-08-07 6:38 ` John Hubbard 2019-08-07 6:38 ` John Hubbard 2019-07-25 0:41 ` Bob Liu 2019-07-25 0:41 ` Bob Liu 2019-07-26 1:24 ` John Hubbard 2019-07-26 1:24 ` John Hubbard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190724042518.14363-8-jhubbard@nvidia.com \ --to=john.hubbard@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=anna.schumaker@netapp.com \ --cc=asmadeus@codewreck.org \ --cc=axboe@kernel.dk \ --cc=boaz@plexistor.com \ --cc=ceph-devel@vger.kernel.org \ --cc=dan.j.williams@intel.com \ --cc=davem@davemloft.net \ --cc=david@fromorbit.com \ --cc=ericvh@gmail.com \ --cc=hch@lst.de \ --cc=jack@suse.cz \ --cc=jasowang@redhat.com \ --cc=jgg@ziepe.ca \ --cc=jglisse@redhat.com \ --cc=jhubbard@nvidia.com \ --cc=jthumshirn@suse.de \ --cc=kvm@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nfs@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=lucho@ionkov.net \ --cc=miklos@szeredi.hu \ --cc=ming.lei@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=samba-technical@lists.samba.org \ --cc=stefanha@redhat.com \ --cc=trond.myklebust@hammerspace.com \ --cc=v9fs-developer@lists.sourceforge.net \ --cc=viro@zeniv.linux.org.uk \ --cc=virtualization@lists.linux-foundation.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.