All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin King <colin.king@canonical.com>
To: Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	linux-pm@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators
Date: Mon, 29 Jul 2019 13:03:23 +0100	[thread overview]
Message-ID: <20190729120323.15838-1-colin.king@canonical.com> (raw)

From: Colin Ian King <colin.king@canonical.com>

The variable val is having the top 8 bits cleared and then the variable is being
re-assinged and setting just the top 8 bits.  I believe the intention was bitwise-or
in the top 8 bits.  Fix this by replacing the = operators with &= and |= instead.

Addresses-Coverity: ("Unused value")
Fixes: b0c74b08517e ("drivers: thermal: processor_thermal_device: Export sysfs inteface for TCC offset")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---

V2: Add in &= operator missing from V1. Doh.

---
 .../thermal/intel/int340x_thermal/processor_thermal_device.c  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
index 6f6ac6a8e82d..97333fc4be42 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
@@ -163,8 +163,8 @@ static int tcc_offset_update(int tcc)
 	if (err)
 		return err;
 
-	val = ~GENMASK_ULL(31, 24);
-	val = (tcc & 0xff) << 24;
+	val &= ~GENMASK_ULL(31, 24);
+	val |= (tcc & 0xff) << 24;
 
 	err = wrmsrl_safe(MSR_IA32_TEMPERATURE_TARGET, val);
 	if (err)
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Colin King <colin.king@canonical.com>
To: Zhang Rui <rui.zhang@intel.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	linux-pm@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators
Date: Mon, 29 Jul 2019 12:03:23 +0000	[thread overview]
Message-ID: <20190729120323.15838-1-colin.king@canonical.com> (raw)

From: Colin Ian King <colin.king@canonical.com>

The variable val is having the top 8 bits cleared and then the variable is being
re-assinged and setting just the top 8 bits.  I believe the intention was bitwise-or
in the top 8 bits.  Fix this by replacing the = operators with &= and |= instead.

Addresses-Coverity: ("Unused value")
Fixes: b0c74b08517e ("drivers: thermal: processor_thermal_device: Export sysfs inteface for TCC offset")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---

V2: Add in &= operator missing from V1. Doh.

---
 .../thermal/intel/int340x_thermal/processor_thermal_device.c  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
index 6f6ac6a8e82d..97333fc4be42 100644
--- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
+++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
@@ -163,8 +163,8 @@ static int tcc_offset_update(int tcc)
 	if (err)
 		return err;
 
-	val = ~GENMASK_ULL(31, 24);
-	val = (tcc & 0xff) << 24;
+	val &= ~GENMASK_ULL(31, 24);
+	val |= (tcc & 0xff) << 24;
 
 	err = wrmsrl_safe(MSR_IA32_TEMPERATURE_TARGET, val);
 	if (err)
-- 
2.20.1

             reply	other threads:[~2019-07-29 12:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 12:03 Colin King [this message]
2019-07-29 12:03 ` [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators Colin King
2019-07-29 12:34 ` walter harms
2019-07-29 12:34   ` walter harms
2019-07-29 21:09 ` Srinivas Pandruvada
2019-07-29 21:09   ` Srinivas Pandruvada
2019-08-19  6:32   ` Zhang Rui
2019-08-19  6:32     ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190729120323.15838-1-colin.king@canonical.com \
    --to=colin.king@canonical.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.