From: Mark Balantzyan <mbalant3@gmail.com>
To: linux@roeck-us.net
Cc: wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, andrianov@ispras.ru,
Mark Balantzyan <mbalant3@gmail.com>
Subject: [PATCH 4/4] watchdog device drivers:pc87413_wdt: Continuing revision of conversion of pc87413_wdt to use common watchdog interface, removed undeclared identifiers
Date: Mon, 29 Jul 2019 19:15:40 -0700 [thread overview]
Message-ID: <20190730021540.66579-4-mbalant3@gmail.com> (raw)
In-Reply-To: <20190730021540.66579-1-mbalant3@gmail.com>
There is a potential for the variable swc_base_addr in the call chain of the
driver initialization function (init) to be used before initialization. This
brought up the need for, by rewriting the driver to use the common watchdog
interface, ensuring to have all resources in place. This patch addresses this
need by rewriting into common watchdog interface utilization for the driver.
Signed-off-by: Mark Balantzyan <mbalant3@gmail.com>
---
drivers/watchdog/pc87413_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
index bc6c4e19..6863145a 100644
--- a/drivers/watchdog/pc87413_wdt.c
+++ b/drivers/watchdog/pc87413_wdt.c
@@ -370,7 +370,6 @@ reboot_unreg:
static void __exit pc87413_exit(void)
{
watchdog_unregister_device(&pc87413wdt_wdd);
- unregister_reboot_notifier(&pc87413_notifier);
release_region(swc_base_addr, 0x20);
pr_info("watchdog component driver removed\n");
--
2.17.1
next prev parent reply other threads:[~2019-07-30 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 2:15 [PATCH 1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface Mark Balantzyan
2019-07-30 2:15 ` [PATCH 2/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface, with removal of file access functions for correct functionality Mark Balantzyan
2019-07-30 2:15 ` [PATCH 3/4] watchdog device drivers:pc87413_wdt: Tidying up conversion of pc87413_wdt driver to common watchdog interface, removal of some stray nowayout parameters Mark Balantzyan
2019-07-30 2:35 ` Guenter Roeck
2019-07-30 2:15 ` Mark Balantzyan [this message]
2019-07-30 2:28 ` [PATCH 4/4] watchdog device drivers:pc87413_wdt: Continuing revision of conversion of pc87413_wdt to use common watchdog interface, removed undeclared identifiers Guenter Roeck
2019-07-30 2:33 ` [PATCH 1/4] watchdog device drivers:pc87413_wdt:Rewriting of pc87413_wdt driver to utilize common watchdog interface Guenter Roeck
2019-07-30 2:38 ` Guenter Roeck
2019-07-30 2:47 ` Mark Balantzyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730021540.66579-4-mbalant3@gmail.com \
--to=mbalant3@gmail.com \
--cc=andrianov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.