All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
To: jorge.ramirez-ortiz@linaro.org, bjorn.andersson@linaro.org,
	sboyd@kernel.org, david.brown@linaro.org,
	jassisinghbrar@gmail.com, mark.rutland@arm.com,
	mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com,
	arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de,
	sibis@codeaurora.org, enric.balletbo@collabora.com,
	jagan@amarulasolutions.com, olof@lixom.net
Cc: vkoul@kernel.org, niklas.cassel@linaro.org,
	georgi.djakov@linaro.org, amit.kucheria@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org
Subject: [PATCH v4 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property
Date: Wed, 31 Jul 2019 22:29:20 +0200	[thread overview]
Message-ID: <20190731202929.16443-5-jorge.ramirez-ortiz@linaro.org> (raw)
In-Reply-To: <20190731202929.16443-1-jorge.ramirez-ortiz@linaro.org>

When the APCS clock is registered (platform dependent), it retrieves
its parent names from hardcoded values in the driver.

The following commit allows the DT node to provide such clock names to
the platform data based clock driver therefore avoiding having to
explicitly embed those names in the clock driver source code.

Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 .../mailbox/qcom,apcs-kpss-global.txt         | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
index 1232fc9fc709..b69310322b09 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
@@ -18,10 +18,11 @@ platforms.
 	Usage: required
 	Value type: <prop-encoded-array>
 	Definition: must specify the base address and size of the global block
+
 - clocks:
-	Usage: required if #clocks-cells property is present
-	Value type: <phandle>
-	Definition: phandle to the input PLL, which feeds the APCS mux/divider
+	Usage: required if #clock-names property is present
+	Value type: <phandle array>
+	Definition: phandles to the two parent clocks of the clock driver.
 
 - #mbox-cells:
 	Usage: required
@@ -33,6 +34,12 @@ platforms.
 	Value type: <u32>
 	Definition: as described in clock.txt, must be 0
 
+- clock-names:
+	Usage: required if the platform data based clock driver needs to
+	retrieve the parent clock names from device tree.
+	This will requires two mandatory clocks to be defined.
+	Value type: <string-array>
+	Definition: must be "aux" and "pll"
 
 = EXAMPLE
 The following example describes the APCS HMSS found in MSM8996 and part of the
@@ -65,3 +72,14 @@ Below is another example of the APCS binding on MSM8916 platforms:
 		clocks = <&a53pll>;
 		#clock-cells = <0>;
 	};
+
+Below is another example of the APCS binding on QCS404 platforms:
+
+	apcs_glb: mailbox@b011000 {
+		compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+		reg = <0x0b011000 0x1000>;
+		#mbox-cells = <1>;
+		clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>;
+		clock-names = "aux", "pll";
+		#clock-cells = <0>;
+	};
-- 
2.22.0


WARNING: multiple messages have this Message-ID (diff)
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
To: jorge.ramirez-ortiz@linaro.org, bjorn.andersson@linaro.org,
	sboyd@kernel.org, david.brown@linaro.org,
	jassisinghbrar@gmail.com, mark.rutland@arm.com,
	mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com,
	arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de,
	sibis@codeaurora.org, enric.balletbo@collabora.com,
	jagan@amarulasolutions.com, olof@lixom.net
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	khasim.mohammed@linaro.org, linux-kernel@vger.kernel.org,
	amit.kucheria@linaro.org, linux-clk@vger.kernel.org,
	vkoul@kernel.org, niklas.cassel@linaro.org,
	georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property
Date: Wed, 31 Jul 2019 22:29:20 +0200	[thread overview]
Message-ID: <20190731202929.16443-5-jorge.ramirez-ortiz@linaro.org> (raw)
In-Reply-To: <20190731202929.16443-1-jorge.ramirez-ortiz@linaro.org>

When the APCS clock is registered (platform dependent), it retrieves
its parent names from hardcoded values in the driver.

The following commit allows the DT node to provide such clock names to
the platform data based clock driver therefore avoiding having to
explicitly embed those names in the clock driver source code.

Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 .../mailbox/qcom,apcs-kpss-global.txt         | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
index 1232fc9fc709..b69310322b09 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
@@ -18,10 +18,11 @@ platforms.
 	Usage: required
 	Value type: <prop-encoded-array>
 	Definition: must specify the base address and size of the global block
+
 - clocks:
-	Usage: required if #clocks-cells property is present
-	Value type: <phandle>
-	Definition: phandle to the input PLL, which feeds the APCS mux/divider
+	Usage: required if #clock-names property is present
+	Value type: <phandle array>
+	Definition: phandles to the two parent clocks of the clock driver.
 
 - #mbox-cells:
 	Usage: required
@@ -33,6 +34,12 @@ platforms.
 	Value type: <u32>
 	Definition: as described in clock.txt, must be 0
 
+- clock-names:
+	Usage: required if the platform data based clock driver needs to
+	retrieve the parent clock names from device tree.
+	This will requires two mandatory clocks to be defined.
+	Value type: <string-array>
+	Definition: must be "aux" and "pll"
 
 = EXAMPLE
 The following example describes the APCS HMSS found in MSM8996 and part of the
@@ -65,3 +72,14 @@ Below is another example of the APCS binding on MSM8916 platforms:
 		clocks = <&a53pll>;
 		#clock-cells = <0>;
 	};
+
+Below is another example of the APCS binding on QCS404 platforms:
+
+	apcs_glb: mailbox@b011000 {
+		compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+		reg = <0x0b011000 0x1000>;
+		#mbox-cells = <1>;
+		clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>;
+		clock-names = "aux", "pll";
+		#clock-cells = <0>;
+	};
-- 
2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
To: jorge.ramirez-ortiz@linaro.org, bjorn.andersson@linaro.org,
	sboyd@kernel.org, david.brown@linaro.org,
	jassisinghbrar@gmail.com, mark.rutland@arm.com,
	mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com,
	arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de,
	sibis@codeaurora.org, enric.balletbo@collabora.com,
	jagan@amarulasolutions.com, olof@lixom.net
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	khasim.mohammed@linaro.org, linux-kernel@vger.kernel.org,
	amit.kucheria@linaro.org, linux-clk@vger.kernel.org,
	vkoul@kernel.org, niklas.cassel@linaro.org,
	georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property
Date: Wed, 31 Jul 2019 22:29:20 +0200	[thread overview]
Message-ID: <20190731202929.16443-5-jorge.ramirez-ortiz@linaro.org> (raw)
In-Reply-To: <20190731202929.16443-1-jorge.ramirez-ortiz@linaro.org>

When the APCS clock is registered (platform dependent), it retrieves
its parent names from hardcoded values in the driver.

The following commit allows the DT node to provide such clock names to
the platform data based clock driver therefore avoiding having to
explicitly embed those names in the clock driver source code.

Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 .../mailbox/qcom,apcs-kpss-global.txt         | 24 ++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
index 1232fc9fc709..b69310322b09 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt
@@ -18,10 +18,11 @@ platforms.
 	Usage: required
 	Value type: <prop-encoded-array>
 	Definition: must specify the base address and size of the global block
+
 - clocks:
-	Usage: required if #clocks-cells property is present
-	Value type: <phandle>
-	Definition: phandle to the input PLL, which feeds the APCS mux/divider
+	Usage: required if #clock-names property is present
+	Value type: <phandle array>
+	Definition: phandles to the two parent clocks of the clock driver.
 
 - #mbox-cells:
 	Usage: required
@@ -33,6 +34,12 @@ platforms.
 	Value type: <u32>
 	Definition: as described in clock.txt, must be 0
 
+- clock-names:
+	Usage: required if the platform data based clock driver needs to
+	retrieve the parent clock names from device tree.
+	This will requires two mandatory clocks to be defined.
+	Value type: <string-array>
+	Definition: must be "aux" and "pll"
 
 = EXAMPLE
 The following example describes the APCS HMSS found in MSM8996 and part of the
@@ -65,3 +72,14 @@ Below is another example of the APCS binding on MSM8916 platforms:
 		clocks = <&a53pll>;
 		#clock-cells = <0>;
 	};
+
+Below is another example of the APCS binding on QCS404 platforms:
+
+	apcs_glb: mailbox@b011000 {
+		compatible = "qcom,qcs404-apcs-apps-global", "syscon";
+		reg = <0x0b011000 0x1000>;
+		#mbox-cells = <1>;
+		clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>;
+		clock-names = "aux", "pll";
+		#clock-cells = <0>;
+	};
-- 
2.22.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-07-31 20:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 20:29 [PATCH v4 00/13] Support CPU frequency scaling on QCS404 Jorge Ramirez-Ortiz
2019-07-31 20:29 ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 01/13] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 02/13] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 03/13] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` Jorge Ramirez-Ortiz [this message]
2019-07-31 20:29   ` [PATCH v4 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 05/13] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 06/13] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 07/13] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 08/13] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 09/13] arm64: dts: qcom: msm8916: Add the clocks for the APCS mux/divider Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 10/13] arm64: dts: qcom: qcs404: Add HFPLL node Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 11/13] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 12/13] arm64: dts: qcom: qcs404: Add DVFS support Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-07-31 20:29 ` [PATCH v4 13/13] arm64: defconfig: Enable HFPLL Jorge Ramirez-Ortiz
2019-07-31 20:29   ` Jorge Ramirez-Ortiz
2019-08-26  6:54 ` [PATCH v4 00/13] Support CPU frequency scaling on QCS404 Jorge Ramirez
2019-08-26  6:54   ` Jorge Ramirez
2019-08-26 16:49   ` Jorge Ramirez
2019-08-26 16:49     ` Jorge Ramirez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190731202929.16443-5-jorge.ramirez-ortiz@linaro.org \
    --to=jorge.ramirez-ortiz@linaro.org \
    --cc=amit.kucheria@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=georgi.djakov@linaro.org \
    --cc=heiko@sntech.de \
    --cc=horms+renesas@verge.net.au \
    --cc=jagan@amarulasolutions.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=khasim.mohammed@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=niklas.cassel@linaro.org \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=vkoul@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.