All of lore.kernel.org
 help / color / mirror / Atom feed
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org,
	devel@driverdev.osuosl.org, devel@lists.orangefs.org,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-mm@kvack.org,
	linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org, linux-xfs@vger.kernel.org,
	netdev@vger.kernel.org, rds-devel@oss.oracle.com,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Sudeep Dutt" <sudeep.dutt@intel.com>,
	"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
	"Arnd Bergmann" <arnd@arndb.de>, "Joerg Roedel" <jroedel@suse.de>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Zhen Lei" <thunder.leizhen@huawei.com>
Subject: [PATCH v2 11/34] scif: convert put_page() to put_user_page*()
Date: Sun,  4 Aug 2019 15:48:52 -0700	[thread overview]
Message-ID: <20190804224915.28669-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190804224915.28669-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0


WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org,
	devel@driverdev.osuosl.org, devel@lists.orangefs.org,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-mm@kvack.org,
	linux-nfs@vger.kernel.or
Subject: [PATCH v2 11/34] scif: convert put_page() to put_user_page*()
Date: Sun, 04 Aug 2019 22:48:52 +0000	[thread overview]
Message-ID: <20190804224915.28669-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190804224915.28669-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org,
	devel@driverdev.osuosl.org, devel@lists.orangefs.org,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-mm@kvack.org,
	linux-nfs@vger.kernel.or
Subject: [PATCH v2 11/34] scif: convert put_page() to put_user_page*()
Date: Sun,  4 Aug 2019 15:48:52 -0700	[thread overview]
Message-ID: <20190804224915.28669-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190804224915.28669-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com (john.hubbard@gmail.com)
Subject: [PATCH v2 11/34] scif: convert put_page() to put_user_page*()
Date: Sun,  4 Aug 2019 15:48:52 -0700	[thread overview]
Message-ID: <20190804224915.28669-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190804224915.28669-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt at intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
Cc: Arnd Bergmann <arnd at arndb.de>
Cc: Joerg Roedel <jroedel at suse.de>
Cc: Robin Murphy <robin.murphy at arm.com>
Cc: Zhen Lei <thunder.leizhen at huawei.com>
Signed-off-by: John Hubbard <jhubbard at nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
	kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Sudeep Dutt" <sudeep.dutt@intel.com>,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	sparclinux@vger.kernel.org, "Ira Weiny" <ira.weiny@intel.com>,
	ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org,
	"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
	rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
	x86@kernel.org, amd-gfx@lists.freedesktop.org,
	"Christoph Hellwig" <hch@infradead.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	xen-devel@lists.xenproject.org, devel@lists.orangefs.org,
	linux-media@vger.kernel.org, "Joerg Roedel" <jroedel@suse.de>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"John Hubbard" <jhubbard@nvidia.com>,
	intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
	"Jérôme Glisse" <jglisse@redhat.com>,
	linux-rpi-kernel@lists.infradead.org,
	"Zhen Lei" <thunder.leizhen@huawei.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-xfs@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	"Robin Murphy" <robin.murphy@arm.com>
Subject: [PATCH v2 11/34] scif: convert put_page() to put_user_page*()
Date: Sun,  4 Aug 2019 15:48:52 -0700	[thread overview]
Message-ID: <20190804224915.28669-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190804224915.28669-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: john.hubbard@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
	kvm@vger.kernel.org, "Dave Hansen" <dave.hansen@linux.intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Sudeep Dutt" <sudeep.dutt@intel.com>,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	sparclinux@vger.kernel.org, "Ira Weiny" <ira.weiny@intel.com>,
	ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org,
	"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
	rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
	x86@kernel.org, amd-gfx@lists.freedesktop.org,
	"Christoph Hellwig" <hch@infradead.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	xen-devel@lists.xenproject.org, devel@lists.orangefs.org,
	linux-media@vger.kernel.org, "Joerg Roedel" <jroedel@suse.de>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"John Hubbard" <jhubbard@nvidia.com>,
	intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org,
	"Jérôme Glisse" <jglisse@redhat.com>,
	linux-rpi-kernel@lists.infradead.org,
	"Zhen Lei" <thunder.leizhen@huawei.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-xfs@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	"Robin Murphy" <robin.murphy@arm.com>
Subject: [Xen-devel] [PATCH v2 11/34] scif: convert put_page() to put_user_page*()
Date: Sun,  4 Aug 2019 15:48:52 -0700	[thread overview]
Message-ID: <20190804224915.28669-12-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190804224915.28669-1-jhubbard@nvidia.com>

From: John Hubbard <jhubbard@nvidia.com>

For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page() or
release_pages().

This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").

Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 drivers/misc/mic/scif/scif_rma.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_rma.c b/drivers/misc/mic/scif/scif_rma.c
index 01e27682ea30..d84ed9466920 100644
--- a/drivers/misc/mic/scif/scif_rma.c
+++ b/drivers/misc/mic/scif/scif_rma.c
@@ -113,13 +113,14 @@ static int scif_destroy_pinned_pages(struct scif_pinned_pages *pin)
 	int writeable = pin->prot & SCIF_PROT_WRITE;
 	int kernel = SCIF_MAP_KERNEL & pin->map_flags;
 
-	for (j = 0; j < pin->nr_pages; j++) {
-		if (pin->pages[j] && !kernel) {
+	if (kernel) {
+		for (j = 0; j < pin->nr_pages; j++) {
 			if (writeable)
-				SetPageDirty(pin->pages[j]);
+				set_page_dirty_lock(pin->pages[j]);
 			put_page(pin->pages[j]);
 		}
-	}
+	} else
+		put_user_pages_dirty_lock(pin->pages, pin->nr_pages, writeable);
 
 	scif_free(pin->pages,
 		  pin->nr_pages * sizeof(*pin->pages));
@@ -1385,11 +1386,9 @@ int __scif_pin_pages(void *addr, size_t len, int *out_prot,
 				if (ulimit)
 					__scif_dec_pinned_vm_lock(mm, nr_pages);
 				/* Roll back any pinned pages */
-				for (i = 0; i < pinned_pages->nr_pages; i++) {
-					if (pinned_pages->pages[i])
-						put_page(
-						pinned_pages->pages[i]);
-				}
+				put_user_pages(pinned_pages->pages,
+					       pinned_pages->nr_pages);
+
 				prot &= ~SCIF_PROT_WRITE;
 				try_upgrade = false;
 				goto retry;
-- 
2.22.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-08-04 22:55 UTC|newest]

Thread overview: 250+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-04 22:48 [PATCH v2 00/34] put_user_pages(): miscellaneous call sites john.hubbard
2019-08-04 22:48 ` [Xen-devel] " john.hubbard
2019-08-04 22:48 ` john.hubbard
2019-08-04 22:48 ` john.hubbard
2019-08-04 22:48 ` john.hubbard
2019-08-04 22:48 ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-06 17:39   ` Ira Weiny
2019-08-06 17:39     ` [Xen-devel] " Ira Weiny
2019-08-06 17:39     ` Ira Weiny
2019-08-06 17:39     ` Ira Weiny
2019-08-06 17:39     ` Ira Weiny
2019-08-06 17:39     ` Ira Weiny
2019-08-06 20:39     ` John Hubbard
2019-08-06 20:39       ` [Xen-devel] " John Hubbard
2019-08-06 20:39       ` John Hubbard
2019-08-06 20:39       ` John Hubbard
2019-08-06 20:39       ` John Hubbard
2019-08-06 20:39       ` John Hubbard
2019-08-06 20:39       ` John Hubbard
2019-08-04 22:48 ` [PATCH v2 02/34] net/rds: convert put_page() to put_user_page*() john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 03/34] net/ceph: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 04/34] x86/kvm: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 05/34] drm/etnaviv: convert release_pages() to put_user_pages() john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 06/34] drm/i915: convert put_page() to put_user_page*() john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-05 16:53   ` Rodrigo Vivi
2019-08-05 16:53     ` [Xen-devel] " Rodrigo Vivi
2019-08-05 16:53     ` Rodrigo Vivi
2019-08-05 16:53     ` Rodrigo Vivi
2019-08-05 16:53     ` Rodrigo Vivi
2019-08-05 16:53     ` Rodrigo Vivi
2019-08-04 22:48 ` [PATCH v2 07/34] drm/radeon: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 08/34] media/ivtv: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 09/34] media/v4l2-core/mm: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 10/34] genwqe: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` john.hubbard [this message]
2019-08-04 22:48   ` [Xen-devel] [PATCH v2 11/34] scif: " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 12/34] vmci: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 13/34] rapidio: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 14/34] oradax: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 15/34] staging/vc04_services: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-13  5:23   ` Stefan Wahren
2019-08-13  5:23     ` [Xen-devel] " Stefan Wahren
2019-08-13  5:23     ` Stefan Wahren
2019-08-13  5:23     ` Stefan Wahren
2019-08-13  5:23     ` Stefan Wahren
2019-08-13  5:23     ` Stefan Wahren
2019-08-04 22:48 ` [PATCH v2 16/34] drivers/tee: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 17/34] vfio: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48 ` [PATCH v2 18/34] fbdev/pvr2fb: " john.hubbard
2019-08-04 22:48   ` [Xen-devel] " john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:48   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 19/34] fsl_hypervisor: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 20/34] xen: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-05  4:15   ` Juergen Gross
2019-08-05  4:15     ` [Xen-devel] " Juergen Gross
2019-08-05  4:15     ` Juergen Gross
2019-08-05  4:15     ` Juergen Gross
2019-08-05  4:15     ` Juergen Gross
2019-08-05  4:15     ` Juergen Gross
2019-08-04 22:49 ` [PATCH v2 21/34] fs/exec.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 22/34] orangefs: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 23/34] uprobes: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 24/34] futex: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 25/34] mm/frame_vector.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 26/34] mm/gup_benchmark.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 27/34] mm/memory.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 28/34] mm/madvise.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 29/34] mm/process_vm_access.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 30/34] crypt: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 31/34] fs/nfs: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-05  0:26   ` Calum Mackay
2019-08-05  0:26     ` [Xen-devel] " Calum Mackay
2019-08-05  0:26     ` Calum Mackay
2019-08-05  0:26     ` Calum Mackay
2019-08-05  0:26     ` Calum Mackay
2019-08-05  0:26     ` Calum Mackay
2019-08-04 22:49 ` [PATCH v2 32/34] goldfish_pipe: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 33/34] kernel/events/core.c: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49 ` [PATCH v2 34/34] fs/binfmt_elf: " john.hubbard
2019-08-04 22:49   ` [Xen-devel] " john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-04 22:49   ` john.hubbard
2019-08-09 12:42 ` ✗ Fi.CI.CHECKPATCH: warning for put_user_pages(): miscellaneous call sites Patchwork
2019-08-09 13:14 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-10  5:41 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190804224915.28669-12-jhubbard@nvidia.com \
    --to=john.hubbard@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arnd@arndb.de \
    --cc=ashutosh.dixit@intel.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@fromorbit.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devel@lists.orangefs.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@infradead.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=robin.murphy@arm.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=sudeep.dutt@intel.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.