From: Jin Nan Wang <jnwang@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
Jin Nan Wang <jnwang@suse.com>, Jan Beulich <JBeulich@suse.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH v1] x86/spec-ctrl: Remove EAGER_FPU when PV/HVM is disabled.
Date: Mon, 5 Aug 2019 08:54:08 +0000 [thread overview]
Message-ID: <20190805085350.23309-1-jnwang@suse.com> (raw)
In commit ac3f9a72141a48d40fabfff561d5a7dc0e1b810d:
For one, "no-xen" should not imply "no-eager-fpu", as "eager FPU" mode
is to guard guests, not Xen itself, which is also expressed so by
print_details().
So when spec-ctrl=pv=off,hvm=off; EAGER_FPU shouldn't be display in lines:
Current[Wrong]:
(XEN) Support for HVM VMs: EAGER_FPU MD_CLEAR
(XEN) Support for PV VMs: EAGER_FPU MD_CLEAR
expectation:
(XEN) Support for HVM VMs: MD_CLEAR
(XEN) Support for PV VMs: MD_CLEAR
---
xen/arch/x86/spec_ctrl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 468a847598..5f519406fb 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -128,12 +128,14 @@ static int __init parse_spec_ctrl(const char *s)
opt_msr_sc_pv = val;
opt_rsb_pv = val;
opt_md_clear_pv = val;
+ opt_eager_fpu = val;
}
else if ( (val = parse_boolean("hvm", s, ss)) >= 0 )
{
opt_msr_sc_hvm = val;
opt_rsb_hvm = val;
opt_md_clear_hvm = val;
+ opt_eager_fpu = val;
}
else if ( (val = parse_boolean("msr-sc", s, ss)) >= 0 )
{
--
2.22.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-08-05 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 8:54 Jin Nan Wang [this message]
2019-08-05 9:04 ` [Xen-devel] [PATCH v1] x86/spec-ctrl: Remove EAGER_FPU when PV/HVM is disabled Andrew Cooper
2019-08-05 9:05 ` Jin Nan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805085350.23309-1-jnwang@suse.com \
--to=jnwang@suse.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.