From: Jason Gunthorpe <jgg@ziepe.ca> To: linux-mm@kvack.org Cc: "Andrea Arcangeli" <aarcange@redhat.com>, "Christoph Hellwig" <hch@lst.de>, "John Hubbard" <jhubbard@nvidia.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Ralph Campbell" <rcampbell@nvidia.com>, "Kuehling, Felix" <Felix.Kuehling@amd.com>, "Alex Deucher" <alexander.deucher@amd.com>, "Christian König" <christian.koenig@amd.com>, "David (ChunMing) Zhou" <David1.Zhou@amd.com>, "Dimitri Sivanich" <sivanich@sgi.com>, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux-foundation.org, intel-gfx@lists.freedesktop.org, "Gavin Shan" <shangw@linux.vnet.ibm.com>, "Andrea Righi" <andrea@betterlinux.com>, "Jason Gunthorpe" <jgg@mellanox.com> Subject: [PATCH v3 hmm 07/11] RDMA/odp: remove ib_ucontext from ib_umem Date: Tue, 6 Aug 2019 20:15:44 -0300 [thread overview] Message-ID: <20190806231548.25242-8-jgg@ziepe.ca> (raw) In-Reply-To: <20190806231548.25242-1-jgg@ziepe.ca> From: Jason Gunthorpe <jgg@mellanox.com> At this point the ucontext is only being stored to access the ib_device, so just store the ib_device directly instead. This is more natural and logical as the umem has nothing to do with the ucontext. Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> --- drivers/infiniband/core/umem.c | 4 ++-- drivers/infiniband/core/umem_odp.c | 13 ++++++------- include/rdma/ib_umem.h | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index c59aa57d36510f..5ab9165ffbef0a 100644 --- a/drivers/infiniband/core/umem.c +++ b/drivers/infiniband/core/umem.c @@ -242,7 +242,7 @@ struct ib_umem *ib_umem_get(struct ib_udata *udata, unsigned long addr, return ERR_PTR(-ENOMEM); } - umem->context = context; + umem->ibdev = context->device; umem->length = size; umem->address = addr; umem->writable = ib_access_writable(access); @@ -370,7 +370,7 @@ void ib_umem_release(struct ib_umem *umem) return; } - __ib_umem_release(umem->context->device, umem, 1); + __ib_umem_release(umem->ibdev, umem, 1); atomic64_sub(ib_umem_num_pages(umem), &umem->owning_mm->pinned_vm); __ib_umem_release_tail(umem); diff --git a/drivers/infiniband/core/umem_odp.c b/drivers/infiniband/core/umem_odp.c index a02e6e3d7b72fb..da72318e17592f 100644 --- a/drivers/infiniband/core/umem_odp.c +++ b/drivers/infiniband/core/umem_odp.c @@ -103,7 +103,7 @@ static void ib_umem_notifier_release(struct mmu_notifier *mn, */ smp_wmb(); complete_all(&umem_odp->notifier_completion); - umem_odp->umem.context->device->ops.invalidate_range( + umem_odp->umem.ibdev->ops.invalidate_range( umem_odp, ib_umem_start(umem_odp), ib_umem_end(umem_odp)); } @@ -116,7 +116,7 @@ static int invalidate_range_start_trampoline(struct ib_umem_odp *item, u64 start, u64 end, void *cookie) { ib_umem_notifier_start_account(item); - item->umem.context->device->ops.invalidate_range(item, start, end); + item->umem.ibdev->ops.invalidate_range(item, start, end); return 0; } @@ -319,7 +319,7 @@ struct ib_umem_odp *ib_umem_odp_alloc_implicit(struct ib_udata *udata, if (!umem_odp) return ERR_PTR(-ENOMEM); umem = &umem_odp->umem; - umem->context = context; + umem->ibdev = context->device; umem->writable = ib_access_writable(access); umem->owning_mm = current->mm; umem_odp->is_implicit_odp = 1; @@ -364,7 +364,7 @@ struct ib_umem_odp *ib_umem_odp_alloc_child(struct ib_umem_odp *root, if (!odp_data) return ERR_PTR(-ENOMEM); umem = &odp_data->umem; - umem->context = root->umem.context; + umem->ibdev = root->umem.ibdev; umem->length = size; umem->address = addr; umem->writable = root->umem.writable; @@ -477,8 +477,7 @@ static int ib_umem_odp_map_dma_single_page( u64 access_mask, unsigned long current_seq) { - struct ib_ucontext *context = umem_odp->umem.context; - struct ib_device *dev = context->device; + struct ib_device *dev = umem_odp->umem.ibdev; dma_addr_t dma_addr; int remove_existing_mapping = 0; int ret = 0; @@ -691,7 +690,7 @@ void ib_umem_odp_unmap_dma_pages(struct ib_umem_odp *umem_odp, u64 virt, { int idx; u64 addr; - struct ib_device *dev = umem_odp->umem.context->device; + struct ib_device *dev = umem_odp->umem.ibdev; virt = max_t(u64, virt, ib_umem_start(umem_odp)); bound = min_t(u64, bound, ib_umem_end(umem_odp)); diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h index 1052d0d62be7d2..a91b2af64ec47b 100644 --- a/include/rdma/ib_umem.h +++ b/include/rdma/ib_umem.h @@ -42,7 +42,7 @@ struct ib_ucontext; struct ib_umem_odp; struct ib_umem { - struct ib_ucontext *context; + struct ib_device *ibdev; struct mm_struct *owning_mm; size_t length; unsigned long address; -- 2.22.0
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca> To: linux-mm@kvack.org Cc: "Andrea Arcangeli" <aarcange@redhat.com>, "David (ChunMing) Zhou" <David1.Zhou@amd.com>, "Ralph Campbell" <rcampbell@nvidia.com>, "Dimitri Sivanich" <sivanich@sgi.com>, "Gavin Shan" <shangw@linux.vnet.ibm.com>, "Andrea Righi" <andrea@betterlinux.com>, linux-rdma@vger.kernel.org, "John Hubbard" <jhubbard@nvidia.com>, "Kuehling, Felix" <Felix.Kuehling@amd.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Christian König" <christian.koenig@amd.com>, "Jérôme Glisse" <jglisse@redhat.com>, iommu@lists.linux-foundation.org, amd-gfx@lists.freedesktop.org, "Jason Gunthorpe" <jgg@mellanox.com>, "Alex Deucher" <alexander.deucher@amd.com>, intel-gfx@lists.freedesktop.org, "Christoph Hellwig" <hch@lst.de> Subject: [PATCH v3 hmm 07/11] RDMA/odp: remove ib_ucontext from ib_umem Date: Tue, 6 Aug 2019 20:15:44 -0300 [thread overview] Message-ID: <20190806231548.25242-8-jgg@ziepe.ca> (raw) In-Reply-To: <20190806231548.25242-1-jgg@ziepe.ca> From: Jason Gunthorpe <jgg@mellanox.com> At this point the ucontext is only being stored to access the ib_device, so just store the ib_device directly instead. This is more natural and logical as the umem has nothing to do with the ucontext. Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> --- drivers/infiniband/core/umem.c | 4 ++-- drivers/infiniband/core/umem_odp.c | 13 ++++++------- include/rdma/ib_umem.h | 2 +- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index c59aa57d36510f..5ab9165ffbef0a 100644 --- a/drivers/infiniband/core/umem.c +++ b/drivers/infiniband/core/umem.c @@ -242,7 +242,7 @@ struct ib_umem *ib_umem_get(struct ib_udata *udata, unsigned long addr, return ERR_PTR(-ENOMEM); } - umem->context = context; + umem->ibdev = context->device; umem->length = size; umem->address = addr; umem->writable = ib_access_writable(access); @@ -370,7 +370,7 @@ void ib_umem_release(struct ib_umem *umem) return; } - __ib_umem_release(umem->context->device, umem, 1); + __ib_umem_release(umem->ibdev, umem, 1); atomic64_sub(ib_umem_num_pages(umem), &umem->owning_mm->pinned_vm); __ib_umem_release_tail(umem); diff --git a/drivers/infiniband/core/umem_odp.c b/drivers/infiniband/core/umem_odp.c index a02e6e3d7b72fb..da72318e17592f 100644 --- a/drivers/infiniband/core/umem_odp.c +++ b/drivers/infiniband/core/umem_odp.c @@ -103,7 +103,7 @@ static void ib_umem_notifier_release(struct mmu_notifier *mn, */ smp_wmb(); complete_all(&umem_odp->notifier_completion); - umem_odp->umem.context->device->ops.invalidate_range( + umem_odp->umem.ibdev->ops.invalidate_range( umem_odp, ib_umem_start(umem_odp), ib_umem_end(umem_odp)); } @@ -116,7 +116,7 @@ static int invalidate_range_start_trampoline(struct ib_umem_odp *item, u64 start, u64 end, void *cookie) { ib_umem_notifier_start_account(item); - item->umem.context->device->ops.invalidate_range(item, start, end); + item->umem.ibdev->ops.invalidate_range(item, start, end); return 0; } @@ -319,7 +319,7 @@ struct ib_umem_odp *ib_umem_odp_alloc_implicit(struct ib_udata *udata, if (!umem_odp) return ERR_PTR(-ENOMEM); umem = &umem_odp->umem; - umem->context = context; + umem->ibdev = context->device; umem->writable = ib_access_writable(access); umem->owning_mm = current->mm; umem_odp->is_implicit_odp = 1; @@ -364,7 +364,7 @@ struct ib_umem_odp *ib_umem_odp_alloc_child(struct ib_umem_odp *root, if (!odp_data) return ERR_PTR(-ENOMEM); umem = &odp_data->umem; - umem->context = root->umem.context; + umem->ibdev = root->umem.ibdev; umem->length = size; umem->address = addr; umem->writable = root->umem.writable; @@ -477,8 +477,7 @@ static int ib_umem_odp_map_dma_single_page( u64 access_mask, unsigned long current_seq) { - struct ib_ucontext *context = umem_odp->umem.context; - struct ib_device *dev = context->device; + struct ib_device *dev = umem_odp->umem.ibdev; dma_addr_t dma_addr; int remove_existing_mapping = 0; int ret = 0; @@ -691,7 +690,7 @@ void ib_umem_odp_unmap_dma_pages(struct ib_umem_odp *umem_odp, u64 virt, { int idx; u64 addr; - struct ib_device *dev = umem_odp->umem.context->device; + struct ib_device *dev = umem_odp->umem.ibdev; virt = max_t(u64, virt, ib_umem_start(umem_odp)); bound = min_t(u64, bound, ib_umem_end(umem_odp)); diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h index 1052d0d62be7d2..a91b2af64ec47b 100644 --- a/include/rdma/ib_umem.h +++ b/include/rdma/ib_umem.h @@ -42,7 +42,7 @@ struct ib_ucontext; struct ib_umem_odp; struct ib_umem { - struct ib_ucontext *context; + struct ib_device *ibdev; struct mm_struct *owning_mm; size_t length; unsigned long address; -- 2.22.0 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-08-06 23:16 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-06 23:15 [PATCH v3 hmm 00/11] Add mmu_notifier_get/put for managing mmu notifier registrations Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 01/11] mm/mmu_notifiers: hoist do_mmu_notifier_register down_write to the caller Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-08 10:24 ` Christoph Hellwig 2019-08-08 10:24 ` Christoph Hellwig 2019-08-08 10:24 ` Christoph Hellwig 2019-08-14 20:14 ` Ralph Campbell 2019-08-14 20:14 ` Ralph Campbell 2019-08-14 20:14 ` Ralph Campbell 2019-08-06 23:15 ` [PATCH v3 hmm 02/11] mm/mmu_notifiers: do not speculatively allocate a mmu_notifier_mm Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-08 10:26 ` Christoph Hellwig 2019-08-08 10:26 ` Christoph Hellwig 2019-08-08 10:26 ` Christoph Hellwig 2019-08-14 20:32 ` Ralph Campbell 2019-08-14 20:32 ` Ralph Campbell 2019-08-14 20:32 ` Ralph Campbell 2019-08-06 23:15 ` [PATCH v3 hmm 03/11] mm/mmu_notifiers: add a get/put scheme for the registration Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-14 21:20 ` Ralph Campbell 2019-08-14 21:20 ` Ralph Campbell 2019-08-14 21:20 ` Ralph Campbell 2019-08-15 0:13 ` Jason Gunthorpe 2019-08-15 0:13 ` Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 04/11] misc/sgi-gru: use mmu_notifier_get/put for struct gru_mm_struct Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-08 10:25 ` Christoph Hellwig 2019-08-08 10:25 ` Christoph Hellwig 2019-08-08 10:25 ` Christoph Hellwig 2019-08-14 15:58 ` Jason Gunthorpe 2019-08-14 15:58 ` Jason Gunthorpe 2019-08-14 15:58 ` Jason Gunthorpe 2019-08-14 17:18 ` Dimitri Sivanich 2019-08-14 17:18 ` Dimitri Sivanich 2019-08-14 17:18 ` Dimitri Sivanich 2019-08-15 19:34 ` Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 05/11] hmm: use mmu_notifier_get/put for 'struct hmm' Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-08 10:28 ` Christoph Hellwig 2019-08-08 10:28 ` Christoph Hellwig 2019-08-14 21:51 ` Ralph Campbell 2019-08-14 21:51 ` Ralph Campbell 2019-08-14 21:51 ` Ralph Campbell 2019-08-06 23:15 ` [PATCH v3 hmm 06/11] RDMA/odp: use mmu_notifier_get/put for 'struct ib_ucontext_per_mm' Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe [this message] 2019-08-06 23:15 ` [PATCH v3 hmm 07/11] RDMA/odp: remove ib_ucontext from ib_umem Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 08/11] drm/radeon: use mmu_notifier_get/put for struct radeon_mn Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-14 16:07 ` Jason Gunthorpe 2019-08-14 16:07 ` Jason Gunthorpe 2019-08-15 8:28 ` Christian König 2019-08-15 8:28 ` Christian König 2019-08-15 19:46 ` Jason Gunthorpe 2019-08-15 19:46 ` Jason Gunthorpe 2019-08-15 19:46 ` Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 09/11] drm/amdkfd: fix a use after free race with mmu_notifer unregister Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 10/11] drm/amdkfd: use mmu_notifier_put Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-06 23:47 ` Kuehling, Felix 2019-08-06 23:47 ` Kuehling, Felix 2019-08-06 23:47 ` Kuehling, Felix 2019-08-07 11:42 ` Jason Gunthorpe 2019-08-07 11:42 ` Jason Gunthorpe 2019-08-07 11:42 ` Jason Gunthorpe 2019-08-06 23:15 ` [PATCH v3 hmm 11/11] mm/mmu_notifiers: remove unregister_no_release Jason Gunthorpe 2019-08-06 23:15 ` Jason Gunthorpe 2019-08-08 10:29 ` Christoph Hellwig 2019-08-08 10:29 ` Christoph Hellwig 2019-08-14 21:53 ` Ralph Campbell 2019-08-14 21:53 ` Ralph Campbell 2019-08-14 21:53 ` Ralph Campbell 2019-08-14 23:56 ` [PATCH v3 hmm 00/11] Add mmu_notifier_get/put for managing mmu notifier registrations Ralph Campbell 2019-08-14 23:56 ` Ralph Campbell 2019-08-14 23:56 ` Ralph Campbell 2019-08-15 20:34 ` Jason Gunthorpe 2019-08-16 15:14 ` Jason Gunthorpe 2019-08-16 15:14 ` Jason Gunthorpe 2019-08-21 19:53 ` Jason Gunthorpe 2019-08-21 19:53 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190806231548.25242-8-jgg@ziepe.ca \ --to=jgg@ziepe.ca \ --cc=David1.Zhou@amd.com \ --cc=Felix.Kuehling@amd.com \ --cc=aarcange@redhat.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=andrea@betterlinux.com \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hch@lst.de \ --cc=intel-gfx@lists.freedesktop.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jgg@mellanox.com \ --cc=jglisse@redhat.com \ --cc=jhubbard@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-rdma@vger.kernel.org \ --cc=rcampbell@nvidia.com \ --cc=shangw@linux.vnet.ibm.com \ --cc=sivanich@sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.