From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, jgg@ziepe.ca,
Jason Wang <jasowang@redhat.com>
Subject: [PATCH V3 09/10] vhost: correctly set dirty pages in MMU notifiers callback
Date: Wed, 7 Aug 2019 02:54:48 -0400 [thread overview]
Message-ID: <20190807065449.23373-10-jasowang@redhat.com> (raw)
In-Reply-To: <20190807065449.23373-1-jasowang@redhat.com>
We need make sure there's no reference on the map before trying to
mark set dirty pages.
Reported-by: Michael S. Tsirkin <mst@redhat.com>
Fixes: 7f466032dc9e ("vhost: access vq metadata through kernel virtual address")
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/vhost/vhost.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 57bfbb60d960..6650a3ff88c1 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -410,14 +410,13 @@ static void vhost_invalidate_vq_start(struct vhost_virtqueue *vq,
++vq->invalidate_count;
map = vq->maps[index];
- if (map) {
- vhost_set_map_dirty(vq, map, index);
+ if (map)
vq->maps[index] = NULL;
- }
spin_unlock(&vq->mmu_lock);
if (map) {
vhost_vq_sync_access(vq);
+ vhost_set_map_dirty(vq, map, index);
vhost_map_unprefetch(map);
}
}
--
2.18.1
next prev parent reply other threads:[~2019-08-07 6:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 6:54 [PATCH V3 00/10] Fixes for metadata accelreation Jason Wang
2019-08-07 6:54 ` [PATCH V3 01/10] vhost: disable metadata prefetch optimization Jason Wang
2019-08-07 7:05 ` Jason Wang
2019-08-07 7:05 ` Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 02/10] vhost: don't set uaddr for invalid address Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 03/10] vhost: validate MMU notifier registration Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 04/10] vhost: fix vhost map leak Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 05/10] vhost: reset invalidate_count in vhost_set_vring_num_addr() Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 06/10] vhost: mark dirty pages during map uninit Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 07/10] vhost: don't do synchronize_rcu() in vhost_uninit_vq_maps() Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 08/10] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-08-07 6:54 ` Jason Wang
2019-08-07 6:54 ` [PATCH V3 09/10] vhost: correctly set dirty pages in MMU notifiers callback Jason Wang
2019-08-07 6:54 ` Jason Wang [this message]
2019-08-07 6:54 ` [PATCH V3 10/10] vhost: do not return -EAGAIN for non blocking invalidation too early Jason Wang
2019-08-07 6:54 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807065449.23373-10-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.