From: nishkadg.linux@gmail.com (Nishka Dasgupta)
Subject: [PATCH 06/10] staging: rtl8712: init_default_value(): Change return type
Date: Thu, 8 Aug 2019 12:10:08 +0530 [thread overview]
Message-ID: <20190808064012.12661-6-nishkadg.linux@gmail.com> (raw)
In-Reply-To: <20190808064012.12661-1-nishkadg.linux@gmail.com>
Change return type of init_default_value from u8 to void as it always
returns _SUCCESS. Remove now-unnecessary return statement.
Modify call site to simply call the function.
Signed-off-by: Nishka Dasgupta <nishkadg.linux at gmail.com>
---
drivers/staging/rtl8712/os_intfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index b4059ea17e5c..c98acf4f6fff 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -258,7 +258,7 @@ void r8712_stop_drv_timers(struct _adapter *padapter)
del_timer_sync(&padapter->mlmepriv.sitesurveyctrl.sitesurvey_ctrl_timer);
}
-static u8 init_default_value(struct _adapter *padapter)
+static void init_default_value(struct _adapter *padapter)
{
struct registry_priv *pregistrypriv = &padapter->registrypriv;
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
@@ -292,7 +292,6 @@ static u8 init_default_value(struct _adapter *padapter)
r8712_init_registrypriv_dev_network(padapter);
r8712_update_registrypriv_dev_network(padapter);
/*misc.*/
- return _SUCCESS;
}
u8 r8712_init_drv_sw(struct _adapter *padapter)
@@ -316,8 +315,7 @@ u8 r8712_init_drv_sw(struct _adapter *padapter)
r8712_init_bcmc_stainfo(padapter);
r8712_init_pwrctrl_priv(padapter);
mp871xinit(padapter);
- if (init_default_value(padapter) != _SUCCESS)
- return _FAIL;
+ init_default_value(padapter);
r8712_InitSwLeds(padapter);
return _SUCCESS;
}
--
2.19.1
next prev parent reply other threads:[~2019-08-08 6:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 6:40 [PATCH 01/10] staging: rtl8712: amsdu_to_msdu(): Change return type Nishka Dasgupta
2019-08-08 6:40 ` [PATCH 02/10] staging: rtl8712: recv_indicatepkt_reorder(): Change return values Nishka Dasgupta
2019-08-08 6:40 ` [PATCH 03/10] staging: rtl8712: r8712_wlanhdr_to_ethhdr(): " Nishka Dasgupta
2019-08-08 6:40 ` [PATCH 04/10] staging: rtl8712: r8712_recv_entry(): Change return type Nishka Dasgupta
2019-08-08 6:40 ` [PATCH 05/10] staging: rtl8712: recvbuf2recvframe(): " Nishka Dasgupta
2019-08-08 6:40 ` Nishka Dasgupta [this message]
2019-08-08 6:40 ` [PATCH 07/10] staging: rtl8712: init_drv_sw(): Change return values Nishka Dasgupta
2019-08-08 12:16 ` Dan Carpenter
2019-08-08 6:40 ` [PATCH 08/10] staging: rtl8712: r8712_free_drv_sw(): Change return type Nishka Dasgupta
2019-08-08 6:40 ` [PATCH 09/10] staging: rtl8712: Remove while loop and check_cmd_fifo() Nishka Dasgupta
2019-08-08 6:40 ` [PATCH 10/10] staging: rtl8712: r8712_xmit_classifier(): Change return values and type Nishka Dasgupta
2019-08-08 12:17 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808064012.12661-6-nishkadg.linux@gmail.com \
--to=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.