From: Christoph Hellwig <hch@lst.de> To: Palmer Dabbelt <palmer@sifive.com>, Paul Walmsley <paul.walmsley@sifive.com> Cc: Damien Le Moal <damien.lemoal@wdc.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Atish Patra <atish.patra@wdc.com> Subject: [PATCH 05/15] riscv: improve the default power off implementation Date: Tue, 13 Aug 2019 17:47:37 +0200 [thread overview] Message-ID: <20190813154747.24256-6-hch@lst.de> (raw) In-Reply-To: <20190813154747.24256-1-hch@lst.de> Only call the SBI code if we are not running in M mode, and if we didn't do the SBI call, or it didn't succeed call wfi in a loop to at least save some power. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Atish Patra <atish.patra@wdc.com> --- arch/riscv/kernel/reset.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index d0fe623bfb8f..2f5ca379747e 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -8,8 +8,11 @@ static void default_power_off(void) { +#ifndef CONFIG_M_MODE sbi_shutdown(); - while (1); +#endif + while (1) + wait_for_interrupt(); } void (*pm_power_off)(void) = default_power_off; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Palmer Dabbelt <palmer@sifive.com>, Paul Walmsley <paul.walmsley@sifive.com> Cc: Atish Patra <atish.patra@wdc.com>, Damien Le Moal <damien.lemoal@wdc.com>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/15] riscv: improve the default power off implementation Date: Tue, 13 Aug 2019 17:47:37 +0200 [thread overview] Message-ID: <20190813154747.24256-6-hch@lst.de> (raw) In-Reply-To: <20190813154747.24256-1-hch@lst.de> Only call the SBI code if we are not running in M mode, and if we didn't do the SBI call, or it didn't succeed call wfi in a loop to at least save some power. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Atish Patra <atish.patra@wdc.com> --- arch/riscv/kernel/reset.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index d0fe623bfb8f..2f5ca379747e 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -8,8 +8,11 @@ static void default_power_off(void) { +#ifndef CONFIG_M_MODE sbi_shutdown(); - while (1); +#endif + while (1) + wait_for_interrupt(); } void (*pm_power_off)(void) = default_power_off; -- 2.20.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-13 15:48 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-13 15:47 RISC-V nommu support v3 Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 01/15] irqchip/sifive-plic: set max threshold for ignored handlers Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 17:44 ` Paul Walmsley 2019-08-13 17:44 ` Paul Walmsley 2019-08-14 9:06 ` Marc Zyngier 2019-08-14 9:06 ` Marc Zyngier 2019-08-13 15:47 ` [PATCH 02/15] riscv: use CSR_SATP instead of the legacy sptbr name in switch_mm Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 16:36 ` Paul Walmsley 2019-08-13 16:36 ` Paul Walmsley 2019-08-13 16:42 ` Christoph Hellwig 2019-08-13 16:42 ` Christoph Hellwig 2019-08-13 16:51 ` Paul Walmsley 2019-08-13 16:51 ` Paul Walmsley 2019-08-13 19:44 ` Paul Walmsley 2019-08-13 19:44 ` Paul Walmsley 2019-08-13 15:47 ` [PATCH 03/15] riscv: refactor the IPI code Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-14 4:41 ` Paul Walmsley 2019-08-14 4:41 ` Paul Walmsley 2019-08-19 10:18 ` Christoph Hellwig 2019-08-19 10:18 ` Christoph Hellwig 2019-09-01 8:03 ` Christoph Hellwig 2019-09-01 8:03 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 04/15] riscv: abstract out CSR names for supervisor vs machine mode Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig [this message] 2019-08-13 15:47 ` [PATCH 05/15] riscv: improve the default power off implementation Christoph Hellwig 2019-08-13 15:47 ` [PATCH 06/15] riscv: provide a flat entry loader Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 07/15] riscv: read the hart ID from mhartid on boot Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 08/15] riscv: provide native clint access for M-mode Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 16:29 ` Mark Rutland 2019-08-13 16:29 ` Mark Rutland 2019-08-19 10:16 ` Christoph Hellwig 2019-08-19 10:16 ` Christoph Hellwig 2019-08-27 23:37 ` Palmer Dabbelt 2019-08-27 23:37 ` Palmer Dabbelt 2019-08-28 6:11 ` Christoph Hellwig 2019-08-28 6:11 ` Christoph Hellwig 2019-09-03 18:48 ` Palmer Dabbelt 2019-09-03 18:48 ` Palmer Dabbelt 2019-09-04 2:05 ` Alan Kao 2019-09-04 2:05 ` Alan Kao 2019-08-21 0:24 ` Atish Patra 2019-08-21 0:24 ` Atish Patra 2019-08-21 0:42 ` hch 2019-08-21 0:42 ` hch 2019-08-13 15:47 ` [PATCH 09/15] riscv: implement remote sfence.i natively " Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-20 21:04 ` Atish Patra 2019-08-20 21:04 ` Atish Patra 2019-08-13 15:47 ` [PATCH 10/15] riscv: poison SBI calls " Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-20 21:05 ` Atish Patra 2019-08-20 21:05 ` Atish Patra 2019-08-13 15:47 ` [PATCH 11/15] riscv: don't allow selecting SBI-based drivers " Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 12/15] riscv: use the correct interrupt levels " Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 13/15] riscv: clear the instruction cache and all registers when booting Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-14 1:00 ` Alan Kao 2019-08-14 1:00 ` Alan Kao 2019-08-14 1:07 ` Alan Kao 2019-08-14 1:07 ` Alan Kao 2019-08-14 4:35 ` Christoph Hellwig 2019-08-14 4:35 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 14/15] riscv: add nommu support Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-13 15:47 ` [PATCH 15/15] riscv: disable the EFI PECOFF header for M-mode Christoph Hellwig 2019-08-13 15:47 ` Christoph Hellwig 2019-08-20 21:07 ` Atish Patra 2019-08-20 21:07 ` Atish Patra 2019-08-21 4:14 ` Troy Benjegerdes 2019-08-21 4:14 ` Troy Benjegerdes 2019-08-21 7:12 ` Christoph Hellwig 2019-08-21 7:12 ` Christoph Hellwig 2019-08-21 17:31 ` Atish Patra 2019-08-21 17:31 ` Atish Patra 2019-08-21 17:54 ` Troy Benjegerdes 2019-08-21 17:54 ` Troy Benjegerdes 2019-08-21 23:02 ` Anup Patel 2019-08-21 23:02 ` Anup Patel 2019-08-21 23:32 ` Troy Benjegerdes 2019-08-21 23:32 ` Troy Benjegerdes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190813154747.24256-6-hch@lst.de \ --to=hch@lst.de \ --cc=atish.patra@wdc.com \ --cc=damien.lemoal@wdc.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@sifive.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.