From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-fsdevel@vger.kernel.org Cc: linux-mtd@lists.infradead.org, Jan Kara <jack@suse.com>, Richard Weinberger <richard@nod.at>, kernel@pengutronix.de, Sascha Hauer <s.hauer@pengutronix.de> Subject: [PATCH 00/11] Add quota support to UBIFS Date: Wed, 14 Aug 2019 14:18:23 +0200 [thread overview] Message-ID: <20190814121834.13983-1-s.hauer@pengutronix.de> (raw) This series adds quota support to UBIFS. This series follows a very simple approach to quota: Neither the quota limits nor the quota usage are ever written to the medium. The quota usage is reconstructed from the filesystem during mount time. The quota limits must be set by the user each time after mount. This is probably not very convenient for systems that are used interactively, but UBIFS is targetted to embedded systems and here running a script after mount shouldn't be a problem. This of course isn't the way quota was thought to be, but I believe this is a good compromise for a feature that I predict is only rarely used on UBIFS. The big upside of this approach is that no on-disk format changes are required and thus we can't get any broken/corrupt filesystems because of quota support. Reconstructing the quota data each time during mount has an noticable but I think for many cases acceptable time overhead. I mounted a ~56MiB rootfs with 1920 files which takes around 0.7s longer when quota is enabled. As UBIFS works on mtd there is no block_device involved. The quotactl system call requires a path to a block device as argument. To overcome this we add support for passing the mount point instead. quota uses get_super_exclusive_thawed(), get_super_thawed() and get_super() to get hold of a super_block. All these functions require a block_device which we do not have for UBIFS, so this code has to be refactored a bit. I'm a bit outside of my comfort zone here, so please review carefully ;) The UBIFS quota support itself is based on a series by Dongsheng Yang posted here: http://lists.infradead.org/pipermail/linux-mtd/2015-September/061812.html This part hasn't changed much, except that the code for reading and writing quota files has been dropped. Sascha Dongsheng Yang (1): ubifs: Add quota support Sascha Hauer (10): quota: Make inode optional quota: Only module_put the format when existing fs: move __get_super() out of loop fs, quota: introduce wait_super_thawed() to wait until a superblock is thawed quota: Allow to pass quotactl a mountpoint ubifs: move checks and preparation into setflags() ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls ubifs: do not ubifs_inode() on potentially NULL pointer ubifs: Add support for project id ubifs: export get_znode fs/quota/dquot.c | 9 +- fs/quota/quota.c | 79 ++++-- fs/super.c | 74 +++--- fs/ubifs/Makefile | 1 + fs/ubifs/dir.c | 31 ++- fs/ubifs/file.c | 43 +++ fs/ubifs/ioctl.c | 222 ++++++++++++++-- fs/ubifs/journal.c | 4 +- fs/ubifs/quota.c | 590 +++++++++++++++++++++++++++++++++++++++++ fs/ubifs/super.c | 46 +++- fs/ubifs/tnc.c | 34 +-- fs/ubifs/ubifs-media.h | 6 +- fs/ubifs/ubifs.h | 33 +++ include/linux/fs.h | 5 +- 14 files changed, 1076 insertions(+), 101 deletions(-) create mode 100644 fs/ubifs/quota.c -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-fsdevel@vger.kernel.org Cc: Richard Weinberger <richard@nod.at>, Sascha Hauer <s.hauer@pengutronix.de>, linux-mtd@lists.infradead.org, kernel@pengutronix.de, Jan Kara <jack@suse.com> Subject: [PATCH 00/11] Add quota support to UBIFS Date: Wed, 14 Aug 2019 14:18:23 +0200 [thread overview] Message-ID: <20190814121834.13983-1-s.hauer@pengutronix.de> (raw) This series adds quota support to UBIFS. This series follows a very simple approach to quota: Neither the quota limits nor the quota usage are ever written to the medium. The quota usage is reconstructed from the filesystem during mount time. The quota limits must be set by the user each time after mount. This is probably not very convenient for systems that are used interactively, but UBIFS is targetted to embedded systems and here running a script after mount shouldn't be a problem. This of course isn't the way quota was thought to be, but I believe this is a good compromise for a feature that I predict is only rarely used on UBIFS. The big upside of this approach is that no on-disk format changes are required and thus we can't get any broken/corrupt filesystems because of quota support. Reconstructing the quota data each time during mount has an noticable but I think for many cases acceptable time overhead. I mounted a ~56MiB rootfs with 1920 files which takes around 0.7s longer when quota is enabled. As UBIFS works on mtd there is no block_device involved. The quotactl system call requires a path to a block device as argument. To overcome this we add support for passing the mount point instead. quota uses get_super_exclusive_thawed(), get_super_thawed() and get_super() to get hold of a super_block. All these functions require a block_device which we do not have for UBIFS, so this code has to be refactored a bit. I'm a bit outside of my comfort zone here, so please review carefully ;) The UBIFS quota support itself is based on a series by Dongsheng Yang posted here: http://lists.infradead.org/pipermail/linux-mtd/2015-September/061812.html This part hasn't changed much, except that the code for reading and writing quota files has been dropped. Sascha Dongsheng Yang (1): ubifs: Add quota support Sascha Hauer (10): quota: Make inode optional quota: Only module_put the format when existing fs: move __get_super() out of loop fs, quota: introduce wait_super_thawed() to wait until a superblock is thawed quota: Allow to pass quotactl a mountpoint ubifs: move checks and preparation into setflags() ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls ubifs: do not ubifs_inode() on potentially NULL pointer ubifs: Add support for project id ubifs: export get_znode fs/quota/dquot.c | 9 +- fs/quota/quota.c | 79 ++++-- fs/super.c | 74 +++--- fs/ubifs/Makefile | 1 + fs/ubifs/dir.c | 31 ++- fs/ubifs/file.c | 43 +++ fs/ubifs/ioctl.c | 222 ++++++++++++++-- fs/ubifs/journal.c | 4 +- fs/ubifs/quota.c | 590 +++++++++++++++++++++++++++++++++++++++++ fs/ubifs/super.c | 46 +++- fs/ubifs/tnc.c | 34 +-- fs/ubifs/ubifs-media.h | 6 +- fs/ubifs/ubifs.h | 33 +++ include/linux/fs.h | 5 +- 14 files changed, 1076 insertions(+), 101 deletions(-) create mode 100644 fs/ubifs/quota.c -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2019-08-14 12:19 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-14 12:18 Sascha Hauer [this message] 2019-08-14 12:18 ` [PATCH 00/11] Add quota support to UBIFS Sascha Hauer 2019-08-14 12:18 ` [PATCH 01/11] quota: Make inode optional Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 02/11] quota: Only module_put the format when existing Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-15 11:18 ` Jan Kara 2019-08-15 11:18 ` Jan Kara 2019-08-16 11:49 ` Sascha Hauer 2019-08-16 11:49 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 03/11] fs: move __get_super() out of loop Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 23:32 ` Al Viro 2019-08-14 23:32 ` Al Viro 2019-08-14 12:18 ` [PATCH 04/11] fs, quota: introduce wait_super_thawed() to wait until a superblock is thawed Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 23:35 ` Al Viro 2019-08-14 23:35 ` Al Viro 2019-08-14 12:18 ` [PATCH 05/11] quota: Allow to pass quotactl a mountpoint Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 22:42 ` kbuild test robot 2019-08-14 22:42 ` kbuild test robot 2019-08-14 23:33 ` kbuild test robot 2019-08-14 23:33 ` kbuild test robot 2019-08-14 23:36 ` Al Viro 2019-08-14 23:36 ` Al Viro 2019-08-14 23:39 ` Al Viro 2019-08-14 23:39 ` Al Viro 2019-08-14 23:51 ` Al Viro 2019-08-14 23:51 ` Al Viro 2019-08-15 9:53 ` Jan Kara 2019-08-15 9:53 ` Jan Kara 2019-08-15 7:46 ` Sascha Hauer 2019-08-15 7:46 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 06/11] ubifs: move checks and preparation into setflags() Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 07/11] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 14:11 ` Mainz, Roland 2019-08-14 14:11 ` Mainz, Roland 2019-08-15 7:31 ` Sascha Hauer 2019-08-15 7:31 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 08/11] ubifs: do not ubifs_inode() on potentially NULL pointer Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 09/11] ubifs: Add support for project id Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 10/11] ubifs: export get_znode Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-14 12:18 ` [PATCH 11/11] ubifs: Add quota support Sascha Hauer 2019-08-14 12:18 ` Sascha Hauer 2019-08-15 11:17 ` Jan Kara 2019-08-15 11:17 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190814121834.13983-1-s.hauer@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=jack@suse.com \ --cc=kernel@pengutronix.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.