All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
	linux-media@vger.kernel.org (open list:MEDIA INPUT
	INFRASTRUCTURE (V4L/DVB)),
	linux-kernel@vger.kernel.org (open list)
Subject: [RFC 5/5] media: i2c: ov13858: Report the camera location
Date: Wed, 14 Aug 2019 22:28:15 +0200	[thread overview]
Message-ID: <20190814202815.32491-6-jacopo@jmondi.org> (raw)
In-Reply-To: <20190814202815.32491-1-jacopo@jmondi.org>

The camera location is retrieved from the firmware interface parsing
the "location" device property and reported through the read-only
V4L2_CID_LOCATION control.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/media/i2c/ov13858.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index 45bb872db3c5..6baefc3083e1 100644
--- a/drivers/media/i2c/ov13858.c
+++ b/drivers/media/i2c/ov13858.c
@@ -1591,6 +1591,7 @@ static int ov13858_init_controls(struct ov13858 *ov13858)
 	struct i2c_client *client = v4l2_get_subdevdata(&ov13858->sd);
 	struct v4l2_ctrl_handler *ctrl_hdlr;
 	s64 exposure_max;
+	u32 location;
 	s64 vblank_def;
 	s64 vblank_min;
 	s64 hblank;
@@ -1659,6 +1660,16 @@ static int ov13858_init_controls(struct ov13858 *ov13858)
 				     V4L2_CID_TEST_PATTERN,
 				     ARRAY_SIZE(ov13858_test_pattern_menu) - 1,
 				     0, 0, ov13858_test_pattern_menu);
+
+	ret = device_property_read_u32(&client->dev, "location", &location);
+	if (!ret) {
+		v4l2_ctrl_new_std(ctrl_hdlr, &ov13858_ctrl_ops,
+				  V4L2_CID_LOCATION, V4L2_LOCATION_FRONT,
+				  V4L2_LOCATION_BACK, 1,
+				  location == V4L2_LOCATION_FRONT ?
+				  V4L2_LOCATION_FRONT : V4L2_LOCATION_BACK);
+	}
+
 	if (ctrl_hdlr->error) {
 		ret = ctrl_hdlr->error;
 		dev_err(&client->dev, "%s control init failed (%d)\n",
-- 
2.22.0


      parent reply	other threads:[~2019-08-14 20:27 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 20:28 [RFC 0/5] media: v4l2-ctrls: Add camera 'location' support Jacopo Mondi
2019-08-14 20:28 ` [RFC 1/5] media: dt-bindings: Document 'location' property Jacopo Mondi
2019-08-14 20:28   ` Jacopo Mondi
2019-08-14 22:40   ` Laurent Pinchart
2019-08-14 22:40     ` Laurent Pinchart
2019-08-15  6:56   ` Sakari Ailus
2019-08-15  6:56     ` Sakari Ailus
2019-08-15 12:55     ` Laurent Pinchart
2019-08-15 12:55       ` Laurent Pinchart
2019-08-15 12:55     ` Jacopo Mondi
2019-08-15 12:55       ` Jacopo Mondi
2019-08-15 12:58       ` Laurent Pinchart
2019-08-15 12:58         ` Laurent Pinchart
2019-09-01 17:24     ` Pavel Machek
2019-09-01 17:24       ` Pavel Machek
2019-09-02  8:02       ` Laurent Pinchart
2019-09-02  8:02         ` Laurent Pinchart
2019-09-02  8:11         ` Pavel Machek
2019-09-02  8:11           ` Pavel Machek
2019-08-14 20:28 ` [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION Jacopo Mondi
2019-08-14 22:43   ` Laurent Pinchart
2019-08-15 12:58     ` Jacopo Mondi
2019-08-15 14:10     ` Hans Verkuil
2019-08-15 14:14       ` Hans Verkuil
2019-08-15 14:34         ` Jacopo Mondi
2019-08-15 14:40           ` Hans Verkuil
2019-08-15 15:12             ` Sakari Ailus
2019-09-01 17:24             ` Pavel Machek
2019-09-02  8:00               ` Laurent Pinchart
2019-09-02  8:06                 ` Pavel Machek
2019-09-02  8:19                   ` Laurent Pinchart
2019-09-02  8:27                     ` Pavel Machek
2019-09-02  8:53                       ` Laurent Pinchart
2019-09-02  9:41               ` Jacopo Mondi
2019-08-15  7:00   ` Sakari Ailus
2019-08-15 12:59     ` Laurent Pinchart
2019-08-15 13:08       ` Sakari Ailus
2019-08-15 13:10         ` Laurent Pinchart
2019-08-15 13:15           ` Sakari Ailus
2019-08-15 13:19             ` Laurent Pinchart
2019-08-15 13:30   ` Hans Verkuil
2019-08-15 13:48     ` Laurent Pinchart
2019-08-15 14:02     ` Jacopo Mondi
2019-08-14 20:28 ` [RFC 3/5] media: v4l2-ctrls: Add support for V4L2_CID_LOCATION Jacopo Mondi
2019-08-14 22:53   ` Laurent Pinchart
2019-08-15 13:02     ` Jacopo Mondi
2019-08-15 13:03       ` Laurent Pinchart
2019-08-15 13:41       ` Hans Verkuil
2019-08-15 13:50         ` Jacopo Mondi
2019-08-15 14:12           ` Hans Verkuil
2019-08-15 13:23   ` Hans Verkuil
2019-08-15 13:50     ` Jacopo Mondi
2019-08-14 20:28 ` [RFC 4/5] media: i2c: ov5670: Report the camera location Jacopo Mondi
2019-08-14 23:03   ` Laurent Pinchart
2019-08-15  7:04   ` Sakari Ailus
2019-08-14 20:28 ` Jacopo Mondi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190814202815.32491-6-jacopo@jmondi.org \
    --to=jacopo@jmondi.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.