All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: linux-block@vger.kernel.org
Cc: hch@lst.de, axboe@kernel.dk,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: [PATCH V3 3/6] null_blk: create a helper for badblocks
Date: Tue, 20 Aug 2019 23:13:11 -0700	[thread overview]
Message-ID: <20190821061314.3262-4-chaitanya.kulkarni@wdc.com> (raw)
In-Reply-To: <20190821061314.3262-1-chaitanya.kulkarni@wdc.com>

This patch creates a helper for handling badblocks code in the
null_handle_cmd().

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
 drivers/block/null_blk_main.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
index 751679fadc9d..eefaea1aaa45 100644
--- a/drivers/block/null_blk_main.c
+++ b/drivers/block/null_blk_main.c
@@ -1154,6 +1154,20 @@ static inline blk_status_t null_handle_throttled(struct nullb_cmd *cmd)
 	return sts;
 }
 
+static inline blk_status_t null_handle_badblocks(struct nullb_cmd *cmd,
+						 sector_t sector,
+						 sector_t nr_sectors)
+{
+	struct badblocks *bb = &cmd->nq->dev->badblocks;
+	sector_t first_bad;
+	int bad_sectors;
+
+	if (badblocks_check(bb, sector, nr_sectors, &first_bad, &bad_sectors))
+		return BLK_STS_IOERR;
+
+	return BLK_STS_OK;
+}
+
 static blk_status_t null_handle_cmd(struct nullb_cmd *cmd, sector_t sector,
 				    sector_t nr_sectors, enum req_opf op)
 {
@@ -1172,15 +1186,11 @@ static blk_status_t null_handle_cmd(struct nullb_cmd *cmd, sector_t sector,
 		cmd->error = errno_to_blk_status(null_handle_flush(nullb));
 		goto out;
 	}
-	if (nullb->dev->badblocks.shift != -1) {
-		int bad_sectors;
-		sector_t first_bad;
 
-		if (badblocks_check(&nullb->dev->badblocks, sector, nr_sectors,
-				&first_bad, &bad_sectors)) {
-			cmd->error = BLK_STS_IOERR;
+	if (nullb->dev->badblocks.shift != -1) {
+		cmd->error = null_handle_badblocks(cmd, sector, nr_sectors);
+		if (cmd->error != BLK_STS_OK)
 			goto out;
-		}
 	}
 
 	if (dev->memory_backed) {
-- 
2.17.0


  parent reply	other threads:[~2019-08-21  6:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21  6:13 [PATCH V3 0/6] null_blk: simplify null_handle_cmd() Chaitanya Kulkarni
2019-08-21  6:13 ` [PATCH V3 1/6] null_blk: move duplicate code to callers Chaitanya Kulkarni
2019-08-22  0:55   ` Christoph Hellwig
2019-08-21  6:13 ` [PATCH V3 2/6] null_blk: create a helper for throttling Chaitanya Kulkarni
2019-08-22  0:55   ` Christoph Hellwig
2019-08-21  6:13 ` Chaitanya Kulkarni [this message]
2019-08-22  0:55   ` [PATCH V3 3/6] null_blk: create a helper for badblocks Christoph Hellwig
2019-08-21  6:13 ` [PATCH V3 4/6] null_blk: create a helper for mem-backed ops Chaitanya Kulkarni
2019-08-22  0:56   ` Christoph Hellwig
2019-08-21  6:13 ` [PATCH V3 5/6] null_blk: create a helper for zoned devices Chaitanya Kulkarni
2019-08-22  0:58   ` Christoph Hellwig
2019-08-22  2:23     ` Chaitanya Kulkarni
2019-08-21  6:13 ` [PATCH V3 6/6] null_blk: create a helper for req completion Chaitanya Kulkarni
2019-08-22  0:59   ` Christoph Hellwig
2019-08-22  2:17     ` Chaitanya Kulkarni
2019-08-22  2:23       ` Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821061314.3262-4-chaitanya.kulkarni@wdc.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.