From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, daniel.vetter@ffwll.ch, sumit.semwal@linaro.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 03/10] dma-buf: add dma_fence_array_recycle Date: Wed, 21 Aug 2019 14:31:40 +0200 [thread overview] Message-ID: <20190821123147.110736-4-christian.koenig@amd.com> (raw) In-Reply-To: <20190821123147.110736-1-christian.koenig@amd.com> Try to recycle an dma_fence_array object by dropping the last reference to it without freeing it. Signed-off-by: Christian König <christian.koenig@amd.com> --- drivers/dma-buf/dma-fence-array.c | 27 +++++++++++++++++++++++++++ include/linux/dma-fence-array.h | 1 + 2 files changed, 28 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c index e82f30551aa1..314cf0e881d9 100644 --- a/drivers/dma-buf/dma-fence-array.c +++ b/drivers/dma-buf/dma-fence-array.c @@ -188,6 +188,33 @@ void dma_fence_array_init(struct dma_fence_array *array, u64 context, } EXPORT_SYMBOL(dma_fence_array_init); +/** + * dma_fence_array_reuse - dummy for dma_fence_array_recycle + */ +static void dma_fence_array_reuse(struct kref *kref) +{ + struct dma_fence_array *array = container_of(kref, typeof(*array), + base.refcount); + + WARN_ON_ONCE(!list_empty(&array->base.cb_list)); +} + +/** + * dma_fence_array_try_reuse - try to reuse a dma_fence_array object + * @array: array which we should try to reuse + * + * Try to drop the last reference to an dma_fence_array and so allow it to be + * reused. + * + * Returns true if this was the last reference then caller can reuse the array. + * In this case the array is reset into a state where it can be used with + * dma_fence_array_init again. + */ +bool dma_fence_array_recycle(struct dma_fence_array *array) +{ + return kref_put(&array->base.refcount, dma_fence_array_reuse); +} + /** * dma_fence_array_free - free a dma_fence_array object * @array: the object to free diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h index be85c06b524d..35d1d1e7c93b 100644 --- a/include/linux/dma-fence-array.h +++ b/include/linux/dma-fence-array.h @@ -93,6 +93,7 @@ struct dma_fence_array *dma_fence_array_alloc(int num_fences, struct dma_fence **fences); void dma_fence_array_init(struct dma_fence_array *array, u64 context, unsigned int seqno, bool signal_on_any); +bool dma_fence_array_recycle(struct dma_fence_array *array); void dma_fence_array_free(struct dma_fence_array *array); /** -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com> To: dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, daniel.vetter@ffwll.ch, sumit.semwal@linaro.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 03/10] dma-buf: add dma_fence_array_recycle Date: Wed, 21 Aug 2019 14:31:40 +0200 [thread overview] Message-ID: <20190821123147.110736-4-christian.koenig@amd.com> (raw) In-Reply-To: <20190821123147.110736-1-christian.koenig@amd.com> Try to recycle an dma_fence_array object by dropping the last reference to it without freeing it. Signed-off-by: Christian König <christian.koenig@amd.com> --- drivers/dma-buf/dma-fence-array.c | 27 +++++++++++++++++++++++++++ include/linux/dma-fence-array.h | 1 + 2 files changed, 28 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c index e82f30551aa1..314cf0e881d9 100644 --- a/drivers/dma-buf/dma-fence-array.c +++ b/drivers/dma-buf/dma-fence-array.c @@ -188,6 +188,33 @@ void dma_fence_array_init(struct dma_fence_array *array, u64 context, } EXPORT_SYMBOL(dma_fence_array_init); +/** + * dma_fence_array_reuse - dummy for dma_fence_array_recycle + */ +static void dma_fence_array_reuse(struct kref *kref) +{ + struct dma_fence_array *array = container_of(kref, typeof(*array), + base.refcount); + + WARN_ON_ONCE(!list_empty(&array->base.cb_list)); +} + +/** + * dma_fence_array_try_reuse - try to reuse a dma_fence_array object + * @array: array which we should try to reuse + * + * Try to drop the last reference to an dma_fence_array and so allow it to be + * reused. + * + * Returns true if this was the last reference then caller can reuse the array. + * In this case the array is reset into a state where it can be used with + * dma_fence_array_init again. + */ +bool dma_fence_array_recycle(struct dma_fence_array *array) +{ + return kref_put(&array->base.refcount, dma_fence_array_reuse); +} + /** * dma_fence_array_free - free a dma_fence_array object * @array: the object to free diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h index be85c06b524d..35d1d1e7c93b 100644 --- a/include/linux/dma-fence-array.h +++ b/include/linux/dma-fence-array.h @@ -93,6 +93,7 @@ struct dma_fence_array *dma_fence_array_alloc(int num_fences, struct dma_fence **fences); void dma_fence_array_init(struct dma_fence_array *array, u64 context, unsigned int seqno, bool signal_on_any); +bool dma_fence_array_recycle(struct dma_fence_array *array); void dma_fence_array_free(struct dma_fence_array *array); /** -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-21 12:31 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-21 12:31 [RFC] replacing dma_resv API Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 12:31 ` [PATCH 01/10] dma-buf: make to_dma_fence_array NULL safe Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 12:31 ` [PATCH 02/10] dma-buf: add dma_fence_array_alloc/free Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 12:31 ` Christian König [this message] 2019-08-21 12:31 ` [PATCH 03/10] dma-buf: add dma_fence_array_recycle Christian König 2019-08-21 16:24 ` Chris Wilson 2019-08-21 16:24 ` Chris Wilson 2019-08-22 8:38 ` Christian König 2019-08-22 8:38 ` Christian König 2019-08-21 12:31 ` [PATCH 04/10] dma-buf: add dma_fence_array_for_each Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 12:31 ` [PATCH 05/10] dma-buf/resv: add dma_resv_prune_fences Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 14:55 ` Chris Wilson 2019-08-21 14:55 ` Chris Wilson 2019-08-21 14:56 ` Chris Wilson 2019-08-21 14:56 ` Chris Wilson 2019-08-21 12:31 ` [PATCH 06/10] dma-buf/resv: stop pruning shared fences when exclusive is added Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 12:31 ` [PATCH 07/10] dma-buf/resv: add new fences container implementation Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 16:04 ` Daniel Vetter 2019-08-21 16:04 ` Daniel Vetter 2019-08-22 8:23 ` Christian König 2019-08-22 8:23 ` Christian König 2019-08-22 13:02 ` Daniel Vetter 2019-08-22 13:02 ` Daniel Vetter 2019-08-22 13:53 ` Koenig, Christian 2019-08-22 13:53 ` Koenig, Christian 2019-08-21 12:31 ` [PATCH 08/10] dma-buf/resv: replace shared fence with new fences container Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 15:24 ` Chris Wilson 2019-08-21 15:24 ` Chris Wilson 2019-08-21 17:35 ` Chris Wilson 2019-08-21 17:35 ` Chris Wilson 2019-08-22 8:37 ` Christian König 2019-08-22 8:37 ` Christian König 2019-08-22 9:16 ` Christian König 2019-08-22 9:16 ` Christian König 2019-08-21 16:21 ` Chris Wilson 2019-08-21 16:21 ` Chris Wilson 2019-08-24 13:22 ` Chris Wilson 2019-08-24 13:22 ` Chris Wilson 2019-08-21 12:31 ` [PATCH 09/10] dma-buf/resv: replace exclusive " Christian König 2019-08-21 12:31 ` Christian König 2019-08-21 12:31 ` [PATCH 10/10] dma-buf/resv: add other operations Christian König 2019-08-21 12:31 ` Christian König 2019-08-22 12:28 ` Ville Syrjälä 2019-08-22 12:28 ` Ville Syrjälä 2019-08-21 16:13 ` [RFC] replacing dma_resv API Daniel Vetter 2019-08-21 16:13 ` Daniel Vetter 2019-08-21 20:05 ` Daniel Vetter 2019-08-21 20:05 ` Daniel Vetter 2019-08-22 9:27 ` Christian König 2019-08-22 9:27 ` Christian König 2019-08-21 20:11 ` Chris Wilson 2019-08-21 20:11 ` Chris Wilson 2019-08-21 20:22 ` Daniel Vetter 2019-08-21 20:22 ` Daniel Vetter 2019-08-22 9:14 ` Christian König 2019-08-22 9:14 ` Christian König 2019-08-22 10:00 ` Daniel Vetter 2019-08-22 10:00 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190821123147.110736-4-christian.koenig@amd.com \ --to=ckoenig.leichtzumerken@gmail.com \ --cc=chris@chris-wilson.co.uk \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linaro-mm-sig@lists.linaro.org \ --cc=linux-media@vger.kernel.org \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.