All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Takeshi Kihara <takeshi.kihara.df@renesas.com>
Cc: Michael Dege <michael.dege@renesas.com>,
	<Andrew_Gabbasov@mentor.com>, <george_davis@mentor.com>,
	<tfranzen@de.adit-jv.com>, Eugeniu Rosca <erosca@de.adit-jv.com>,
	Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: [RFC DO-NOT-MERGE PATCH] arm64: dts: renesas: R8A77961: Add Renesas M3-W+ (M3 ES3.0) SoC support
Date: Wed, 21 Aug 2019 14:44:41 +0200	[thread overview]
Message-ID: <20190821124441.22319-1-erosca@de.adit-jv.com> (raw)

Similar to the revision update from H3-ES1.x to H3-ES2.0, the update
from M3-ES1.x to M3-ES3.0, in addition to fixing HW bugs/erratas, drops
entire silicon IPs [1-2] (for cost efficiency and other reasons).

However, unlike in the H3 ES1.x->ES2.0 revision update, the M3-ES3.0
came with a new SoC id, i.e. r8a77961 (according to both [2] and
the updated SoC HW manual Rev.2.00 Jul 2019). The choice to allocate a
new identifier seems to strengthen the HW differences between M3-ES1.x
and M3-ES3.0 (as it is the case for M3N/r8a77965).

Given the above, there are several ways to differentiate between
M3-ES1.x and M3-ES3.0:

A. The BSP way [1]. Move/rename r8a7796.dtsi to r8a7796-es1.dtsi and
keep using r8a7796.dtsi for M3-ES3.x.

Pros:
 * Resembles commit 291e0c4994d081 ("arm64: dts: r8a7795: Add support
   for R-Car H3 ES2.0")
 * Reuses the r8a7796 (e.g. sysc, cpg-mssr) drivers for r8a77961 (i.e.
   minimizes the bring-up effort)
Cons:
 * Deliberately diverges from the vendor documentation [2] by
   ignoring the new SoC identifier r8a77961, i.e. leading to
   inconsistencies in the names of the drivers and DTS

B. The approach taken in this patch, i.e. create a brand new
  r8a77961.dtsi (similar to r8a77965.dtsi).

Pros:
 * Reflects the reality documented by HW designers [2]
 * Maintains drivers/DTS naming consistency and avoids mismatch between
   documentation and code
Cons:
 * higher bring-up effort than (A)
 * more discussion is needed on whether it makes sense to separate:
   - DTS only
   - DTS + Kconfig (ARCH_R8A77961)
   - DTS + Kconfig (ARCH_R8A77961) + drivers (sysc, cpg-mssr, other?)

Comments appreciated!

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
 arch/arm64/boot/dts/renesas/r8a77961.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a77961.dtsi

diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
new file mode 100644
index 000000000000..7f784619be32
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the R-Car M3-W+ (R8A77961) ES3.x SoC
+ *
+ * Copyright (C) 2019 Renesas Electronics Corp.
+ */
+
+#include "r8a7796.dtsi"
+
+/*
+ * Here comes the delta between M3-W (M3 ES1.x) and M3-W+ (M3 ES3.0)
+ * described in:
+ * [1] https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?id=8ba438fd03d5
+ *     ("arm64: dts: r8a7796: Add support for R-Car M3 ES3.0")
+ * [2] [Confidential] Engineering Change Notice for R8A77961
+ */
-- 
2.23.0


             reply	other threads:[~2019-08-21 12:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 12:44 Eugeniu Rosca [this message]
2019-08-23 14:18 ` [RFC DO-NOT-MERGE PATCH] arm64: dts: renesas: R8A77961: Add Renesas M3-W+ (M3 ES3.0) SoC support Geert Uytterhoeven
2019-08-28 17:09   ` Eugeniu Rosca
2019-09-27  8:13     ` Geert Uytterhoeven
2019-09-27  8:35       ` Eugeniu Rosca
2019-08-31  8:01   ` Simon Horman
2019-09-27  8:39     ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821124441.22319-1-erosca@de.adit-jv.com \
    --to=erosca@de.adit-jv.com \
    --cc=Andrew_Gabbasov@mentor.com \
    --cc=geert@linux-m68k.org \
    --cc=george_davis@mentor.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=michael.dege@renesas.com \
    --cc=roscaeugeniu@gmail.com \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=tfranzen@de.adit-jv.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.