From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: krzk@kernel.org Cc: jonathanh@nvidia.com, kgene@kernel.org, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, Sylwester Nawrocki <s.nawrocki@samsung.com> Subject: [PATCH] soc: samsung: chipid: Remove the regmap lookup error log Date: Wed, 21 Aug 2019 17:05:39 +0200 [thread overview] Message-ID: <20190821150539.31207-1-s.nawrocki@samsung.com> (raw) In-Reply-To: CGME20190821150548eucas1p15139f733b00e3a1a107efe39f6712fe9@eucas1p1.samsung.com In commit 40d8aff614f7 ("soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API") of_find_compatible_node() call was substituted with syscon_regmap_lookup_by_compatible() but also an error log was added for case where lookup fails. On multiplatform the lookup will always fail on any non-samsung device so the log is incorrect. Remove the error log and just return an error code from syscon_regmap_lookup_by_compatible() which internally calls of_find_compatible_node(). Reported-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/soc/samsung/exynos-chipid.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index 75b6b880d9ef..c55a47cfe617 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -56,10 +56,8 @@ int __init exynos_chipid_early_init(void) int ret; regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); - if (IS_ERR(regmap)) { - pr_err("Failed to get CHIPID regmap\n"); + if (IS_ERR(regmap)) return PTR_ERR(regmap); - } ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id); if (ret < 0) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com> To: krzk@kernel.org Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, pankaj.dubey@samsung.com, linux-kernel@vger.kernel.org, jonathanh@nvidia.com, kgene@kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Subject: [PATCH] soc: samsung: chipid: Remove the regmap lookup error log Date: Wed, 21 Aug 2019 17:05:39 +0200 [thread overview] Message-ID: <20190821150539.31207-1-s.nawrocki@samsung.com> (raw) In-Reply-To: CGME20190821150548eucas1p15139f733b00e3a1a107efe39f6712fe9@eucas1p1.samsung.com In commit 40d8aff614f7 ("soc: samsung: chipid: Convert exynos-chipid driver to use the regmap API") of_find_compatible_node() call was substituted with syscon_regmap_lookup_by_compatible() but also an error log was added for case where lookup fails. On multiplatform the lookup will always fail on any non-samsung device so the log is incorrect. Remove the error log and just return an error code from syscon_regmap_lookup_by_compatible() which internally calls of_find_compatible_node(). Reported-by: Jon Hunter <jonathanh@nvidia.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/soc/samsung/exynos-chipid.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index 75b6b880d9ef..c55a47cfe617 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -56,10 +56,8 @@ int __init exynos_chipid_early_init(void) int ret; regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid"); - if (IS_ERR(regmap)) { - pr_err("Failed to get CHIPID regmap\n"); + if (IS_ERR(regmap)) return PTR_ERR(regmap); - } ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id); if (ret < 0) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2019-08-21 15:05 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20190821150548eucas1p15139f733b00e3a1a107efe39f6712fe9@eucas1p1.samsung.com> 2019-08-21 15:05 ` Sylwester Nawrocki [this message] 2019-08-21 15:05 ` [PATCH] soc: samsung: chipid: Remove the regmap lookup error log Sylwester Nawrocki 2019-08-22 18:17 ` Krzysztof Kozlowski 2019-08-22 18:17 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190821150539.31207-1-s.nawrocki@samsung.com \ --to=s.nawrocki@samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=jonathanh@nvidia.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=pankaj.dubey@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.