From: Anders Roxell <anders.roxell@linaro.org> To: ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, matthias.bgg@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Anders Roxell <anders.roxell@linaro.org> Subject: [PATCH] drm/mediatek: fix implicit function declaration Date: Fri, 23 Aug 2019 13:07:36 +0200 [thread overview] Message-ID: <20190823110736.26117-1-anders.roxell@linaro.org> (raw) When building mtk_drm_drv.o the following build error is seen: ../drivers/gpu/drm/mediatek/mtk_drm_drv.c: In function ‘mtk_drm_kms_init’: ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function ‘dma_set_max_seg_size’; did you mean ‘drm_rect_adjust_size’? [-Werror=implicit-function-declaration] ret = dma_set_max_seg_size(dma_dev, (unsigned int)DMA_BIT_MASK(32)); ^~~~~~~~~~~~~~~~~~~~ drm_rect_adjust_size ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function ‘DMA_BIT_MASK’; did you mean ‘BIT_MASK’? [-Werror=implicit-function-declaration] ret = dma_set_max_seg_size(dma_dev, (unsigned int)DMA_BIT_MASK(32)); ^~~~~~~~~~~~ BIT_MASK Rework to add a missing include file 'linux/dma-mapping.h', because that is the (only) header file containing that declaration. Fixes: 070955558e82 ("drm/mediatek: set DMA max segment size") Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 54536176bcbb..352b81a7a670 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -10,6 +10,7 @@ #include <linux/of_address.h> #include <linux/of_platform.h> #include <linux/pm_runtime.h> +#include <linux/dma-mapping.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Anders Roxell <anders.roxell@linaro.org> To: ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, matthias.bgg@gmail.com Cc: Anders Roxell <anders.roxell@linaro.org>, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/mediatek: fix implicit function declaration Date: Fri, 23 Aug 2019 13:07:36 +0200 [thread overview] Message-ID: <20190823110736.26117-1-anders.roxell@linaro.org> (raw) When building mtk_drm_drv.o the following build error is seen: ../drivers/gpu/drm/mediatek/mtk_drm_drv.c: In function ‘mtk_drm_kms_init’: ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:8: error: implicit declaration of function ‘dma_set_max_seg_size’; did you mean ‘drm_rect_adjust_size’? [-Werror=implicit-function-declaration] ret = dma_set_max_seg_size(dma_dev, (unsigned int)DMA_BIT_MASK(32)); ^~~~~~~~~~~~~~~~~~~~ drm_rect_adjust_size ../drivers/gpu/drm/mediatek/mtk_drm_drv.c:291:52: error: implicit declaration of function ‘DMA_BIT_MASK’; did you mean ‘BIT_MASK’? [-Werror=implicit-function-declaration] ret = dma_set_max_seg_size(dma_dev, (unsigned int)DMA_BIT_MASK(32)); ^~~~~~~~~~~~ BIT_MASK Rework to add a missing include file 'linux/dma-mapping.h', because that is the (only) header file containing that declaration. Fixes: 070955558e82 ("drm/mediatek: set DMA max segment size") Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 54536176bcbb..352b81a7a670 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -10,6 +10,7 @@ #include <linux/of_address.h> #include <linux/of_platform.h> #include <linux/pm_runtime.h> +#include <linux/dma-mapping.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-08-23 11:07 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-23 11:07 Anders Roxell [this message] 2019-08-23 11:07 ` [PATCH] drm/mediatek: fix implicit function declaration Anders Roxell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190823110736.26117-1-anders.roxell@linaro.org \ --to=anders.roxell@linaro.org \ --cc=airlied@linux.ie \ --cc=ck.hu@mediatek.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=p.zabel@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.