From: Jiada Wang <jiada_wang@mentor.com> To: <nick@shmanahar.org>, <dmitry.torokhov@gmail.com> Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <jiada_wang@mentor.com>, <george_davis@mentor.com> Subject: [PATCH v2 41/49] Input: Atmel: improve error handling in mxt_update_cfg() Date: Tue, 27 Aug 2019 15:31:22 +0900 [thread overview] Message-ID: <20190827063130.20969-2-jiada_wang@mentor.com> (raw) In-Reply-To: <20190827063130.20969-1-jiada_wang@mentor.com> From: Deepak Das <deepak_das@mentor.com> mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das <deepak_das@mentor.com> Signed-off-by: George G. Davis <george_davis@mentor.com> Signed-off-by: Jiada Wang <jiada_wang@mentor.com> --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 59533753a431..716b91e6fd66 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2183,7 +2183,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.19.2
WARNING: multiple messages have this Message-ID (diff)
From: Jiada Wang <jiada_wang@mentor.com> To: nick@shmanahar.org, dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, jiada_wang@mentor.com, george_davis@mentor.com Subject: [PATCH v2 41/49] Input: Atmel: improve error handling in mxt_update_cfg() Date: Tue, 27 Aug 2019 15:31:22 +0900 [thread overview] Message-ID: <20190827063130.20969-2-jiada_wang@mentor.com> (raw) In-Reply-To: <20190827063130.20969-1-jiada_wang@mentor.com> From: Deepak Das <deepak_das@mentor.com> mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das <deepak_das@mentor.com> Signed-off-by: George G. Davis <george_davis@mentor.com> Signed-off-by: Jiada Wang <jiada_wang@mentor.com> --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 59533753a431..716b91e6fd66 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2183,7 +2183,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.19.2
next prev parent reply other threads:[~2019-08-27 6:31 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-27 6:31 [PATCH v2 40/49] Input: Atmel: improve error handling in mxt_initialize() Jiada Wang 2019-08-27 6:31 ` Jiada Wang 2019-08-27 6:31 ` Jiada Wang [this message] 2019-08-27 6:31 ` [PATCH v2 41/49] Input: Atmel: improve error handling in mxt_update_cfg() Jiada Wang 2019-08-27 6:31 ` [PATCH v2 42/49] Input: Atmel: Improve error handling in mxt_initialize_input_device() Jiada Wang 2019-08-27 6:31 ` Jiada Wang 2019-08-27 6:31 ` [PATCH v2 43/49] Input: Atmel: handle ReportID "0x00" while processing T5 messages Jiada Wang 2019-08-27 6:31 ` Jiada Wang 2019-08-27 6:31 ` [PATCH v2 44/49] Input: Atmel: use T44 object to process " Jiada Wang 2019-08-27 6:31 ` Jiada Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190827063130.20969-2-jiada_wang@mentor.com \ --to=jiada_wang@mentor.com \ --cc=dmitry.torokhov@gmail.com \ --cc=george_davis@mentor.com \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nick@shmanahar.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.