From: Christian Brauner <christian.brauner@ubuntu.com> To: hridya@google.com Cc: arve@android.com, christian@brauner.io, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, joel@joelfernandes.org, kernel-team@android.com, linux-kernel@vger.kernel.org, maco@android.com, tkjos@android.com, Christian Brauner <christian.brauner@ubuntu.com> Subject: [RESEND PATCH v3 2/2] binder: Validate the default binderfs device names. Date: Wed, 4 Sep 2019 13:07:04 +0200 [thread overview] Message-ID: <20190904110704.8606-3-christian.brauner@ubuntu.com> (raw) In-Reply-To: <20190904110704.8606-1-christian.brauner@ubuntu.com> From: Hridya Valsaraju <hridya@google.com> Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. This patch adds a check in binderfs_init() to ensure the same for the default binder devices that will be created in every binderfs instance. Co-developed-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Hridya Valsaraju <hridya@google.com> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> Link: https://lore.kernel.org/r/20190808222727.132744-3-hridya@google.com --- drivers/android/binderfs.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index aee46dd1be91..55c5adb87585 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -570,6 +570,18 @@ static struct file_system_type binder_fs_type = { int __init init_binderfs(void) { int ret; + const char *name; + size_t len; + + /* Verify that the default binderfs device names are valid. */ + name = binder_devices_param; + for (len = strcspn(name, ","); len > 0; len = strcspn(name, ",")) { + if (len > BINDERFS_MAX_NAME) + return -E2BIG; + name += len; + if (*name == ',') + name++; + } /* Allocate new major number for binderfs. */ ret = alloc_chrdev_region(&binderfs_dev, 0, BINDERFS_MAX_MINOR, -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <christian.brauner@ubuntu.com> To: hridya@google.com Cc: devel@driverdev.osuosl.org, tkjos@android.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, arve@android.com, maco@android.com, joel@joelfernandes.org, Christian Brauner <christian.brauner@ubuntu.com>, kernel-team@android.com, christian@brauner.io Subject: [RESEND PATCH v3 2/2] binder: Validate the default binderfs device names. Date: Wed, 4 Sep 2019 13:07:04 +0200 [thread overview] Message-ID: <20190904110704.8606-3-christian.brauner@ubuntu.com> (raw) In-Reply-To: <20190904110704.8606-1-christian.brauner@ubuntu.com> From: Hridya Valsaraju <hridya@google.com> Length of a binderfs device name cannot exceed BINDERFS_MAX_NAME. This patch adds a check in binderfs_init() to ensure the same for the default binder devices that will be created in every binderfs instance. Co-developed-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Hridya Valsaraju <hridya@google.com> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> Link: https://lore.kernel.org/r/20190808222727.132744-3-hridya@google.com --- drivers/android/binderfs.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c index aee46dd1be91..55c5adb87585 100644 --- a/drivers/android/binderfs.c +++ b/drivers/android/binderfs.c @@ -570,6 +570,18 @@ static struct file_system_type binder_fs_type = { int __init init_binderfs(void) { int ret; + const char *name; + size_t len; + + /* Verify that the default binderfs device names are valid. */ + name = binder_devices_param; + for (len = strcspn(name, ","); len > 0; len = strcspn(name, ",")) { + if (len > BINDERFS_MAX_NAME) + return -E2BIG; + name += len; + if (*name == ',') + name++; + } /* Allocate new major number for binderfs. */ ret = alloc_chrdev_region(&binderfs_dev, 0, BINDERFS_MAX_MINOR, -- 2.23.0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-04 11:07 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-08 22:27 [PATCH v3 0/2] Add default binderfs devices Hridya Valsaraju 2019-08-08 22:27 ` Hridya Valsaraju 2019-08-08 22:27 ` [PATCH v3 1/2] binder: Add default binder devices through binderfs when configured Hridya Valsaraju 2019-08-08 22:27 ` Hridya Valsaraju 2019-08-09 14:50 ` Greg Kroah-Hartman 2019-08-09 14:50 ` Greg Kroah-Hartman 2019-08-09 18:22 ` Christian Brauner 2019-08-09 18:22 ` Christian Brauner 2019-08-09 20:08 ` Hridya Valsaraju 2019-08-09 20:08 ` Hridya Valsaraju 2019-08-15 16:28 ` Joel Fernandes 2019-08-15 16:28 ` Joel Fernandes 2019-08-15 16:30 ` Joel Fernandes 2019-08-15 16:30 ` Joel Fernandes 2019-08-08 22:27 ` [PATCH v3 2/2] binder: Validate the default binderfs device names Hridya Valsaraju 2019-08-08 22:27 ` Hridya Valsaraju 2019-08-09 14:51 ` Greg Kroah-Hartman 2019-08-09 14:51 ` Greg Kroah-Hartman 2019-08-09 14:55 ` Greg Kroah-Hartman 2019-08-09 14:55 ` Greg Kroah-Hartman 2019-08-09 18:14 ` Christian Brauner 2019-08-09 18:14 ` Christian Brauner 2019-08-09 18:41 ` Hridya Valsaraju 2019-08-09 18:41 ` Hridya Valsaraju 2019-09-04 7:19 ` Greg Kroah-Hartman 2019-09-04 7:19 ` Greg Kroah-Hartman 2019-09-04 10:44 ` Christian Brauner 2019-09-04 10:44 ` Christian Brauner 2019-09-04 10:49 ` Greg Kroah-Hartman 2019-09-04 10:49 ` Greg Kroah-Hartman 2019-09-04 11:07 ` Christian Brauner 2019-09-04 11:07 ` Christian Brauner 2019-08-15 16:31 ` Joel Fernandes 2019-08-15 16:31 ` Joel Fernandes 2019-08-15 16:00 ` [PATCH v3 0/2] Add default binderfs devices Greg Kroah-Hartman 2019-08-15 16:00 ` Greg Kroah-Hartman 2019-09-04 11:07 ` [RESEND PATCH " Christian Brauner 2019-09-04 11:07 ` Christian Brauner 2019-09-04 11:07 ` [RESEND PATCH v3 1/2] binder: Add default binder devices through binderfs when configured Christian Brauner 2019-09-04 11:07 ` Christian Brauner 2019-09-04 11:07 ` Christian Brauner [this message] 2019-09-04 11:07 ` [RESEND PATCH v3 2/2] binder: Validate the default binderfs device names Christian Brauner 2019-09-04 11:18 ` [RESEND PATCH v3 0/2] Add default binderfs devices Greg KH 2019-09-04 11:18 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190904110704.8606-3-christian.brauner@ubuntu.com \ --to=christian.brauner@ubuntu.com \ --cc=arve@android.com \ --cc=christian@brauner.io \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=hridya@google.com \ --cc=joel@joelfernandes.org \ --cc=kernel-team@android.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maco@android.com \ --cc=tkjos@android.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.