All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: lee.jones@linaro.org, daniel.thompson@linaro.org,
	jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz,
	dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com,
	b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin
Date: Sun,  8 Sep 2019 22:37:03 +0200	[thread overview]
Message-ID: <20190908203704.30147-2-andreas@kemnade.info> (raw)
In-Reply-To: <20190908203704.30147-1-andreas@kemnade.info>

For now just enable it in the probe function to allow i2c
access and disable it on remove. Disabling also means resetting
the register values to default.

Tested on Kobo Clara HD.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/video/backlight/lm3630a_bl.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index b04b35d007a2..3b45a1733198 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -12,6 +12,8 @@
 #include <linux/uaccess.h>
 #include <linux/interrupt.h>
 #include <linux/regmap.h>
+#include <linux/gpio/consumer.h>
+#include <linux/gpio.h>
 #include <linux/pwm.h>
 #include <linux/platform_data/lm3630a_bl.h>
 
@@ -48,6 +50,7 @@ struct lm3630a_chip {
 	struct lm3630a_platform_data *pdata;
 	struct backlight_device *bleda;
 	struct backlight_device *bledb;
+	struct gpio_desc *enable_gpio;
 	struct regmap *regmap;
 	struct pwm_device *pwmd;
 };
@@ -506,6 +509,14 @@ static int lm3630a_probe(struct i2c_client *client,
 		return -ENOMEM;
 	pchip->dev = &client->dev;
 
+	pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
+						GPIOD_ASIS);
+	if (IS_ERR(pchip->enable_gpio)) {
+		rval = PTR_ERR(pchip->enable_gpio);
+		return rval;
+	}
+
+
 	pchip->regmap = devm_regmap_init_i2c(client, &lm3630a_regmap);
 	if (IS_ERR(pchip->regmap)) {
 		rval = PTR_ERR(pchip->regmap);
@@ -535,6 +546,10 @@ static int lm3630a_probe(struct i2c_client *client,
 	}
 	pchip->pdata = pdata;
 
+	if (pchip->enable_gpio) {
+		gpiod_set_value_cansleep(pchip->enable_gpio, 1);
+		usleep_range(1000, 2000);
+	}
 	/* chip initialize */
 	rval = lm3630a_chip_init(pchip);
 	if (rval < 0) {
@@ -586,6 +601,9 @@ static int lm3630a_remove(struct i2c_client *client)
 	if (rval < 0)
 		dev_err(pchip->dev, "i2c failed to access register\n");
 
+	if (pchip->enable_gpio)
+		gpiod_set_value_cansleep(pchip->enable_gpio, 0);
+
 	if (pchip->irq) {
 		free_irq(pchip->irq, pchip);
 		flush_workqueue(pchip->irqthread);
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Andreas Kemnade <andreas@kemnade.info>
To: lee.jones@linaro.org, daniel.thompson@linaro.org,
	jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz,
	dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com,
	b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin
Date: Sun, 08 Sep 2019 20:37:03 +0000	[thread overview]
Message-ID: <20190908203704.30147-2-andreas@kemnade.info> (raw)
In-Reply-To: <20190908203704.30147-1-andreas@kemnade.info>

For now just enable it in the probe function to allow i2c
access and disable it on remove. Disabling also means resetting
the register values to default.

Tested on Kobo Clara HD.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/video/backlight/lm3630a_bl.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index b04b35d007a2..3b45a1733198 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -12,6 +12,8 @@
 #include <linux/uaccess.h>
 #include <linux/interrupt.h>
 #include <linux/regmap.h>
+#include <linux/gpio/consumer.h>
+#include <linux/gpio.h>
 #include <linux/pwm.h>
 #include <linux/platform_data/lm3630a_bl.h>
 
@@ -48,6 +50,7 @@ struct lm3630a_chip {
 	struct lm3630a_platform_data *pdata;
 	struct backlight_device *bleda;
 	struct backlight_device *bledb;
+	struct gpio_desc *enable_gpio;
 	struct regmap *regmap;
 	struct pwm_device *pwmd;
 };
@@ -506,6 +509,14 @@ static int lm3630a_probe(struct i2c_client *client,
 		return -ENOMEM;
 	pchip->dev = &client->dev;
 
+	pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
+						GPIOD_ASIS);
+	if (IS_ERR(pchip->enable_gpio)) {
+		rval = PTR_ERR(pchip->enable_gpio);
+		return rval;
+	}
+
+
 	pchip->regmap = devm_regmap_init_i2c(client, &lm3630a_regmap);
 	if (IS_ERR(pchip->regmap)) {
 		rval = PTR_ERR(pchip->regmap);
@@ -535,6 +546,10 @@ static int lm3630a_probe(struct i2c_client *client,
 	}
 	pchip->pdata = pdata;
 
+	if (pchip->enable_gpio) {
+		gpiod_set_value_cansleep(pchip->enable_gpio, 1);
+		usleep_range(1000, 2000);
+	}
 	/* chip initialize */
 	rval = lm3630a_chip_init(pchip);
 	if (rval < 0) {
@@ -586,6 +601,9 @@ static int lm3630a_remove(struct i2c_client *client)
 	if (rval < 0)
 		dev_err(pchip->dev, "i2c failed to access register\n");
 
+	if (pchip->enable_gpio)
+		gpiod_set_value_cansleep(pchip->enable_gpio, 0);
+
 	if (pchip->irq) {
 		free_irq(pchip->irq, pchip);
 		flush_workqueue(pchip->irqthread);
-- 
2.20.1

  reply	other threads:[~2019-09-08 21:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-08 20:37 [PATCH 0/2] backlight_lm3630a: add enable_gpios property Andreas Kemnade
2019-09-08 20:37 ` Andreas Kemnade
2019-09-08 20:37 ` Andreas Kemnade [this message]
2019-09-08 20:37   ` [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin Andreas Kemnade
2019-09-09 10:57   ` Daniel Thompson
2019-09-09 10:57     ` Daniel Thompson
2019-09-09 20:13     ` Andreas Kemnade
2019-09-09 20:13       ` Andreas Kemnade
2019-09-10 10:21       ` Daniel Thompson
2019-09-10 10:21         ` Daniel Thompson
2019-09-10 19:06         ` Andreas Kemnade
2019-09-10 19:06           ` Andreas Kemnade
2019-09-15 16:52           ` Pavel Machek
2019-09-15 16:52             ` Pavel Machek
2019-09-15 17:34             ` Andreas Kemnade
2019-09-15 17:34               ` Andreas Kemnade
2019-09-08 20:37 ` [PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios Andreas Kemnade
2019-09-08 20:37   ` Andreas Kemnade
2019-09-09 10:59   ` Daniel Thompson
2019-09-09 10:59     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190908203704.30147-2-andreas@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hns@goldelico.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.