From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Subject: [PATCH] generic/566: use _require_xfs_quota_foreign to replace the hard -f option
Date: Tue, 10 Sep 2019 19:36:11 +0800 [thread overview]
Message-ID: <20190910113611.31247-1-zlang@redhat.com> (raw)
xfstests should decide if xfs_quota need the -f option by
_require_xfs_quota_foreign, not write the -f option after
$XFS_QUOTA_PROG manually. The later way will cause unexpected
error on an old system which xfsprogs doesn't support the -f option.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
tests/generic/566 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/generic/566 b/tests/generic/566
index e8491e54..fb239a00 100755
--- a/tests/generic/566
+++ b/tests/generic/566
@@ -34,6 +34,7 @@ _supported_os Linux
_supported_fs generic
_require_scratch
_require_quota
+_require_xfs_quota_foreign
_require_user
rm -f $seqres.full
@@ -45,7 +46,7 @@ _qmount
dir="$SCRATCH_MNT/dummy"
mkdir -p $dir
chown $qa_user $dir
-$XFS_QUOTA_PROG -x -f -c "limit -g bsoft=100k bhard=100k $qa_user" $SCRATCH_MNT
+$XFS_QUOTA_PROG -x -c "limit -g bsoft=100k bhard=100k $qa_user" $SCRATCH_MNT
$XFS_IO_PROG -f -c 'pwrite -S 0x58 0 1m' $dir/foo >> $seqres.full
chown $qa_user "${dir}/foo"
--
2.20.1
next reply other threads:[~2019-09-10 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 11:36 Zorro Lang [this message]
[not found] ` <2fc62795-d932-de07-a9ed-695893ead8f8@cn.fujitsu.com>
2019-09-11 2:42 ` [PATCH] generic/566: use _require_xfs_quota_foreign to replace the hard -f option Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910113611.31247-1-zlang@redhat.com \
--to=zlang@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.