All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Max Filippov" <jcmvbkbc@gmail.com>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [Qemu-devel] [PULL v2 04/15] linux-user: fail and report on bad dfilter specs
Date: Wed, 11 Sep 2019 08:49:09 +0200	[thread overview]
Message-ID: <20190911064920.1718-5-laurent@vivier.eu> (raw)
In-Reply-To: <20190911064920.1718-1-laurent@vivier.eu>

From: Alex Bennée <alex.bennee@linaro.org>

Just passing NULL means we end up ignoring the bad dfilter spec
instead of reporting it and exiting as we should.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20190830143648.2967-1-alex.bennee@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/main.c b/linux-user/main.c
index 28f0065b6ddf..c257b063dbc1 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -235,7 +235,7 @@ static void handle_arg_log(const char *arg)
 
 static void handle_arg_dfilter(const char *arg)
 {
-    qemu_set_dfilter_ranges(arg, NULL);
+    qemu_set_dfilter_ranges(arg, &error_fatal);
 }
 
 static void handle_arg_log_filename(const char *arg)
-- 
2.21.0



  parent reply	other threads:[~2019-09-11  6:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11  6:49 [Qemu-devel] [PULL v2 00/15] Linux user for 4.2 patches Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 01/15] linux-user: remove useless variable Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 02/15] linux-user: Add AT_HWCAP2 for aarch64-linux-user Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 03/15] linux-user: erroneous fd_trans_unregister call Laurent Vivier
2019-09-11  6:49 ` Laurent Vivier [this message]
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 05/15] linux-user: add memfd_create Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 06/15] linux-user: Pass CPUState to MAX_RESERVED_VA Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 07/15] linux-user/arm: Adjust MAX_RESERVED_VA for M-profile Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 08/15] linux-user: Support gdb 'qOffsets' query for ELF Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 09/15] target/xtensa: linux-user: add call0 ABI support Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 10/15] linux-user: drop redundant handling of environment variables Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 11/15] linux-user: Add support for RNDRESEEDCRNG ioctl Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 12/15] linux-user: Add support for FIOGETOWN and FIOSETOWN ioctls Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 13/15] linux-user: Add support for FDFLUSH ioctl Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 14/15] linux-user: Add support for FDMSGON and FDMSGOFF ioctls Laurent Vivier
2019-09-11  6:49 ` [Qemu-devel] [PULL v2 15/15] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls Laurent Vivier
2019-09-12 17:09 ` [Qemu-devel] [PULL v2 00/15] Linux user for 4.2 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190911064920.1718-5-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=alex.bennee@linaro.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.