All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Puschmann <philipp.puschmann@emlix.com>
To: linux-kernel@vger.kernel.org
Cc: vkoul@kernel.org, dan.j.williams@intel.com, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	gregkh@linuxfoundation.org, jslaby@suse.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org,
	Philipp Puschmann <philipp.puschmann@emlix.com>
Subject: [PATCH 0/4] Fix UART DMA freezes for iMX6
Date: Wed, 11 Sep 2019 16:49:39 +0200	[thread overview]
Message-ID: <20190911144943.21554-1-philipp.puschmann@emlix.com> (raw)

For some years and since many kernel versions there are reports that
RX UART DMA channel stops working at one point. So far the usual workaround was
to disable RX DMA. This patches try to fix the underlying problem.

When a running sdma script does not find any usable destination buffer to put
its data into it just leads to stopping the channel being scheduled again. As
solution we we manually retrigger the sdma script for this channel and by this
dissolve the freeze.

While this seems to work fine so far a further patch in this series increases
the number of RX DMA periods for UART to reduce use cases running into such
a situation.

This patch series was tested with the current kernel and backported to
kernel 4.15 with a special use case using a WL1837MOD via UART and provoking
the hanging of UART RX DMA within seconds after starting a test application.
It resulted in well known
  "Bluetooth: hci0: command 0x0408 tx timeout"
errors and complete stop of UART data reception. Our Bluetooth traffic consists
of many independent small packets, mostly only a few bytes, causing high usage
of periods.


Philipp Puschmann (4):
  dmaengine: imx-sdma: fix buffer ownership
  dmaengine: imx-sdma: fix dma freezes
  serial: imx: adapt rx buffer and dma periods
  dmaengine: imx-sdma: drop redundant variable

 drivers/dma/imx-sdma.c   | 32 ++++++++++++++++++++++----------
 drivers/tty/serial/imx.c |  5 ++---
 2 files changed, 24 insertions(+), 13 deletions(-)

-- 
2.23.0


WARNING: multiple messages have this Message-ID (diff)
From: Philipp Puschmann <philipp.puschmann@emlix.com>
To: linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, jslaby@suse.com, vkoul@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	gregkh@linuxfoundation.org, dmaengine@vger.kernel.org,
	dan.j.williams@intel.com, festevam@gmail.com,
	Philipp Puschmann <philipp.puschmann@emlix.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Fix UART DMA freezes for iMX6
Date: Wed, 11 Sep 2019 16:49:39 +0200	[thread overview]
Message-ID: <20190911144943.21554-1-philipp.puschmann@emlix.com> (raw)

For some years and since many kernel versions there are reports that
RX UART DMA channel stops working at one point. So far the usual workaround was
to disable RX DMA. This patches try to fix the underlying problem.

When a running sdma script does not find any usable destination buffer to put
its data into it just leads to stopping the channel being scheduled again. As
solution we we manually retrigger the sdma script for this channel and by this
dissolve the freeze.

While this seems to work fine so far a further patch in this series increases
the number of RX DMA periods for UART to reduce use cases running into such
a situation.

This patch series was tested with the current kernel and backported to
kernel 4.15 with a special use case using a WL1837MOD via UART and provoking
the hanging of UART RX DMA within seconds after starting a test application.
It resulted in well known
  "Bluetooth: hci0: command 0x0408 tx timeout"
errors and complete stop of UART data reception. Our Bluetooth traffic consists
of many independent small packets, mostly only a few bytes, causing high usage
of periods.


Philipp Puschmann (4):
  dmaengine: imx-sdma: fix buffer ownership
  dmaengine: imx-sdma: fix dma freezes
  serial: imx: adapt rx buffer and dma periods
  dmaengine: imx-sdma: drop redundant variable

 drivers/dma/imx-sdma.c   | 32 ++++++++++++++++++++++----------
 drivers/tty/serial/imx.c |  5 ++---
 2 files changed, 24 insertions(+), 13 deletions(-)

-- 
2.23.0

WARNING: multiple messages have this Message-ID (diff)
From: Philipp Puschmann <philipp.puschmann@emlix.com>
To: linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, jslaby@suse.com, vkoul@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	gregkh@linuxfoundation.org, dmaengine@vger.kernel.org,
	dan.j.williams@intel.com, festevam@gmail.com,
	Philipp Puschmann <philipp.puschmann@emlix.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Fix UART DMA freezes for iMX6
Date: Wed, 11 Sep 2019 16:49:39 +0200	[thread overview]
Message-ID: <20190911144943.21554-1-philipp.puschmann@emlix.com> (raw)

For some years and since many kernel versions there are reports that
RX UART DMA channel stops working at one point. So far the usual workaround was
to disable RX DMA. This patches try to fix the underlying problem.

When a running sdma script does not find any usable destination buffer to put
its data into it just leads to stopping the channel being scheduled again. As
solution we we manually retrigger the sdma script for this channel and by this
dissolve the freeze.

While this seems to work fine so far a further patch in this series increases
the number of RX DMA periods for UART to reduce use cases running into such
a situation.

This patch series was tested with the current kernel and backported to
kernel 4.15 with a special use case using a WL1837MOD via UART and provoking
the hanging of UART RX DMA within seconds after starting a test application.
It resulted in well known
  "Bluetooth: hci0: command 0x0408 tx timeout"
errors and complete stop of UART data reception. Our Bluetooth traffic consists
of many independent small packets, mostly only a few bytes, causing high usage
of periods.


Philipp Puschmann (4):
  dmaengine: imx-sdma: fix buffer ownership
  dmaengine: imx-sdma: fix dma freezes
  serial: imx: adapt rx buffer and dma periods
  dmaengine: imx-sdma: drop redundant variable

 drivers/dma/imx-sdma.c   | 32 ++++++++++++++++++++++----------
 drivers/tty/serial/imx.c |  5 ++---
 2 files changed, 24 insertions(+), 13 deletions(-)

-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2019-09-11 14:55 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 14:49 Philipp Puschmann [this message]
2019-09-11 14:49 ` [PATCH 0/4] Fix UART DMA freezes for iMX6 Philipp Puschmann
2019-09-11 14:49 ` Philipp Puschmann
2019-09-11 14:49 ` [PATCH 1/4] dmaengine: imx-sdma: fix buffer ownership Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-16 14:17   ` Lucas Stach
2019-09-16 14:17     ` Lucas Stach
2019-09-19  9:20     ` Philipp Puschmann
2019-09-19  9:20       ` Philipp Puschmann
2019-09-11 14:49 ` [PATCH 2/4] dmaengine: imx-sdma: fix dma freezes Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-16 14:22   ` Lucas Stach
2019-09-16 14:22     ` Lucas Stach
2019-09-11 14:49 ` [PATCH 3/4] serial: imx: adapt rx buffer and dma periods Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-16 14:24   ` Lucas Stach
2019-09-16 14:24     ` Lucas Stach
2019-09-11 14:49 ` [PATCH 4/4] dmaengine: imx-sdma: drop redundant variable Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-11 14:49   ` Philipp Puschmann
2019-09-16 14:30   ` Lucas Stach
2019-09-16 14:30     ` Lucas Stach
2019-09-12 15:31 ` [PATCH 0/4] Fix UART DMA freezes for iMX6 Fabio Estevam
2019-09-12 15:31   ` Fabio Estevam
2019-09-12 15:31   ` Fabio Estevam
2019-09-12 18:23 ` Fabio Estevam
2019-09-12 18:23   ` Fabio Estevam
2019-09-12 18:23   ` Fabio Estevam
2019-09-16 13:55   ` Philipp Puschmann
2019-09-16 13:55     ` Philipp Puschmann
2019-09-16 14:00     ` Fabio Estevam
2019-09-16 14:00       ` Fabio Estevam
2019-09-16 14:00       ` Fabio Estevam
2019-09-16 14:10     ` [EXT] " Andy Duan
2019-09-16 14:10       ` Andy Duan
2019-09-16 14:10       ` Andy Duan
2019-09-16  8:02 ` Robin Gong
2019-09-16  8:02   ` Robin Gong
2019-09-16  8:02   ` Robin Gong
2019-09-16 13:41   ` Philipp Puschmann
2019-09-16 13:41     ` Philipp Puschmann
2019-09-16 13:41     ` Philipp Puschmann
2019-09-19 10:23 ` [PATCH v2 0/3] Fix UART DMA freezes for i.MX SOCs Philipp Puschmann
2019-09-19 10:23   ` Philipp Puschmann
2019-09-19 10:23   ` [PATCH v2 1/3] dmaengine: imx-sdma: fix buffer ownership Philipp Puschmann
2019-09-19 10:23     ` Philipp Puschmann
2019-09-19 10:27     ` Lucas Stach
2019-09-19 10:27       ` Lucas Stach
2019-09-19 10:34       ` Philipp Puschmann
2019-09-19 10:34         ` Philipp Puschmann
2019-09-21 15:15     ` kbuild test robot
2019-09-19 10:23   ` [PATCH v2 2/3] dmaengine: imx-sdma: fix dma freezes Philipp Puschmann
2019-09-19 10:23     ` Philipp Puschmann
2019-09-19 10:23   ` [PATCH v2 3/3] dmaengine: imx-sdma: drop redundant variable Philipp Puschmann
2019-09-19 10:23     ` Philipp Puschmann
2019-09-19 10:33   ` [PATCH v2 0/3] Fix UART DMA freezes for i.MX SOCs Fabio Estevam
2019-09-19 10:33     ` Fabio Estevam
2019-09-19 10:45   ` [PATCH v3 " Philipp Puschmann
2019-09-19 10:45     ` Philipp Puschmann
2019-09-19 10:45     ` [PATCH v3 1/3] dmaengine: imx-sdma: fix buffer ownership Philipp Puschmann
2019-09-19 10:45       ` Philipp Puschmann
2019-09-19 11:37       ` Fabio Estevam
2019-09-19 11:37         ` Fabio Estevam
2019-09-19 11:42         ` Philipp Puschmann
2019-09-19 11:42           ` Philipp Puschmann
2019-09-19 10:45     ` [PATCH v3 2/3] dmaengine: imx-sdma: fix dma freezes Philipp Puschmann
2019-09-19 10:45       ` Philipp Puschmann
2019-09-19 10:45     ` [PATCH v3 3/3] dmaengine: imx-sdma: drop redundant variable Philipp Puschmann
2019-09-19 10:45       ` Philipp Puschmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190911144943.21554-1-philipp.puschmann@emlix.com \
    --to=philipp.puschmann@emlix.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.