All of lore.kernel.org
 help / color / mirror / Atom feed
From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v6 07/10] drm/i915/dsb: function to trigger workload execution of DSB.
Date: Thu, 12 Sep 2019 00:41:30 +0530	[thread overview]
Message-ID: <20190911191133.23383-8-animesh.manna@intel.com> (raw)
In-Reply-To: <20190911191133.23383-1-animesh.manna@intel.com>

Batch buffer will be created through dsb-reg-write function which can have
single/multiple request based on usecase and once the buffer is ready
commit function will trigger the execution of the batch buffer. All
the registers will be updated simultaneously.

v1: Initial version.
v2: Optimized code few places. (Chris)
v3: USed DRM_ERROR for dsb head/tail programming failure. (Shashank)

Cc: Imre Deak <imre.deak@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Shashank Sharma <shashank.sharma@intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsb.c | 42 ++++++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dsb.h |  1 +
 drivers/gpu/drm/i915/i915_reg.h          |  2 ++
 3 files changed, 45 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 2b0ffc0afb74..eea86afb0583 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -212,3 +212,45 @@ void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val)
 			       (DSB_BYTE_EN << DSB_BYTE_EN_SHIFT) |
 			       i915_mmio_reg_offset(reg);
 }
+
+void intel_dsb_commit(struct intel_dsb *dsb)
+{
+	struct intel_crtc *crtc = container_of(dsb, typeof(*crtc), dsb);
+	struct drm_device *dev = crtc->base.dev;
+	struct drm_i915_private *dev_priv = to_i915(dev);
+	enum pipe pipe = crtc->pipe;
+	u32 tail;
+
+	if (!dsb->free_pos)
+		return;
+
+	if (!intel_dsb_enable_engine(dsb))
+		goto reset;
+
+	if (is_dsb_busy(dsb)) {
+		DRM_ERROR("HEAD_PTR write failed - dsb engine is busy.\n");
+		goto reset;
+	}
+	I915_WRITE(DSB_HEAD(pipe, dsb->id), i915_ggtt_offset(dsb->vma));
+
+	tail = ALIGN(dsb->free_pos * 4, CACHELINE_BYTES);
+	if (tail > dsb->free_pos * 4)
+		memset(&dsb->cmd_buf[dsb->free_pos], 0,
+		       (tail - dsb->free_pos * 4));
+
+	if (is_dsb_busy(dsb)) {
+		DRM_ERROR("TAIL_PTR write failed - dsb engine is busy.\n");
+		goto reset;
+	}
+	DRM_DEBUG_KMS("DSB execution started - head 0x%x, tail 0x%x\n",
+		      i915_ggtt_offset(dsb->vma), tail);
+	I915_WRITE(DSB_TAIL(pipe, dsb->id), i915_ggtt_offset(dsb->vma) + tail);
+	if (wait_for(!is_dsb_busy(dsb), 1)) {
+		DRM_ERROR("Timed out waiting for DSB workload completion.\n");
+		goto reset;
+	}
+
+reset:
+	dsb->free_pos = 0;
+	intel_dsb_disable_engine(dsb);
+}
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index 9b2522f20bfb..7389c8c5b665 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -43,5 +43,6 @@ void intel_dsb_put(struct intel_dsb *dsb);
 void intel_dsb_reg_write(struct intel_dsb *dsb, i915_reg_t reg, u32 val);
 void intel_dsb_indexed_reg_write(struct intel_dsb *dsb, i915_reg_t reg,
 				 u32 val);
+void intel_dsb_commit(struct intel_dsb *dsb);
 
 #endif
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 2dbaa49f5c74..c77b5066d8dd 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -11687,6 +11687,8 @@ enum skl_power_gate {
 #define _DSBSL_INSTANCE_BASE		0x70B00
 #define DSBSL_INSTANCE(pipe, id)	(_DSBSL_INSTANCE_BASE + \
 					 (pipe) * 0x1000 + (id) * 100)
+#define DSB_HEAD(pipe, id)		_MMIO(DSBSL_INSTANCE(pipe, id) + 0x0)
+#define DSB_TAIL(pipe, id)		_MMIO(DSBSL_INSTANCE(pipe, id) + 0x4)
 #define DSB_CTRL(pipe, id)		_MMIO(DSBSL_INSTANCE(pipe, id) + 0x8)
 #define   DSB_ENABLE			(1 << 31)
 #define   DSB_STATUS			(1 << 0)
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-09-11 19:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 19:11 [PATCH v6 00/10] DSB enablement Animesh Manna
2019-09-11 19:11 ` [PATCH v6 01/10] drm/i915/dsb: feature flag added for display state buffer Animesh Manna
2019-09-12 12:09   ` Sharma, Shashank
2019-09-11 19:11 ` [PATCH v6 02/10] drm/i915/dsb: DSB context creation Animesh Manna
2019-09-12 12:31   ` Sharma, Shashank
2019-09-12 12:47   ` Jani Nikula
2019-09-11 19:11 ` [PATCH v6 03/10] drm/i915/dsb: single register write function for DSB Animesh Manna
2019-09-12 12:48   ` Sharma, Shashank
2019-09-12 12:51     ` Jani Nikula
2019-09-12 13:00       ` Sharma, Shashank
2019-09-12 13:07         ` Animesh Manna
2019-09-12 13:20           ` Sharma, Shashank
2019-09-11 19:11 ` [PATCH v6 04/10] drm/i915/dsb: Indexed " Animesh Manna
2019-09-12 13:18   ` Sharma, Shashank
2019-09-11 19:11 ` [PATCH v6 05/10] drm/i915/dsb: Check DSB engine status Animesh Manna
2019-09-12 13:21   ` Sharma, Shashank
2019-09-11 19:11 ` [PATCH v6 06/10] drm/i915/dsb: functions to enable/disable DSB engine Animesh Manna
2019-09-12 13:34   ` Sharma, Shashank
2019-09-11 19:11 ` Animesh Manna [this message]
2019-09-12 13:36   ` [PATCH v6 07/10] drm/i915/dsb: function to trigger workload execution of DSB Sharma, Shashank
2019-09-12 13:39     ` Jani Nikula
2019-09-12 13:58       ` Sharma, Shashank
2019-09-16 19:23         ` Jani Nikula
2019-09-11 19:11 ` [PATCH v6 08/10] drm/i915/dsb: Enable gamma lut programming using DSB Animesh Manna
2019-09-12 13:07   ` Jani Nikula
2019-09-12 13:26     ` Animesh Manna
2019-09-17  7:30       ` Jani Nikula
2019-09-17  9:19         ` Animesh Manna
2019-09-11 19:11 ` [PATCH v6 09/10] drm/i915/dsb: Enable DSB for gen12 Animesh Manna
2019-09-12 14:00   ` Sharma, Shashank
2019-09-11 19:11 ` [PATCH v6 10/10] drm/i915/dsb: Documentation for DSB Animesh Manna
2019-09-12  7:02 ` ✗ Fi.CI.CHECKPATCH: warning for DSB enablement. (rev6) Patchwork
2019-09-12  7:04 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-09-12  7:25 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-12 11:50 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190911191133.23383-8-animesh.manna@intel.com \
    --to=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.