From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Subject: [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message
Date: Fri, 13 Sep 2019 17:20:21 +0100 [thread overview]
Message-ID: <20190913162021.23329-1-andrew.cooper3@citrix.com> (raw)
ERST isn't a mandatory table, and also isn't very common to find. The message
is unnecessary noise during boot. Furthermore, it is redundant with the list
of found ACPI tables printed just ahead.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
---
xen/drivers/acpi/apei/erst.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c
index 23a4e822e7..c5df512b98 100644
--- a/xen/drivers/acpi/apei/erst.c
+++ b/xen/drivers/acpi/apei/erst.c
@@ -791,10 +791,9 @@ int __init erst_init(void)
return -ENODEV;
status = acpi_get_table_phys(ACPI_SIG_ERST, 0, &erst_addr, &erst_len);
- if (status == AE_NOT_FOUND) {
- printk(KERN_INFO "ERST table was not found\n");
+ if (status == AE_NOT_FOUND)
return -ENODEV;
- }
+
if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
printk(KERN_WARNING "Failed to get ERST table: %s\n", msg);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-09-13 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 16:20 Andrew Cooper [this message]
2019-09-16 7:35 ` [Xen-devel] [PATCH] drivers/acpi: Drop "ERST table was not found" message Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913162021.23329-1-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.