All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@collabora.com>
To: linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: corbet@lwn.net, axboe@kernel.dk, kernel@collabora.com,
	krisman@collabora.com,
	"André Almeida" <andrealmeid@collabora.com>
Subject: [PATCH 0/4] null_blk: fixes around nr_devices and log improvements
Date: Fri, 13 Sep 2019 15:57:42 -0300	[thread overview]
Message-ID: <20190913185746.337429-1-andrealmeid@collabora.com> (raw)

Hello,

This patch series address feedback for a previous patch series sent by
me "docs: block: null_blk: enhance document style"[1].

First patch removes a restriction that prevents null_blk to load with
(nr_devices == 0). This restriction breaks applications, so it's a bug. I
have tested it running the kernel with `null_blk.nr_devices=0`.

In the previous series I have changed the type of var nr_devices, but I
forgot to change the type at module_param(). The second patch fix that.

The third patch uses a cleaver approach to make log messages consistent
using pr_fmt and the last one add a note on how to do that at the
coding style documentation.

Thanks,
	André

[1] https://patchwork.kernel.org/project/linux-block/list/?series=172853

André Almeida (4):
  null_blk: do not fail the module load with zero devices
  null_blk: match the type of module parameter
  null_blk: format pr_* logs with pr_fmt
  coding-style: add explanation about pr_fmt macro

 Documentation/process/coding-style.rst | 10 +++++++++-
 drivers/block/null_blk.h               |  4 +++-
 drivers/block/null_blk_main.c          | 24 ++++++++++--------------
 drivers/block/null_blk_zoned.c         |  6 +++---
 4 files changed, 25 insertions(+), 19 deletions(-)

-- 
2.23.0


             reply	other threads:[~2019-09-13 18:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 18:57 André Almeida [this message]
2019-09-13 18:57 ` [PATCH 1/4] null_blk: do not fail the module load with zero devices André Almeida
2019-09-13 18:57 ` [PATCH 2/4] null_blk: match the type of parameter nr_devices André Almeida
2019-09-13 18:57 ` [PATCH 3/4] null_blk: format pr_* logs with pr_fmt André Almeida
2019-09-13 20:18   ` Chaitanya Kulkarni
2019-09-13 18:57 ` [PATCH 4/4] coding-style: add explanation about pr_fmt macro André Almeida
2019-09-13 19:08   ` Joe Perches
2019-09-13 19:36     ` André Almeida
2019-09-13 20:22   ` Bart Van Assche
2019-09-14  7:08     ` Jonathan Corbet
2019-09-13 19:03 ` [PATCH 0/4] null_blk: fixes around nr_devices and log improvements Jens Axboe
2019-09-13 19:22   ` André Almeida
2019-09-13 20:50     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913185746.337429-1-andrealmeid@collabora.com \
    --to=andrealmeid@collabora.com \
    --cc=axboe@kernel.dk \
    --cc=corbet@lwn.net \
    --cc=kernel@collabora.com \
    --cc=krisman@collabora.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.