All of lore.kernel.org
 help / color / mirror / Atom feed
From: Slavomir Kaslev <kaslevs@vmware.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v14 08/13] trace-cmd: Switch stop recording signal to SIGUSR1
Date: Tue, 17 Sep 2019 16:15:33 +0300	[thread overview]
Message-ID: <20190917131538.31926-9-kaslevs@vmware.com> (raw)
In-Reply-To: <20190917131538.31926-1-kaslevs@vmware.com>

From: "Slavomir Kaslev (VMware)" <slavomir.kaslev@gmail.com>

Using Ctrl-C to stop trace-cmd recording from the command line delivers SIGINT
to all its child processes. Switch internal recording stop notification to
SIGUSR1 so that notifying recording child processes can be delayed in order to
do proper flushing when doing remote VM tracing.

Also remove the flush() function, which is only used by trace-cmd listen, and
use finish() instead without changing listener's behavior.

Signed-off-by: Slavomir Kaslev (VMware) <slavomir.kaslev@gmail.com>
Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
 tracecmd/trace-record.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 94d01c5..4880f50 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -676,7 +676,7 @@ static void stop_threads(enum trace_type type)
 	/* Tell all threads to finish up */
 	for (i = 0; i < recorder_threads; i++) {
 		if (pids[i].pid > 0) {
-			kill(pids[i].pid, SIGINT);
+			kill(pids[i].pid, SIGUSR1);
 		}
 	}
 
@@ -2656,12 +2656,6 @@ static void finish(int sig)
 	finished = 1;
 }
 
-static void flush(int sig)
-{
-	if (recorder)
-		tracecmd_stop_recording(recorder);
-}
-
 static int connect_port(const char *host, unsigned int port)
 {
 	struct addrinfo hints;
@@ -3015,7 +3009,6 @@ static int create_recorder(struct buffer_instance *instance, int cpu,
 	pid_t pid;
 
 	if (type != TRACE_TYPE_EXTRACT) {
-		signal(SIGUSR1, flush);
 
 		pid = fork();
 		if (pid < 0)
@@ -3024,6 +3017,9 @@ static int create_recorder(struct buffer_instance *instance, int cpu,
 		if (pid)
 			return pid;
 
+		signal(SIGINT, SIG_IGN);
+		signal(SIGUSR1, finish);
+
 		if (rt_prio)
 			set_prio(rt_prio);
 
-- 
2.20.1


  parent reply	other threads:[~2019-09-17 13:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 13:15 [PATCH v14 00/13] Add VM kernel tracing over vsockets and FIFOs Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 01/13] trace-cmd: Make ports unsigned int Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 02/13] trace-cmd: Detect if vsockets are available Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 03/13] trace-cmd: Add tracecmd_create_recorder_virt() function Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 04/13] trace-cmd: Add VM tracing protocol messages Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 05/13] trace-cmd: Add buffer instance flags for tracing in guest and agent context Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 06/13] trace-cmd: Add VM kernel tracing over vsockets transport Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 07/13] trace-cmd: Use splice(2) for vsockets if available Slavomir Kaslev
2019-09-17 13:15 ` Slavomir Kaslev [this message]
2019-09-17 13:15 ` [PATCH v14 09/13] trace-cmd: Add `trace-cmd setup-guest` command Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 10/13] trace-cmd: Try to autodetect number of guest CPUs in setup-guest if not specified Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 11/13] trace-cmd: Add setup-guest flag for attaching FIFOs to the guest VM config Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 12/13] trace-cmd: Add VM kernel tracing over FIFO transport Slavomir Kaslev
2019-09-17 13:15 ` [PATCH v14 13/13] trace-cmd: Add support for tracing VMware Workstation VMs by name Slavomir Kaslev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917131538.31926-9-kaslevs@vmware.com \
    --to=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.