From: Mihail Atanassov <Mihail.Atanassov@arm.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: Mihail Atanassov <Mihail.Atanassov@arm.com>, Liviu Dudau <Liviu.Dudau@arm.com>, "maarten.lankhorst@linux.intel.com" <maarten.lankhorst@linux.intel.com>, "seanpaul@chromium.org" <seanpaul@chromium.org>, "airlied@linux.ie" <airlied@linux.ie>, Brian Starkey <Brian.Starkey@arm.com>, Ayan Halder <Ayan.Halder@arm.com>, "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>, "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>, nd <nd@arm.com>, "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>, Liviu Dudau <Liviu.Dudau@arm.com>, Brian Starkey <Brian.Starkey@arm.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: [PATCH] drm/komeda: Remove in-code use of ifdef Date: Tue, 17 Sep 2019 15:05:08 +0000 [thread overview] Message-ID: <20190917150314.20892-1-mihail.atanassov@arm.com> (raw) In-Reply-To: <CAKMK7uECMr46Ag8E=eqTKdZxgt_4M42t7GEyNGv0gxpv-TL3Pg@mail.gmail.com> Provide a dummy static inline function in the header instead. Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Lowry Li (Arm Technology China) <Lowry.Li@arm.com> Cc: james qian wang (Arm Technology China) <james.qian.wang@arm.com> Fixes: 4d74b25ee395 ("drm/komeda: Adds error event print functionality") Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index e28e7e6563ab..8acf8c0601cc 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -220,6 +220,8 @@ struct komeda_dev *dev_to_mdev(struct device *dev); #ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT void komeda_print_events(struct komeda_events *evts); +#else +static inline void komeda_print_events(struct komeda_events *evts) {} #endif #endif /*_KOMEDA_DEV_H_*/ diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index 18d7e2520225..dc85c08e614d 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -47,9 +47,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) memset(&evts, 0, sizeof(evts)); status = mdev->funcs->irq_handler(mdev, &evts); -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT komeda_print_events(&evts); -#endif /* Notify the crtc to handle the events */ for (i = 0; i < kms->n_crtcs; i++) -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Mihail Atanassov <Mihail.Atanassov@arm.com> To: Daniel Vetter <daniel@ffwll.ch> Cc: nd <nd@arm.com>, Ayan Halder <Ayan.Halder@arm.com>, "airlied@linux.ie" <airlied@linux.ie>, Liviu Dudau <Liviu.Dudau@arm.com>, "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>, "seanpaul@chromium.org" <seanpaul@chromium.org>, "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>, Mihail Atanassov <Mihail.Atanassov@arm.com> Subject: [PATCH] drm/komeda: Remove in-code use of ifdef Date: Tue, 17 Sep 2019 15:05:08 +0000 [thread overview] Message-ID: <20190917150314.20892-1-mihail.atanassov@arm.com> (raw) In-Reply-To: <CAKMK7uECMr46Ag8E=eqTKdZxgt_4M42t7GEyNGv0gxpv-TL3Pg@mail.gmail.com> Provide a dummy static inline function in the header instead. Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Lowry Li (Arm Technology China) <Lowry.Li@arm.com> Cc: james qian wang (Arm Technology China) <james.qian.wang@arm.com> Fixes: 4d74b25ee395 ("drm/komeda: Adds error event print functionality") Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++ drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h index e28e7e6563ab..8acf8c0601cc 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h @@ -220,6 +220,8 @@ struct komeda_dev *dev_to_mdev(struct device *dev); #ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT void komeda_print_events(struct komeda_events *evts); +#else +static inline void komeda_print_events(struct komeda_events *evts) {} #endif #endif /*_KOMEDA_DEV_H_*/ diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c index 18d7e2520225..dc85c08e614d 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -47,9 +47,7 @@ static irqreturn_t komeda_kms_irq_handler(int irq, void *data) memset(&evts, 0, sizeof(evts)); status = mdev->funcs->irq_handler(mdev, &evts); -#ifdef CONFIG_DRM_KOMEDA_ERROR_PRINT komeda_print_events(&evts); -#endif /* Notify the crtc to handle the events */ for (i = 0; i < kms->n_crtcs; i++) -- 2.23.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-09-17 15:05 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-02 9:43 [PATCH] drm/komeda: Adds error event print functionality Lowry Li (Arm Technology China) 2019-08-02 9:43 ` Lowry Li (Arm Technology China) 2019-08-02 10:05 ` Mihail Atanassov 2019-08-02 10:05 ` Mihail Atanassov 2019-08-02 10:43 ` james qian wang (Arm Technology China) 2019-08-02 10:43 ` james qian wang (Arm Technology China) 2019-09-17 13:11 ` Daniel Vetter 2019-09-17 13:11 ` Daniel Vetter 2019-09-17 15:05 ` Mihail Atanassov [this message] 2019-09-17 15:05 ` [PATCH] drm/komeda: Remove in-code use of ifdef Mihail Atanassov 2019-09-18 7:59 ` Daniel Vetter 2019-09-18 7:59 ` Daniel Vetter 2019-09-18 8:23 ` james qian wang (Arm Technology China) 2019-09-18 8:23 ` james qian wang (Arm Technology China) 2019-09-18 1:29 ` [PATCH] drm/komeda: Adds error event print functionality james qian wang (Arm Technology China) 2019-09-18 1:29 ` james qian wang (Arm Technology China)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190917150314.20892-1-mihail.atanassov@arm.com \ --to=mihail.atanassov@arm.com \ --cc=Ayan.Halder@arm.com \ --cc=Brian.Starkey@arm.com \ --cc=Jonathan.Chai@arm.com \ --cc=Julien.Yin@arm.com \ --cc=Liviu.Dudau@arm.com \ --cc=Lowry.Li@arm.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=james.qian.wang@arm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=nd@arm.com \ --cc=seanpaul@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.