From: Sven Eckelmann <sven@narfation.org> To: ath10k@lists.infradead.org Cc: vnaralas@codeaurora.org, linux-wireless@vger.kernel.org, Sven Eckelmann <seckelmann@datto.com> Subject: [RFC PATCH 0/2] ath10k: provide survey info as accumulated data Date: Wed, 18 Sep 2019 14:42:57 +0200 [thread overview] Message-ID: <20190918124259.17804-1-sven@narfation.org> (raw) From: Sven Eckelmann <seckelmann@datto.com> Hi, it was observed that ath9k provides accumulated survey counters but ath10k neither provides deltas nor accumulated counters. Instead it returns some value which was returned at some point from the firmware. But as it turns out, this data is not reliable. To make it more useful, ath10k has to: * retrieve counters rather frequently for hardware which is known to use firmware versions with low number counter bits (for only 14-30s) * clean up received counter values * accumulate counters from firmware A comparison of the resulting output with these fixes can be seen under https://stats.freifunk-vogtland.net/d/ffv_node/nodeinfo?orgId=1&var-node=ac86749f4d60&fullscreen&panelId=5&from=1568782046974&to=1568807068706 The left side of the graph shows the output before the patches were applied and the right side the output with the patches applied. Just as reference, an ath9k device in the same building is https://stats.freifunk-vogtland.net/d/ffv_node/nodeinfo?orgId=1&var-node=ac86740037e0&fullscreen&panelId=5&from=1568782046974&to=1568807068706 Kind regards, Sven Sven Eckelmann (2): ath10k: report survey info as accumulated values ath10k: regularly fetch survey counters drivers/net/wireless/ath/ath10k/core.c | 8 ++++ drivers/net/wireless/ath/ath10k/core.h | 3 ++ drivers/net/wireless/ath/ath10k/hw.c | 13 +++-- drivers/net/wireless/ath/ath10k/mac.c | 52 ++++++++++++++++++++ drivers/net/wireless/ath/ath10k/mac.h | 3 ++ drivers/net/wireless/ath/ath10k/wmi.c | 66 ++++++++++++++++++++++---- 6 files changed, 130 insertions(+), 15 deletions(-) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org> To: ath10k@lists.infradead.org Cc: vnaralas@codeaurora.org, linux-wireless@vger.kernel.org, Sven Eckelmann <seckelmann@datto.com> Subject: [RFC PATCH 0/2] ath10k: provide survey info as accumulated data Date: Wed, 18 Sep 2019 14:42:57 +0200 [thread overview] Message-ID: <20190918124259.17804-1-sven@narfation.org> (raw) From: Sven Eckelmann <seckelmann@datto.com> Hi, it was observed that ath9k provides accumulated survey counters but ath10k neither provides deltas nor accumulated counters. Instead it returns some value which was returned at some point from the firmware. But as it turns out, this data is not reliable. To make it more useful, ath10k has to: * retrieve counters rather frequently for hardware which is known to use firmware versions with low number counter bits (for only 14-30s) * clean up received counter values * accumulate counters from firmware A comparison of the resulting output with these fixes can be seen under https://stats.freifunk-vogtland.net/d/ffv_node/nodeinfo?orgId=1&var-node=ac86749f4d60&fullscreen&panelId=5&from=1568782046974&to=1568807068706 The left side of the graph shows the output before the patches were applied and the right side the output with the patches applied. Just as reference, an ath9k device in the same building is https://stats.freifunk-vogtland.net/d/ffv_node/nodeinfo?orgId=1&var-node=ac86740037e0&fullscreen&panelId=5&from=1568782046974&to=1568807068706 Kind regards, Sven Sven Eckelmann (2): ath10k: report survey info as accumulated values ath10k: regularly fetch survey counters drivers/net/wireless/ath/ath10k/core.c | 8 ++++ drivers/net/wireless/ath/ath10k/core.h | 3 ++ drivers/net/wireless/ath/ath10k/hw.c | 13 +++-- drivers/net/wireless/ath/ath10k/mac.c | 52 ++++++++++++++++++++ drivers/net/wireless/ath/ath10k/mac.h | 3 ++ drivers/net/wireless/ath/ath10k/wmi.c | 66 ++++++++++++++++++++++---- 6 files changed, 130 insertions(+), 15 deletions(-) -- 2.20.1 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2019-09-18 12:43 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-18 12:42 Sven Eckelmann [this message] 2019-09-18 12:42 ` [RFC PATCH 0/2] ath10k: provide survey info as accumulated data Sven Eckelmann 2019-09-18 12:42 ` [RFC PATCH 1/2] ath10k: report survey info as accumulated values Sven Eckelmann 2019-09-18 12:42 ` Sven Eckelmann 2019-10-11 8:41 ` Kalle Valo 2019-10-11 8:41 ` Kalle Valo 2019-09-18 12:42 ` [RFC PATCH 2/2] ath10k: regularly fetch survey counters Sven Eckelmann 2019-09-18 12:42 ` Sven Eckelmann 2019-10-11 8:40 ` Kalle Valo 2019-10-11 8:40 ` Kalle Valo 2019-10-11 8:44 ` [RFC PATCH 0/2] ath10k: provide survey info as accumulated data Kalle Valo 2019-10-11 8:44 ` Kalle Valo 2019-10-13 22:15 ` Sebastian Gottschall 2019-10-13 22:15 ` Sebastian Gottschall 2019-10-14 7:07 ` Sven Eckelmann 2019-10-14 7:07 ` Sven Eckelmann 2019-10-14 8:57 ` Kalle Valo 2019-10-14 8:57 ` Kalle Valo 2019-10-14 9:32 ` Sebastian Gottschall 2019-10-14 9:32 ` Sebastian Gottschall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190918124259.17804-1-sven@narfation.org \ --to=sven@narfation.org \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=seckelmann@datto.com \ --cc=vnaralas@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.