All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: broonie@kernel.org, krzk@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com,
	b.zolnierkie@samsung.com, sbkim73@samsung.com,
	patches@opensource.cirrus.com, lgirdwood@gmail.com,
	robh+dt@kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: [PATCH v2 05/10] ASoC: samsung: arndale: Simplify DAI link initialization
Date: Fri, 20 Sep 2019 15:02:14 +0200	[thread overview]
Message-ID: <20190920130218.32690-6-s.nawrocki@samsung.com> (raw)
In-Reply-To: <20190920130218.32690-1-s.nawrocki@samsung.com>

There is only one DAI link so we can drop an unnecessary loop statement.
Use card->dai_link in place of direct static arndale_rt5631_dai[] array
dereference as a prerequisite for adding support for other CODECs.
Unnecessary assignment of dai_link->codecs->name to NULL is removed.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v1:
 - rebased due to reordering patches in the series
---
 sound/soc/samsung/arndale_rt5631.c | 42 +++++++++++++-----------------
 1 file changed, 18 insertions(+), 24 deletions(-)

diff --git a/sound/soc/samsung/arndale_rt5631.c b/sound/soc/samsung/arndale_rt5631.c
index fd8c6642fb0d..004c84fafad9 100644
--- a/sound/soc/samsung/arndale_rt5631.c
+++ b/sound/soc/samsung/arndale_rt5631.c
@@ -88,36 +88,30 @@ static void arndale_put_of_nodes(struct snd_soc_card *card)
 
 static int arndale_audio_probe(struct platform_device *pdev)
 {
-	int n, ret;
 	struct device_node *np = pdev->dev.of_node;
 	struct snd_soc_card *card = &arndale_rt5631;
+	struct snd_soc_dai_link *dai_link;
+	int ret;
 
 	card->dev = &pdev->dev;
+	dai_link = card->dai_link;
+
+	dai_link->cpus->of_node = of_parse_phandle(np, "samsung,audio-cpu", 0);
+	if (!dai_link->cpus->of_node) {
+		dev_err(&pdev->dev,
+			"Property 'samsung,audio-cpu' missing or invalid\n");
+		return -EINVAL;
+	}
 
-	for (n = 0; np && n < ARRAY_SIZE(arndale_rt5631_dai); n++) {
-		if (!arndale_rt5631_dai[n].cpus->dai_name) {
-			arndale_rt5631_dai[n].cpus->of_node = of_parse_phandle(np,
-					"samsung,audio-cpu", n);
-
-			if (!arndale_rt5631_dai[n].cpus->of_node) {
-				dev_err(&pdev->dev,
-				"Property 'samsung,audio-cpu' missing or invalid\n");
-				return -EINVAL;
-			}
-		}
-		if (!arndale_rt5631_dai[n].platforms->name)
-			arndale_rt5631_dai[n].platforms->of_node =
-					arndale_rt5631_dai[n].cpus->of_node;
-
-		arndale_rt5631_dai[n].codecs->name = NULL;
-		arndale_rt5631_dai[n].codecs->of_node = of_parse_phandle(np,
-					"samsung,audio-codec", n);
-		if (!arndale_rt5631_dai[0].codecs->of_node) {
-			dev_err(&pdev->dev,
+	if (!dai_link->platforms->name)
+		dai_link->platforms->of_node = dai_link->cpus->of_node;
+
+	dai_link->codecs->of_node = of_parse_phandle(np, "samsung,audio-codec", 0);
+	if (!dai_link->codecs->of_node) {
+		dev_err(&pdev->dev,
 			"Property 'samsung,audio-codec' missing or invalid\n");
-			ret = -EINVAL;
-			goto err_put_of_nodes;
-		}
+		ret = -EINVAL;
+		goto err_put_of_nodes;
 	}
 
 	ret = devm_snd_soc_register_card(card->dev, card);
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: broonie@kernel.org, krzk@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com,
	b.zolnierkie@samsung.com, sbkim73@samsung.com,
	patches@opensource.cirrus.com, lgirdwood@gmail.com,
	robh+dt@kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: [alsa-devel] [PATCH v2 05/10] ASoC: samsung: arndale: Simplify DAI link initialization
Date: Fri, 20 Sep 2019 15:02:14 +0200	[thread overview]
Message-ID: <20190920130218.32690-6-s.nawrocki@samsung.com> (raw)
In-Reply-To: <20190920130218.32690-1-s.nawrocki@samsung.com>

There is only one DAI link so we can drop an unnecessary loop statement.
Use card->dai_link in place of direct static arndale_rt5631_dai[] array
dereference as a prerequisite for adding support for other CODECs.
Unnecessary assignment of dai_link->codecs->name to NULL is removed.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v1:
 - rebased due to reordering patches in the series
---
 sound/soc/samsung/arndale_rt5631.c | 42 +++++++++++++-----------------
 1 file changed, 18 insertions(+), 24 deletions(-)

diff --git a/sound/soc/samsung/arndale_rt5631.c b/sound/soc/samsung/arndale_rt5631.c
index fd8c6642fb0d..004c84fafad9 100644
--- a/sound/soc/samsung/arndale_rt5631.c
+++ b/sound/soc/samsung/arndale_rt5631.c
@@ -88,36 +88,30 @@ static void arndale_put_of_nodes(struct snd_soc_card *card)
 
 static int arndale_audio_probe(struct platform_device *pdev)
 {
-	int n, ret;
 	struct device_node *np = pdev->dev.of_node;
 	struct snd_soc_card *card = &arndale_rt5631;
+	struct snd_soc_dai_link *dai_link;
+	int ret;
 
 	card->dev = &pdev->dev;
+	dai_link = card->dai_link;
+
+	dai_link->cpus->of_node = of_parse_phandle(np, "samsung,audio-cpu", 0);
+	if (!dai_link->cpus->of_node) {
+		dev_err(&pdev->dev,
+			"Property 'samsung,audio-cpu' missing or invalid\n");
+		return -EINVAL;
+	}
 
-	for (n = 0; np && n < ARRAY_SIZE(arndale_rt5631_dai); n++) {
-		if (!arndale_rt5631_dai[n].cpus->dai_name) {
-			arndale_rt5631_dai[n].cpus->of_node = of_parse_phandle(np,
-					"samsung,audio-cpu", n);
-
-			if (!arndale_rt5631_dai[n].cpus->of_node) {
-				dev_err(&pdev->dev,
-				"Property 'samsung,audio-cpu' missing or invalid\n");
-				return -EINVAL;
-			}
-		}
-		if (!arndale_rt5631_dai[n].platforms->name)
-			arndale_rt5631_dai[n].platforms->of_node =
-					arndale_rt5631_dai[n].cpus->of_node;
-
-		arndale_rt5631_dai[n].codecs->name = NULL;
-		arndale_rt5631_dai[n].codecs->of_node = of_parse_phandle(np,
-					"samsung,audio-codec", n);
-		if (!arndale_rt5631_dai[0].codecs->of_node) {
-			dev_err(&pdev->dev,
+	if (!dai_link->platforms->name)
+		dai_link->platforms->of_node = dai_link->cpus->of_node;
+
+	dai_link->codecs->of_node = of_parse_phandle(np, "samsung,audio-codec", 0);
+	if (!dai_link->codecs->of_node) {
+		dev_err(&pdev->dev,
 			"Property 'samsung,audio-codec' missing or invalid\n");
-			ret = -EINVAL;
-			goto err_put_of_nodes;
-		}
+		ret = -EINVAL;
+		goto err_put_of_nodes;
 	}
 
 	ret = devm_snd_soc_register_card(card->dev, card);
-- 
2.17.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: broonie@kernel.org, krzk@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-samsung-soc@vger.kernel.org, ckeepax@opensource.cirrus.com,
	b.zolnierkie@samsung.com, sbkim73@samsung.com,
	patches@opensource.cirrus.com, lgirdwood@gmail.com,
	robh+dt@kernel.org, Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: [PATCH v2 05/10] ASoC: samsung: arndale: Simplify DAI link initialization
Date: Fri, 20 Sep 2019 15:02:14 +0200	[thread overview]
Message-ID: <20190920130218.32690-6-s.nawrocki@samsung.com> (raw)
In-Reply-To: <20190920130218.32690-1-s.nawrocki@samsung.com>

There is only one DAI link so we can drop an unnecessary loop statement.
Use card->dai_link in place of direct static arndale_rt5631_dai[] array
dereference as a prerequisite for adding support for other CODECs.
Unnecessary assignment of dai_link->codecs->name to NULL is removed.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v1:
 - rebased due to reordering patches in the series
---
 sound/soc/samsung/arndale_rt5631.c | 42 +++++++++++++-----------------
 1 file changed, 18 insertions(+), 24 deletions(-)

diff --git a/sound/soc/samsung/arndale_rt5631.c b/sound/soc/samsung/arndale_rt5631.c
index fd8c6642fb0d..004c84fafad9 100644
--- a/sound/soc/samsung/arndale_rt5631.c
+++ b/sound/soc/samsung/arndale_rt5631.c
@@ -88,36 +88,30 @@ static void arndale_put_of_nodes(struct snd_soc_card *card)
 
 static int arndale_audio_probe(struct platform_device *pdev)
 {
-	int n, ret;
 	struct device_node *np = pdev->dev.of_node;
 	struct snd_soc_card *card = &arndale_rt5631;
+	struct snd_soc_dai_link *dai_link;
+	int ret;
 
 	card->dev = &pdev->dev;
+	dai_link = card->dai_link;
+
+	dai_link->cpus->of_node = of_parse_phandle(np, "samsung,audio-cpu", 0);
+	if (!dai_link->cpus->of_node) {
+		dev_err(&pdev->dev,
+			"Property 'samsung,audio-cpu' missing or invalid\n");
+		return -EINVAL;
+	}
 
-	for (n = 0; np && n < ARRAY_SIZE(arndale_rt5631_dai); n++) {
-		if (!arndale_rt5631_dai[n].cpus->dai_name) {
-			arndale_rt5631_dai[n].cpus->of_node = of_parse_phandle(np,
-					"samsung,audio-cpu", n);
-
-			if (!arndale_rt5631_dai[n].cpus->of_node) {
-				dev_err(&pdev->dev,
-				"Property 'samsung,audio-cpu' missing or invalid\n");
-				return -EINVAL;
-			}
-		}
-		if (!arndale_rt5631_dai[n].platforms->name)
-			arndale_rt5631_dai[n].platforms->of_node =
-					arndale_rt5631_dai[n].cpus->of_node;
-
-		arndale_rt5631_dai[n].codecs->name = NULL;
-		arndale_rt5631_dai[n].codecs->of_node = of_parse_phandle(np,
-					"samsung,audio-codec", n);
-		if (!arndale_rt5631_dai[0].codecs->of_node) {
-			dev_err(&pdev->dev,
+	if (!dai_link->platforms->name)
+		dai_link->platforms->of_node = dai_link->cpus->of_node;
+
+	dai_link->codecs->of_node = of_parse_phandle(np, "samsung,audio-codec", 0);
+	if (!dai_link->codecs->of_node) {
+		dev_err(&pdev->dev,
 			"Property 'samsung,audio-codec' missing or invalid\n");
-			ret = -EINVAL;
-			goto err_put_of_nodes;
-		}
+		ret = -EINVAL;
+		goto err_put_of_nodes;
 	}
 
 	ret = devm_snd_soc_register_card(card->dev, card);
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-09-20 13:02 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190920130238eucas1p147fca337fa84592ac7f83760449e26a1@eucas1p1.samsung.com>
2019-09-20 13:02 ` [PATCH v2 00/10] Basic sound support for Arndale board / wm8994 updates Sylwester Nawrocki
2019-09-20 13:02   ` Sylwester Nawrocki
2019-09-20 13:02   ` [alsa-devel] " Sylwester Nawrocki
     [not found]   ` <CGME20190920130313eucas1p27758c613ab3a10296b92974f14bd521d@eucas1p2.samsung.com>
2019-09-20 13:02     ` [PATCH v2 01/10] ASoC: wm8994: Do not register inapplicable controls for WM1811 Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
     [not found]       ` <CGME20190920130711eucas1p29497b40981e4e0a24769ced4e06be208@eucas1p2.samsung.com>
2019-09-20 13:07         ` [PATCH v2 10/10] ARM: exynos_defconfig: Enable Arndale audio driver Sylwester Nawrocki
2019-09-20 13:07           ` Sylwester Nawrocki
2019-09-20 13:07           ` [alsa-devel] " Sylwester Nawrocki
2019-10-02 17:20           ` Krzysztof Kozlowski
2019-10-02 17:20             ` Krzysztof Kozlowski
2019-10-02 17:20             ` [alsa-devel] " Krzysztof Kozlowski
2019-10-02 17:20             ` Krzysztof Kozlowski
2019-09-23 21:22       ` Applied "ASoC: wm8994: Do not register inapplicable controls for WM1811" to the asoc tree Mark Brown
2019-09-23 21:22         ` Mark Brown
2019-09-23 21:22         ` [alsa-devel] " Mark Brown
     [not found]   ` <CGME20190920130315eucas1p2a31543214fedcdfe86196f176f554a35@eucas1p2.samsung.com>
2019-09-20 13:02     ` [PATCH v2 02/10] ASoC: samsung: arndale: Add missing OF node dereferencing Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  9:08       ` Krzysztof Kozlowski
2019-09-23  9:08         ` Krzysztof Kozlowski
2019-09-23  9:08         ` [alsa-devel] " Krzysztof Kozlowski
2019-09-23 21:22       ` Applied "ASoC: samsung: arndale: Add missing OF node dereferencing" to the asoc tree Mark Brown
2019-09-23 21:22         ` Mark Brown
2019-09-23 21:22         ` [alsa-devel] " Mark Brown
     [not found]   ` <CGME20190920130316eucas1p2de713006a13c62c0b895c2e33e0d14c7@eucas1p2.samsung.com>
2019-09-20 13:02     ` [PATCH v2 03/10] ASoC: wm8994: Add support for setting MCLK clock rate Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  9:10       ` Sylwester Nawrocki
2019-09-23  9:10         ` Sylwester Nawrocki
2019-09-23  9:10         ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  9:25         ` Charles Keepax
2019-09-23  9:25           ` Charles Keepax
2019-09-23  9:25           ` [alsa-devel] " Charles Keepax
2019-09-23 10:09         ` Krzysztof Kozlowski
2019-09-23 10:09           ` Krzysztof Kozlowski
2019-09-23 10:09           ` [alsa-devel] " Krzysztof Kozlowski
2019-10-01 11:40       ` Applied "ASoC: wm8994: Add support for setting MCLK clock rate" to the asoc tree Mark Brown
2019-10-01 11:40         ` Mark Brown
2019-10-01 11:40         ` [alsa-devel] " Mark Brown
2019-10-01 11:40         ` Mark Brown
     [not found]   ` <CGME20190920130317eucas1p188d724710077d704f768798c6555c741@eucas1p1.samsung.com>
2019-09-20 13:02     ` [PATCH v2 04/10] ASoC: wm8994: Add support for MCLKn clock gating Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  8:51       ` Charles Keepax
2019-09-23  8:51         ` Charles Keepax
2019-09-23  8:51         ` [alsa-devel] " Charles Keepax
2019-09-23  9:13         ` Sylwester Nawrocki
2019-09-23  9:13           ` Sylwester Nawrocki
2019-09-23  9:13           ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  9:09       ` Krzysztof Kozlowski
2019-09-23  9:09         ` Krzysztof Kozlowski
2019-09-23  9:09         ` [alsa-devel] " Krzysztof Kozlowski
2019-10-01 11:40       ` Applied "ASoC: wm8994: Add support for MCLKn clock gating" to the asoc tree Mark Brown
2019-10-01 11:40         ` Mark Brown
2019-10-01 11:40         ` [alsa-devel] " Mark Brown
2019-10-01 11:40         ` Mark Brown
     [not found]   ` <CGME20190920130318eucas1p126cc8be60118ffbf1f332626dde1c05a@eucas1p1.samsung.com>
2019-09-20 13:02     ` Sylwester Nawrocki [this message]
2019-09-20 13:02       ` [PATCH v2 05/10] ASoC: samsung: arndale: Simplify DAI link initialization Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-10-01 11:21       ` Mark Brown
2019-10-01 11:21         ` [alsa-devel] " Mark Brown
2019-10-01 11:21         ` Mark Brown
     [not found]   ` <CGME20190920130320eucas1p1ade2cf71fadfd442bcd79748e8512e09@eucas1p1.samsung.com>
2019-09-20 13:02     ` [PATCH v2 06/10] ASoC: dt-bindings: Document "samsung,arndale-wm1811" compatible Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] [PATCH v2 06/10] ASoC: dt-bindings: Document "samsung, arndale-wm1811" compatible Sylwester Nawrocki
2019-10-01 11:40       ` Applied "ASoC: dt-bindings: Document "samsung, arndale-wm1811" compatible" to the asoc tree Mark Brown
2019-10-01 11:40         ` Mark Brown
2019-10-01 11:40         ` [alsa-devel] " Mark Brown
2019-10-01 11:40         ` Mark Brown
     [not found]   ` <CGME20190920130321eucas1p2efe85adb3df4c546a7d81326b4c75873@eucas1p2.samsung.com>
2019-09-20 13:02     ` [PATCH v2 07/10] ASoC: samsung: arndale: Add support for WM1811 CODEC Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  9:16       ` Krzysztof Kozlowski
2019-09-23  9:16         ` Krzysztof Kozlowski
2019-09-23  9:16         ` [alsa-devel] " Krzysztof Kozlowski
2019-10-01 11:22       ` Mark Brown
2019-10-01 11:22         ` [alsa-devel] " Mark Brown
2019-10-01 11:22         ` Mark Brown
     [not found]   ` <CGME20190920130323eucas1p218c6822eca3869eb0d3b7380497bbca4@eucas1p2.samsung.com>
2019-09-20 13:02     ` [PATCH v2 08/10] ASoC: samsung: Rename Arndale card driver Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-09-23  9:17       ` Krzysztof Kozlowski
2019-09-23  9:17         ` Krzysztof Kozlowski
2019-09-23  9:17         ` [alsa-devel] " Krzysztof Kozlowski
2019-10-01 11:22       ` Mark Brown
2019-10-01 11:22         ` [alsa-devel] " Mark Brown
2019-10-01 11:22         ` Mark Brown
     [not found]   ` <CGME20190920130324eucas1p118bfab45306a29752bf4c1cfdd8f61a1@eucas1p1.samsung.com>
2019-09-20 13:02     ` [PATCH v2 09/10] ARM: dts: arndale: Add audio support (WM1811 CODEC boards) Sylwester Nawrocki
2019-09-20 13:02       ` Sylwester Nawrocki
2019-09-20 13:02       ` [alsa-devel] " Sylwester Nawrocki
2019-10-02 14:42       ` Krzysztof Kozlowski
2019-10-02 14:42         ` Krzysztof Kozlowski
2019-10-02 14:42         ` [alsa-devel] " Krzysztof Kozlowski
2019-10-02 14:42         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190920130218.32690-6-s.nawrocki@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=patches@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.