All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eryu Guan <eguan@redhat.com>, fstests@vger.kernel.org
Subject: [PATCH][xfstests-bld] build-all: fix acl tools build
Date: Fri, 20 Sep 2019 21:48:46 +0300	[thread overview]
Message-ID: <20190920184846.18251-1-amir73il@gmail.com> (raw)

On a clean do-all buster image getfacl is dynamically
linked with libacl.so.1, but the built library is not installed.
The installed libacl.so.1 in the image is incompatible with the
version of acl tools that we build:

root@kvm-xfstests:~# getfacl -n -p xfstests/
getfacl: symbol lookup error: getfacl: undefined symbol: walk_tree

Fix this by linking acl tools with the static libacl library.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 build-all | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/build-all b/build-all
index 217ae62..83a1394 100755
--- a/build-all
+++ b/build-all
@@ -233,12 +233,15 @@ fi
 
 if test -z "$SKIP_ACL" ; then
     build_start "ACL library"
+    # Specify NO_SOLIB=1 so that libacl is only built as a static
+    # library.  Then acl tools will be statically linked to it, and we won't
+    # have to install libacl1.so.
     (cd acl; \
      CPPFLAGS="-I$DESTDIR/include" \
      CFLAGS="$LCF -I$DESTDIR/include" \
      LDFLAGS="$LLF $EXEC_LDFLAGS -L$DESTDIR/lib" \
      ./configure $cross --prefix=$DESTDIR --disable-nls; $MAKE_CLEAN ; \
-     make $J LDFLAGS="$LLF $EXEC_LLDFLAGS -static -L$DESTDIR/lib" ; \
+     make $J NO_SOLIB=1 LDFLAGS="$LLF $EXEC_LLDFLAGS -static -L$DESTDIR/lib" ; \
      make $J install)
 fi
 
-- 
2.17.1

             reply	other threads:[~2019-09-20 18:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 18:48 Amir Goldstein [this message]
2019-09-20 18:51 ` [PATCH][xfstests-bld] build-all: fix acl tools build Amir Goldstein
2019-09-20 23:41   ` Theodore Y. Ts'o
2019-09-21 14:13 ` Theodore Y. Ts'o
2019-09-21 15:37   ` Amir Goldstein
2019-09-21 21:35     ` Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190920184846.18251-1-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.