From: Jia He <justin.he@arm.com> To: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, James Morse <james.morse@arm.com>, Marc Zyngier <maz@kernel.org>, Matthew Wilcox <willy@infradead.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Suzuki Poulose <Suzuki.Poulose@arm.com> Cc: "Punit Agrawal" <punitagrawal@gmail.com>, "Anshuman Khandual" <anshuman.khandual@arm.com>, "Alex Van Brunt" <avanbrunt@nvidia.com>, "Robin Murphy" <robin.murphy@arm.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Andrew Morton" <akpm@linux-foundation.org>, "Jérôme Glisse" <jglisse@redhat.com>, "Ralph Campbell" <rcampbell@nvidia.com>, hejianet@gmail.com, "Kaly Xin" <Kaly.Xin@arm.com>, nd@arm.com, "Jia He" <justin.he@arm.com> Subject: [PATCH v8 0/3] fix double page fault on arm64 Date: Sat, 21 Sep 2019 21:50:51 +0800 [thread overview] Message-ID: <20190921135054.142360-1-justin.he@arm.com> (raw) When we tested pmdk unit test vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in __copy_from_user_inatomic of cow_user_page. As told by Catalin: "On arm64 without hardware Access Flag, copying from user will fail because the pte is old and cannot be marked young. So we always end up with zeroed page after fork() + CoW for pfn mappings. we don't always have a hardware-managed access flag on arm64." Changes v8: change cow_user_page's return type (Matthew) v7: s/pte_spinlock/pte_offset_map_lock (Kirill) v6: fix error case of returning with spinlock taken (Catalin) move kmap_atomic to avoid handling kunmap_atomic v5: handle the case correctly when !pte_same fix kbuild test failed v4: introduce cpu_has_hw_af (Suzuki) bail out if !pte_same (Kirill) v3: add vmf->ptl lock/unlock (Kirill A. Shutemov) add arch_faults_on_old_pte (Matthew, Catalin) v2: remove FAULT_FLAG_WRITE when setting pte access flag (Catalin) Jia He (3): arm64: cpufeature: introduce helper cpu_has_hw_af() arm64: mm: implement arch_faults_on_old_pte() on arm64 mm: fix double page fault on arm64 if PTE_AF is cleared arch/arm64/include/asm/cpufeature.h | 10 +++++ arch/arm64/include/asm/pgtable.h | 12 ++++++ mm/memory.c | 67 ++++++++++++++++++++++++++--- 3 files changed, 83 insertions(+), 6 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Jia He <justin.he@arm.com> To: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, James Morse <james.morse@arm.com>, Marc Zyngier <maz@kernel.org>, Matthew Wilcox <willy@infradead.org>, "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Suzuki Poulose <Suzuki.Poulose@arm.com> Cc: "Ralph Campbell" <rcampbell@nvidia.com>, "Jia He" <justin.he@arm.com>, "Anshuman Khandual" <anshuman.khandual@arm.com>, "Alex Van Brunt" <avanbrunt@nvidia.com>, "Kaly Xin" <Kaly.Xin@arm.com>, "Jérôme Glisse" <jglisse@redhat.com>, "Punit Agrawal" <punitagrawal@gmail.com>, hejianet@gmail.com, "Andrew Morton" <akpm@linux-foundation.org>, nd@arm.com, "Robin Murphy" <robin.murphy@arm.com>, "Thomas Gleixner" <tglx@linutronix.de> Subject: [PATCH v8 0/3] fix double page fault on arm64 Date: Sat, 21 Sep 2019 21:50:51 +0800 [thread overview] Message-ID: <20190921135054.142360-1-justin.he@arm.com> (raw) When we tested pmdk unit test vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in __copy_from_user_inatomic of cow_user_page. As told by Catalin: "On arm64 without hardware Access Flag, copying from user will fail because the pte is old and cannot be marked young. So we always end up with zeroed page after fork() + CoW for pfn mappings. we don't always have a hardware-managed access flag on arm64." Changes v8: change cow_user_page's return type (Matthew) v7: s/pte_spinlock/pte_offset_map_lock (Kirill) v6: fix error case of returning with spinlock taken (Catalin) move kmap_atomic to avoid handling kunmap_atomic v5: handle the case correctly when !pte_same fix kbuild test failed v4: introduce cpu_has_hw_af (Suzuki) bail out if !pte_same (Kirill) v3: add vmf->ptl lock/unlock (Kirill A. Shutemov) add arch_faults_on_old_pte (Matthew, Catalin) v2: remove FAULT_FLAG_WRITE when setting pte access flag (Catalin) Jia He (3): arm64: cpufeature: introduce helper cpu_has_hw_af() arm64: mm: implement arch_faults_on_old_pte() on arm64 mm: fix double page fault on arm64 if PTE_AF is cleared arch/arm64/include/asm/cpufeature.h | 10 +++++ arch/arm64/include/asm/pgtable.h | 12 ++++++ mm/memory.c | 67 ++++++++++++++++++++++++++--- 3 files changed, 83 insertions(+), 6 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-09-21 13:51 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-21 13:50 Jia He [this message] 2019-09-21 13:50 ` [PATCH v8 0/3] fix double page fault on arm64 Jia He 2019-09-21 13:50 ` [PATCH v8 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af() Jia He 2019-09-21 13:50 ` Jia He 2019-09-23 16:07 ` Catalin Marinas 2019-09-23 16:07 ` Catalin Marinas 2019-09-24 1:50 ` Justin He (Arm Technology China) 2019-09-24 1:50 ` Justin He (Arm Technology China) 2019-09-21 13:50 ` [PATCH v8 2/3] arm64: mm: implement arch_faults_on_old_pte() on arm64 Jia He 2019-09-21 13:50 ` Jia He 2019-09-23 16:18 ` Catalin Marinas 2019-09-23 16:18 ` Catalin Marinas 2019-09-24 2:17 ` Justin He (Arm Technology China) 2019-09-24 2:17 ` Justin He (Arm Technology China) 2019-09-21 13:50 ` [PATCH v8 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared Jia He 2019-09-21 13:50 ` Jia He 2019-09-21 15:31 ` Matthew Wilcox 2019-09-21 15:31 ` Matthew Wilcox 2019-09-23 8:28 ` Kirill A. Shutemov 2019-09-23 8:28 ` Kirill A. Shutemov 2019-09-23 17:04 ` Catalin Marinas 2019-09-23 17:04 ` Catalin Marinas 2019-09-24 6:43 ` Justin He (Arm Technology China) 2019-09-24 6:43 ` Justin He (Arm Technology China) 2019-09-24 10:33 ` Catalin Marinas 2019-09-24 10:33 ` Catalin Marinas 2019-09-24 11:59 ` Kirill A. Shutemov 2019-09-24 11:59 ` Kirill A. Shutemov 2019-09-24 15:29 ` Jia He 2019-09-24 15:29 ` Jia He 2019-09-24 16:35 ` Catalin Marinas 2019-09-24 16:35 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190921135054.142360-1-justin.he@arm.com \ --to=justin.he@arm.com \ --cc=Kaly.Xin@arm.com \ --cc=Suzuki.Poulose@arm.com \ --cc=akpm@linux-foundation.org \ --cc=anshuman.khandual@arm.com \ --cc=avanbrunt@nvidia.com \ --cc=catalin.marinas@arm.com \ --cc=hejianet@gmail.com \ --cc=james.morse@arm.com \ --cc=jglisse@redhat.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=nd@arm.com \ --cc=punitagrawal@gmail.com \ --cc=rcampbell@nvidia.com \ --cc=robin.murphy@arm.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.