From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu,
Navid Emamdoost <navid.emamdoost@gmail.com>,
David Sterba <dsterba@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fs: affs: fix a memroy leak in affs_remount
Date: Sun, 29 Sep 2019 22:21:57 -0500 [thread overview]
Message-ID: <20190930032200.30474-1-navid.emamdoost@gmail.com> (raw)
In affs_remount if data is provided it is duplicated into new_opts. But
this is not actually used later! The allocated memory for new_opts is
only released if pare_options fail. This commit adds release for
new_opts.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
fs/affs/super.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/affs/super.c b/fs/affs/super.c
index cc463ae47c12..1d38fdbc5148 100644
--- a/fs/affs/super.c
+++ b/fs/affs/super.c
@@ -598,6 +598,8 @@ affs_remount(struct super_block *sb, int *flags, char *data)
memcpy(sbi->s_volume, volume, 32);
spin_unlock(&sbi->symlink_lock);
+ kfree(new_opts);
+
if ((bool)(*flags & SB_RDONLY) == sb_rdonly(sb))
return 0;
--
2.17.1
next reply other threads:[~2019-09-30 3:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 3:21 Navid Emamdoost [this message]
2019-09-30 6:02 ` [PATCH] fs: affs: fix a memory leak in affs_remount Markus Elfring
2019-09-30 6:02 ` Markus Elfring
2019-09-30 21:01 ` [PATCH v2] " Navid Emamdoost
2019-10-01 8:30 ` Markus Elfring
2019-10-01 8:30 ` Markus Elfring
2019-10-01 17:34 ` Navid Emamdoost
2019-10-01 17:34 ` Navid Emamdoost
2019-10-02 5:09 ` [v2] " Markus Elfring
2019-10-02 5:09 ` Markus Elfring
2019-10-02 5:09 ` Markus Elfring
2019-10-02 5:09 ` Markus Elfring
2019-10-02 9:22 ` [PATCH v2] " David Sterba
2019-10-02 16:59 ` Navid Emamdoost
2019-10-02 21:52 ` [PATCH v3] " Navid Emamdoost
2019-10-30 11:44 ` David Sterba
2019-09-30 21:01 ` [PATCH] " Navid Emamdoost
2019-09-30 21:01 ` Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930032200.30474-1-navid.emamdoost@gmail.com \
--to=navid.emamdoost@gmail.com \
--cc=deepa.kernel@gmail.com \
--cc=dsterba@suse.com \
--cc=emamd001@umn.edu \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=kjlu@umn.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smccaman@umn.edu \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.