From: Ian Jackson <ian.jackson@eu.citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [Xen-devel] [OSSTEST PATCH] Osstest.pm: Fix main_revision_job_cond after 0964bab7a9ea
Date: Thu, 3 Oct 2019 10:50:04 +0100 [thread overview]
Message-ID: <20191003095004.30676-1-ian.jackson@eu.citrix.com> (raw)
In
other_revision_job_suffix: Take and pass referring runvar name
we updated main_revision_job_cond to pass a dummy 'x' for the new
parameter. But the parameter is a sql expression, not a value,
and so an extra pair of quotes are needed.
This error broke sg-check-tested and this fix fixes it.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
Osstest.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest.pm b/Osstest.pm
index c14531e3..d6c1b709 100644
--- a/Osstest.pm
+++ b/Osstest.pm
@@ -388,7 +388,7 @@ END
sub main_revision_job_cond ($) {
my ($jobfield) = @_;
- return "(${\ other_revision_job_suffix($jobfield,'x','x') } = '')";
+ return "(${\ other_revision_job_suffix($jobfield,\"'x'\",'x') } = '')";
}
sub get_harness_rev () {
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
reply other threads:[~2019-10-03 9:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003095004.30676-1-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.