All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v3 19/21] drm/i915: don't allocate the ring in stolen if we lack aperture
Date: Fri,  4 Oct 2019 18:04:50 +0100	[thread overview]
Message-ID: <20191004170452.15410-20-matthew.auld@intel.com> (raw)
In-Reply-To: <20191004170452.15410-1-matthew.auld@intel.com>

Since we have no way access it from the CPU. For such cases just
fallback to internal objects.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_ringbuffer.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
index 311fdc0a21bc..9ed6f52d178f 100644
--- a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
@@ -1273,7 +1273,9 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size)
 	struct drm_i915_gem_object *obj;
 	struct i915_vma *vma;
 
-	obj = i915_gem_object_create_stolen(i915, size);
+	obj = ERR_PTR(-ENODEV);
+	if (i915_ggtt_has_aperture(ggtt))
+		obj = i915_gem_object_create_stolen(i915, size);
 	if (IS_ERR(obj))
 		obj = i915_gem_object_create_internal(i915, size);
 	if (IS_ERR(obj))
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-04 17:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04 17:04 [PATCH v3 00/21] LMEM basics Matthew Auld
2019-10-04 17:04 ` [PATCH v3 01/21] drm/i915/stolen: make the object creation interface consistent Matthew Auld
2019-10-04 17:04 ` [PATCH v3 02/21] drm/i915: introduce intel_memory_region Matthew Auld
2019-10-04 22:12   ` Chris Wilson
2019-10-08  8:59   ` Chris Wilson
2019-10-08 11:57     ` Matthew Auld
2019-10-08 12:09       ` Chris Wilson
2019-10-04 17:04 ` [PATCH v3 03/21] drm/i915/region: support contiguous allocations Matthew Auld
2019-10-08  9:06   ` Chris Wilson
2019-10-04 17:04 ` [PATCH v3 04/21] drm/i915/region: support volatile objects Matthew Auld
2019-10-08  9:10   ` Chris Wilson
2019-10-04 17:04 ` [PATCH v3 05/21] drm/i915: Add memory region information to device_info Matthew Auld
2019-10-08  9:11   ` Chris Wilson
2019-10-04 17:04 ` [PATCH v3 06/21] drm/i915: support creating LMEM objects Matthew Auld
2019-10-04 17:04 ` [PATCH v3 07/21] drm/i915: setup io-mapping for LMEM Matthew Auld
2019-10-04 17:04 ` [PATCH v3 08/21] drm/i915/lmem: support kernel mapping Matthew Auld
2019-10-04 17:04 ` [PATCH v3 09/21] drm/i915/selftests: add write-dword test for LMEM Matthew Auld
2019-10-04 17:04 ` [PATCH v3 10/21] drm/i915/selftests: extend coverage to include LMEM huge-pages Matthew Auld
2019-10-04 17:04 ` [PATCH v3 11/21] drm/i915: enumerate and init each supported region Matthew Auld
2019-10-04 17:04 ` [PATCH v3 12/21] drm/i915: treat shmem as a region Matthew Auld
2019-10-04 17:04 ` [PATCH v3 13/21] drm/i915: treat stolen " Matthew Auld
2019-10-04 17:04 ` [PATCH v3 14/21] drm/i915: define i915_ggtt_has_aperture Matthew Auld
2019-10-04 17:04 ` [PATCH v3 15/21] drm/i915: do not map aperture if it is not available Matthew Auld
2019-10-04 17:04 ` [PATCH v3 16/21] drm/i915: set num_fence_regs to 0 if there is no aperture Matthew Auld
2019-10-04 17:04 ` [PATCH v3 17/21] drm/i915: error capture with no ggtt slot Matthew Auld
2019-10-04 17:04 ` [PATCH v3 18/21] drm/i915: Don't try to place HWS in non-existing mappable region Matthew Auld
2019-10-04 17:25   ` Chris Wilson
2019-10-04 17:04 ` Matthew Auld [this message]
2019-10-04 17:04 ` [PATCH v3 20/21] drm/i915/selftests: check for missing aperture Matthew Auld
2019-10-04 17:04 ` [PATCH v3 21/21] HAX drm/i915: add the fake lmem region Matthew Auld
2019-10-04 18:09 ` ✗ Fi.CI.CHECKPATCH: warning for LMEM basics (rev3) Patchwork
2019-10-04 18:19 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-10-04 18:33 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-05  5:46 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004170452.15410-20-matthew.auld@intel.com \
    --to=matthew.auld@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.