All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: clemens@ladisch.de, tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [alsa-devel] [PATCH 08/17] firewire-motu: register the size of PCM period to AMDTP domain
Date: Mon,  7 Oct 2019 20:05:23 +0900	[thread overview]
Message-ID: <20191007110532.30270-9-o-takashi@sakamocchi.jp> (raw)
In-Reply-To: <20191007110532.30270-1-o-takashi@sakamocchi.jp>

This commit is a preparation to share the size of PCM period between
PCM substreams on AMDTP streams in the same domain. At this time,
the size of PCM period in PCM substream which starts AMDTP streams in the
same domain is recorded.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/motu/motu-midi.c   |  2 +-
 sound/firewire/motu/motu-pcm.c    |  4 +++-
 sound/firewire/motu/motu-stream.c | 11 ++++++++++-
 sound/firewire/motu/motu.h        |  3 ++-
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/sound/firewire/motu/motu-midi.c b/sound/firewire/motu/motu-midi.c
index 46a0035df31e..997dd6c8ec31 100644
--- a/sound/firewire/motu/motu-midi.c
+++ b/sound/firewire/motu/motu-midi.c
@@ -17,7 +17,7 @@ static int midi_open(struct snd_rawmidi_substream *substream)
 
 	mutex_lock(&motu->mutex);
 
-	err = snd_motu_stream_reserve_duplex(motu, 0);
+	err = snd_motu_stream_reserve_duplex(motu, 0, 0);
 	if (err >= 0) {
 		++motu->substreams_counter;
 		err = snd_motu_stream_start_duplex(motu);
diff --git a/sound/firewire/motu/motu-pcm.c b/sound/firewire/motu/motu-pcm.c
index aa2e584da6fe..9a54c562494b 100644
--- a/sound/firewire/motu/motu-pcm.c
+++ b/sound/firewire/motu/motu-pcm.c
@@ -202,9 +202,11 @@ static int pcm_hw_params(struct snd_pcm_substream *substream,
 
 	if (substream->runtime->status->state == SNDRV_PCM_STATE_OPEN) {
 		unsigned int rate = params_rate(hw_params);
+		unsigned int frames_per_period = params_period_size(hw_params);
 
 		mutex_lock(&motu->mutex);
-		err = snd_motu_stream_reserve_duplex(motu, rate);
+		err = snd_motu_stream_reserve_duplex(motu, rate,
+						     frames_per_period);
 		if (err >= 0)
 			++motu->substreams_counter;
 		mutex_unlock(&motu->mutex);
diff --git a/sound/firewire/motu/motu-stream.c b/sound/firewire/motu/motu-stream.c
index 813e38e6a86e..52b7c375bb0b 100644
--- a/sound/firewire/motu/motu-stream.c
+++ b/sound/firewire/motu/motu-stream.c
@@ -133,7 +133,8 @@ int snd_motu_stream_cache_packet_formats(struct snd_motu *motu)
 	return 0;
 }
 
-int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate)
+int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate,
+				   unsigned int frames_per_period)
 {
 	unsigned int curr_rate;
 	int err;
@@ -171,6 +172,14 @@ int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate)
 			fw_iso_resources_free(&motu->tx_resources);
 			return err;
 		}
+
+		err = amdtp_domain_set_events_per_period(&motu->domain,
+							 frames_per_period);
+		if (err < 0) {
+			fw_iso_resources_free(&motu->tx_resources);
+			fw_iso_resources_free(&motu->rx_resources);
+			return err;
+		}
 	}
 
 	return 0;
diff --git a/sound/firewire/motu/motu.h b/sound/firewire/motu/motu.h
index 350ee2c16f4a..a419e6e7daed 100644
--- a/sound/firewire/motu/motu.h
+++ b/sound/firewire/motu/motu.h
@@ -154,7 +154,8 @@ void snd_motu_transaction_unregister(struct snd_motu *motu);
 int snd_motu_stream_init_duplex(struct snd_motu *motu);
 void snd_motu_stream_destroy_duplex(struct snd_motu *motu);
 int snd_motu_stream_cache_packet_formats(struct snd_motu *motu);
-int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate);
+int snd_motu_stream_reserve_duplex(struct snd_motu *motu, unsigned int rate,
+				   unsigned int frames_per_period);
 int snd_motu_stream_start_duplex(struct snd_motu *motu);
 void snd_motu_stream_stop_duplex(struct snd_motu *motu);
 int snd_motu_stream_lock_try(struct snd_motu *motu);
-- 
2.20.1

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2019-10-07 11:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 11:05 [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 01/17] firewire-lib: add a member into AMDTP domain for events per period Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 02/17] bebob: register the size of PCM period to AMDTP domain Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 03/17] fireworks: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 04/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 05/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 06/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 07/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` Takashi Sakamoto [this message]
2019-10-07 11:05 ` [alsa-devel] [PATCH 09/17] fireface: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 10/17] bebob: use the same size of period for PCM substream in AMDTP streams Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 11/17] fireworks: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 12/17] oxfw: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 13/17] dice: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 14/17] firewire-digi00x: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 15/17] firewire-tascam: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 16/17] firewire-motu: " Takashi Sakamoto
2019-10-07 11:05 ` [alsa-devel] [PATCH 17/17] fireface: use the same size of period for PCM substreams " Takashi Sakamoto
2019-10-17  7:41 ` [alsa-devel] [PATCH 00/17] firewire: share the size of period for both playback and capture PCM substreams Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191007110532.30270-9-o-takashi@sakamocchi.jp \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.