All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@lists.codethink.co.uk,
	Florian Fainelli <f.fainelli@gmail.com>,
	Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c
Date: Tue,  8 Oct 2019 13:34:44 +0100	[thread overview]
Message-ID: <20191008123453.1651-2-ben.dooks@codethink.co.uk> (raw)
In-Reply-To: <20191008123453.1651-1-ben.dooks@codethink.co.uk>

Fix the following sparse warnings from a missing __iomem
in __bcm_kona_smc() function by adding __iomem attriubte.

arch/arm/mach-bcm/bcm_kona_smc.c:143:21: warning: incorrect type in initializer (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:143:21:    expected unsigned int [usertype] *args
arch/arm/mach-bcm/bcm_kona_smc.c:143:21:    got void [noderef] <asn:2> *static [toplevel] [assigned] bcm_smc
_buffer
arch/arm/mach-bcm/bcm_kona_smc.c:149:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:149:9:    expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:149:9:    got unsigned int [usertype] *
arch/arm/mach-bcm/bcm_kona_smc.c:150:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:150:9:    expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:150:9:    got unsigned int [usertype] *
arch/arm/mach-bcm/bcm_kona_smc.c:151:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:151:9:    expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:151:9:    got unsigned int [usertype] *
arch/arm/mach-bcm/bcm_kona_smc.c:152:9: warning: incorrect type in argument 2 (different address spaces)
arch/arm/mach-bcm/bcm_kona_smc.c:152:9:    expected void volatile [noderef] <asn:2> *addr
arch/arm/mach-bcm/bcm_kona_smc.c:152:9:    got unsigned int [usertype] *[assigned] args

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
---
 arch/arm/mach-bcm/bcm_kona_smc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
index 541e850a736c..43a16f922b53 100644
--- a/arch/arm/mach-bcm/bcm_kona_smc.c
+++ b/arch/arm/mach-bcm/bcm_kona_smc.c
@@ -140,7 +140,7 @@ static int bcm_kona_do_smc(u32 service_id, u32 buffer_phys)
 static void __bcm_kona_smc(void *info)
 {
 	struct bcm_kona_smc_data *data = info;
-	u32 *args = bcm_smc_buffer;
+	u32 __iomem *args = bcm_smc_buffer;
 
 	BUG_ON(smp_processor_id() != 0);
 	BUG_ON(!args);
-- 
2.23.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-08 12:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 12:34 [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Ben Dooks
2019-10-08 12:34 ` Ben Dooks [this message]
2019-10-08 17:57   ` [PATCH 02/11] ARM: bcm: fix missing __iomem in bcm_kona_smc.c Scott Branden
2019-10-15 23:16   ` Florian Fainelli
2019-10-08 12:34 ` [PATCH 03/11] ARM: highbank: include local core.h for highbank_pm_init Ben Dooks
2019-10-08 12:34 ` [PATCH 04/11] ARM: meson: use NULL instead of 0 for pointer Ben Dooks
2019-10-08 12:34   ` Ben Dooks
2019-10-08 12:34 ` [PATCH 05/11] arm: mediatek: force type of mtk_smp_base Ben Dooks
2019-10-08 12:34   ` Ben Dooks
2019-10-08 12:34 ` [PATCH 06/11] ARM: OMAP2+: do not export am43xx_control functions Ben Dooks
2019-10-08 12:34   ` Ben Dooks
2019-10-08 12:34 ` [PATCH 07/11] ARM: OMAP2+: prm44xx: make prm_{save, restore}_context static Ben Dooks
2019-10-08 12:34   ` Ben Dooks
2019-10-08 12:34 ` [PATCH 08/11] ARM: mach-prima2: include common.h for sirfsoc_pm_init Ben Dooks
2019-10-08 12:34 ` [PATCH 09/11] ARM: mach-prima2: make sirfsoc_rtc_iobrg_wait_sync static Ben Dooks
2019-10-08 12:34 ` [PATCH 10/11] ARM: mach-prima2: include linux/rtc/sirfsoc_rtciobrg.h Ben Dooks
2019-10-08 12:34 ` [PATCH 11/11] ARM: ux500: make ux500_cpu_die static Ben Dooks
2019-10-08 17:56 ` [PATCH 01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops Scott Branden
2019-10-15 23:16 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008123453.1651-2-ben.dooks@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.