From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org Cc: andreyknvl@google.com, dave.martin@arm.com, amit.kachhap@arm.com Subject: [PATCH v8 03/12] kselftest: arm64: mangle_pstate_invalid_daif_bits Date: Wed, 9 Oct 2019 09:26:02 +0100 [thread overview] Message-ID: <20191009082611.9441-4-cristian.marussi@arm.com> (raw) In-Reply-To: <20191009082611.9441-1-cristian.marussi@arm.com> Add a simple mangle testcase which messes with the ucontext_t from within the signal handler, trying to set PSTATE DAIF bits to an invalid value (masking everything). Expects SIGSEGV on test PASS. Reviewed-by: Dave Martin <Dave.Martin@arm.com> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- v3 --> v4 - fixed commit message - added testcase comment description --- .../mangle_pstate_invalid_daif_bits.c | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c diff --git a/tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c b/tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c new file mode 100644 index 000000000000..434b82597007 --- /dev/null +++ b/tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c @@ -0,0 +1,35 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2019 ARM Limited + * + * Try to mangle the ucontext from inside a signal handler, mangling the + * DAIF bits in an illegal manner: this attempt must be spotted by Kernel + * and the test case is expected to be terminated via SEGV. + * + */ + +#include "test_signals_utils.h" +#include "testcases.h" + +static int mangle_invalid_pstate_run(struct tdescr *td, siginfo_t *si, + ucontext_t *uc) +{ + ASSERT_GOOD_CONTEXT(uc); + + /* + * This config should trigger a SIGSEGV by Kernel when it checks + * the sigframe consistency in valid_user_regs() routine. + */ + uc->uc_mcontext.pstate |= PSR_D_BIT | PSR_A_BIT | PSR_I_BIT | PSR_F_BIT; + + return 1; +} + +struct tdescr tde = { + .sanity_disabled = true, + .name = "MANGLE_PSTATE_INVALID_DAIF_BITS", + .descr = "Mangling uc_mcontext with INVALID DAIF_BITS", + .sig_trig = SIGUSR1, + .sig_ok = SIGSEGV, + .run = mangle_invalid_pstate_run, +}; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org Cc: amit.kachhap@arm.com, andreyknvl@google.com, dave.martin@arm.com Subject: [PATCH v8 03/12] kselftest: arm64: mangle_pstate_invalid_daif_bits Date: Wed, 9 Oct 2019 09:26:02 +0100 [thread overview] Message-ID: <20191009082611.9441-4-cristian.marussi@arm.com> (raw) In-Reply-To: <20191009082611.9441-1-cristian.marussi@arm.com> Add a simple mangle testcase which messes with the ucontext_t from within the signal handler, trying to set PSTATE DAIF bits to an invalid value (masking everything). Expects SIGSEGV on test PASS. Reviewed-by: Dave Martin <Dave.Martin@arm.com> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- v3 --> v4 - fixed commit message - added testcase comment description --- .../mangle_pstate_invalid_daif_bits.c | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c diff --git a/tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c b/tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c new file mode 100644 index 000000000000..434b82597007 --- /dev/null +++ b/tools/testing/selftests/arm64/signal/testcases/mangle_pstate_invalid_daif_bits.c @@ -0,0 +1,35 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2019 ARM Limited + * + * Try to mangle the ucontext from inside a signal handler, mangling the + * DAIF bits in an illegal manner: this attempt must be spotted by Kernel + * and the test case is expected to be terminated via SEGV. + * + */ + +#include "test_signals_utils.h" +#include "testcases.h" + +static int mangle_invalid_pstate_run(struct tdescr *td, siginfo_t *si, + ucontext_t *uc) +{ + ASSERT_GOOD_CONTEXT(uc); + + /* + * This config should trigger a SIGSEGV by Kernel when it checks + * the sigframe consistency in valid_user_regs() routine. + */ + uc->uc_mcontext.pstate |= PSR_D_BIT | PSR_A_BIT | PSR_I_BIT | PSR_F_BIT; + + return 1; +} + +struct tdescr tde = { + .sanity_disabled = true, + .name = "MANGLE_PSTATE_INVALID_DAIF_BITS", + .descr = "Mangling uc_mcontext with INVALID DAIF_BITS", + .sig_trig = SIGUSR1, + .sig_ok = SIGSEGV, + .run = mangle_invalid_pstate_run, +}; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-09 8:26 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-09 8:25 [PATCH v8 00/12] Add arm64/signal initial kselftest support Cristian Marussi 2019-10-09 8:25 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 01/12] kselftest: arm64: extend toplevel skeleton Makefile Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 11:15 ` Dave Martin 2019-10-09 11:15 ` Dave Martin 2019-10-09 11:52 ` Cristian Marussi 2019-10-09 11:52 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 02/12] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 11:18 ` Dave Martin 2019-10-09 11:18 ` Dave Martin 2019-10-09 11:55 ` Cristian Marussi 2019-10-09 11:55 ` Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi [this message] 2019-10-09 8:26 ` [PATCH v8 03/12] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 04/12] kselftest: arm64: mangle_pstate_invalid_mode_el[123][ht] Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 05/12] kselftest: arm64: extend test_init functionalities Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 11:32 ` Dave Martin 2019-10-09 11:32 ` Dave Martin 2019-10-09 11:57 ` Cristian Marussi 2019-10-09 11:57 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 06/12] kselftest: arm64: add helper get_current_context Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 11:32 ` Dave Martin 2019-10-09 11:32 ` Dave Martin 2019-10-09 11:57 ` Cristian Marussi 2019-10-09 11:57 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 07/12] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 08/12] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 09/12] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 10/12] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 11/12] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi 2019-10-09 8:26 ` [PATCH v8 12/12] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi 2019-10-09 8:26 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191009082611.9441-4-cristian.marussi@arm.com \ --to=cristian.marussi@arm.com \ --cc=amit.kachhap@arm.com \ --cc=andreyknvl@google.com \ --cc=dave.martin@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=shuah@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.