From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <dri-devel@lists.freedesktop.org>, <linux-fbdev@vger.kernel.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <bhanusreemahesh@gmail.com>,
<preid@electromag.com.au>, <daniel.vetter@ffwll.ch>,
<nishadkamdar@gmail.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH] staging: fbtft: fbtft-core: Fix last line displayed on fbcon
Date: Fri, 11 Oct 2019 14:24:41 +0300 [thread overview]
Message-ID: <20191011112441.31003-1-alexandru.ardelean@analog.com> (raw)
From: Michael Hennerich <michael.hennerich@analog.com>
For the special case when fbtft_mkdirty() is called with with -1 for the y
coordinate, the height is truncated by 1.
This isn't required, and causes the last line to not update.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index cf5700a2ea66..90eec45d11fc 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -317,7 +317,7 @@ static void fbtft_mkdirty(struct fb_info *info, int y, int height)
/* special case, needed ? */
if (y == -1) {
y = 0;
- height = info->var.yres - 1;
+ height = info->var.yres;
}
/* Mark display lines/area as dirty */
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: nishadkamdar@gmail.com,
Michael Hennerich <michael.hennerich@analog.com>,
gregkh@linuxfoundation.org, bhanusreemahesh@gmail.com,
daniel.vetter@ffwll.ch,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
preid@electromag.com.au
Subject: [PATCH] staging: fbtft: fbtft-core: Fix last line displayed on fbcon
Date: Fri, 11 Oct 2019 11:24:41 +0000 [thread overview]
Message-ID: <20191011112441.31003-1-alexandru.ardelean@analog.com> (raw)
From: Michael Hennerich <michael.hennerich@analog.com>
For the special case when fbtft_mkdirty() is called with with -1 for the y
coordinate, the height is truncated by 1.
This isn't required, and causes the last line to not update.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index cf5700a2ea66..90eec45d11fc 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -317,7 +317,7 @@ static void fbtft_mkdirty(struct fb_info *info, int y, int height)
/* special case, needed ? */
if (y = -1) {
y = 0;
- height = info->var.yres - 1;
+ height = info->var.yres;
}
/* Mark display lines/area as dirty */
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <dri-devel@lists.freedesktop.org>, <linux-fbdev@vger.kernel.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Cc: nishadkamdar@gmail.com,
Michael Hennerich <michael.hennerich@analog.com>,
gregkh@linuxfoundation.org, bhanusreemahesh@gmail.com,
daniel.vetter@ffwll.ch,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
preid@electromag.com.au
Subject: [PATCH] staging: fbtft: fbtft-core: Fix last line displayed on fbcon
Date: Fri, 11 Oct 2019 14:24:41 +0300 [thread overview]
Message-ID: <20191011112441.31003-1-alexandru.ardelean@analog.com> (raw)
From: Michael Hennerich <michael.hennerich@analog.com>
For the special case when fbtft_mkdirty() is called with with -1 for the y
coordinate, the height is truncated by 1.
This isn't required, and causes the last line to not update.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index cf5700a2ea66..90eec45d11fc 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -317,7 +317,7 @@ static void fbtft_mkdirty(struct fb_info *info, int y, int height)
/* special case, needed ? */
if (y == -1) {
y = 0;
- height = info->var.yres - 1;
+ height = info->var.yres;
}
/* Mark display lines/area as dirty */
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: nishadkamdar@gmail.com,
Michael Hennerich <michael.hennerich@analog.com>,
gregkh@linuxfoundation.org, bhanusreemahesh@gmail.com,
daniel.vetter@ffwll.ch,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
preid@electromag.com.au
Subject: [PATCH] staging: fbtft: fbtft-core: Fix last line displayed on fbcon
Date: Fri, 11 Oct 2019 14:24:41 +0300 [thread overview]
Message-ID: <20191011112441.31003-1-alexandru.ardelean@analog.com> (raw)
From: Michael Hennerich <michael.hennerich@analog.com>
For the special case when fbtft_mkdirty() is called with with -1 for the y
coordinate, the height is truncated by 1.
This isn't required, and causes the last line to not update.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index cf5700a2ea66..90eec45d11fc 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -317,7 +317,7 @@ static void fbtft_mkdirty(struct fb_info *info, int y, int height)
/* special case, needed ? */
if (y == -1) {
y = 0;
- height = info->var.yres - 1;
+ height = info->var.yres;
}
/* Mark display lines/area as dirty */
--
2.20.1
next reply other threads:[~2019-10-11 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 11:24 Alexandru Ardelean [this message]
2019-10-11 11:24 ` [PATCH] staging: fbtft: fbtft-core: Fix last line displayed on fbcon Alexandru Ardelean
2019-10-11 11:24 ` Alexandru Ardelean
2019-10-11 11:24 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011112441.31003-1-alexandru.ardelean@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=bhanusreemahesh@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nishadkamdar@gmail.com \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.