All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org
Cc: "Li Qiang" <liq3ea@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 10/18] hw/input/lm832x: Convert reset handler to DeviceReset
Date: Tue, 15 Oct 2019 18:37:37 -0300	[thread overview]
Message-ID: <20191015213745.22174-11-ehabkost@redhat.com> (raw)
In-Reply-To: <20191015213745.22174-1-ehabkost@redhat.com>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

The LM8323 key-scan controller is a I2C device, it will be reset
when the I2C bus it stands on is reset.

Convert its reset handler into a proper Device reset method.

Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191010131527.32513-8-philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/input/lm832x.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/hw/input/lm832x.c b/hw/input/lm832x.c
index a37eb854b9..aa629ddbf1 100644
--- a/hw/input/lm832x.c
+++ b/hw/input/lm832x.c
@@ -24,7 +24,6 @@
 #include "migration/vmstate.h"
 #include "qemu/module.h"
 #include "qemu/timer.h"
-#include "sysemu/reset.h"
 #include "ui/console.h"
 
 #define TYPE_LM8323 "lm8323"
@@ -94,8 +93,10 @@ static void lm_kbd_gpio_update(LM823KbdState *s)
 {
 }
 
-static void lm_kbd_reset(LM823KbdState *s)
+static void lm_kbd_reset(DeviceState *dev)
 {
+    LM823KbdState *s = LM8323(dev);
+
     s->config = 0x80;
     s->status = INT_NOINIT;
     s->acttime = 125;
@@ -273,7 +274,7 @@ static void lm_kbd_write(LM823KbdState *s, int reg, int byte, uint8_t value)
 
     case LM832x_CMD_RESET:
         if (value == 0xaa)
-            lm_kbd_reset(s);
+            lm_kbd_reset(DEVICE(s));
         else
             lm_kbd_error(s, ERR_BADPAR);
         s->reg = LM832x_GENERAL_ERROR;
@@ -476,10 +477,6 @@ static void lm8323_realize(DeviceState *dev, Error **errp)
     s->pwm.tm[1] = timer_new_ns(QEMU_CLOCK_VIRTUAL, lm_kbd_pwm1_tick, s);
     s->pwm.tm[2] = timer_new_ns(QEMU_CLOCK_VIRTUAL, lm_kbd_pwm2_tick, s);
     qdev_init_gpio_out(dev, &s->nirq, 1);
-
-    lm_kbd_reset(s);
-
-    qemu_register_reset((void *) lm_kbd_reset, s);
 }
 
 void lm832x_key_event(DeviceState *dev, int key, int state)
@@ -507,6 +504,7 @@ static void lm8323_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
     I2CSlaveClass *k = I2C_SLAVE_CLASS(klass);
 
+    dc->reset = lm_kbd_reset;
     dc->realize = lm8323_realize;
     k->event = lm_i2c_event;
     k->recv = lm_i2c_rx;
-- 
2.21.0



  parent reply	other threads:[~2019-10-15 21:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 21:37 [PULL 00/18] x86 and machine queue, 2019-10-15 Eduardo Habkost
2019-10-15 21:37 ` [PULL 01/18] tests: add qtest_qmp_device_add_qdict() helper Eduardo Habkost
2019-10-15 21:37 ` [PULL 02/18] tests: cpu-plug-test: fix device_add for pc/q35 machines Eduardo Habkost
2019-10-15 21:37 ` [PULL 03/18] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node Eduardo Habkost
2019-10-15 21:37 ` [PULL 04/18] hw/acpi/piix4: Convert reset handler to DeviceReset Eduardo Habkost
2019-10-15 21:37 ` [PULL 05/18] hw/isa/piix4: " Eduardo Habkost
2019-10-15 21:37 ` [PULL 06/18] hw/ide/piix: " Eduardo Habkost
2019-10-15 21:37 ` [PULL 07/18] hw/ide/sii3112: " Eduardo Habkost
2019-10-15 21:37 ` [PULL 08/18] hw/ide/via82c: " Eduardo Habkost
2019-10-15 21:37 ` [PULL 09/18] hw/isa/vt82c686: " Eduardo Habkost
2019-10-15 21:37 ` Eduardo Habkost [this message]
2019-10-15 21:37 ` [PULL 11/18] hw/misc/vmcoreinfo: Add comment about reset handler Eduardo Habkost
2019-10-15 21:37 ` [PULL 12/18] memory-device: not necessary to use goto for the last check Eduardo Habkost
2019-10-15 21:37 ` [PULL 13/18] memory-device: break the loop if tmp exceed the hinted range Eduardo Habkost
2019-10-15 21:37 ` [PULL 14/18] target/i386: clean up comments over 80 chars per line Eduardo Habkost
2019-10-15 21:37 ` [PULL 15/18] target/i386: drop the duplicated definition of cpuid AVX512_VBMI macro Eduardo Habkost
2019-10-15 21:37 ` [PULL 16/18] i386: Fix legacy guest with xsave panic on host kvm without update cpuid Eduardo Habkost
2019-10-15 21:37 ` [PULL 17/18] i386: Omit all-zeroes entries from KVM CPUID table Eduardo Habkost
2019-10-15 21:37 ` [PULL 18/18] target/i386: Add Snowridge-v2 (no MPX) CPU model Eduardo Habkost
2019-10-18  9:56 ` [PULL 00/18] x86 and machine queue, 2019-10-15 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015213745.22174-11-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=liq3ea@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.