All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Chris Brandt <chris.brandt@renesas.com>,
	Rob Herring <robh@kernel.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v4 2/4] clocksource/drivers/timer-of: Use unique device name instead of timer
Date: Wed, 16 Oct 2019 16:47:45 +0200	[thread overview]
Message-ID: <20191016144747.29538-3-geert+renesas@glider.be> (raw)
In-Reply-To: <20191016144747.29538-1-geert+renesas@glider.be>

If a hardware-specific driver does not provide a name, the timer-of core
falls back to device_node.name.  Due to generic DT node naming policies,
that name is almost always "timer", and thus doesn't identify the actual
timer used.

Fix this by using device_node.full_name instead, which includes the unit
addrees.

Example impact on /proc/timer_list:

    -Clock Event Device: timer
    +Clock Event Device: timer@fcfec400

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v4:
  - New.
---
 drivers/clocksource/timer-of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index 92cfb160657b81e2..572da477c6d35c5e 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -192,7 +192,7 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to)
 	}
 
 	if (!to->clkevt.name)
-		to->clkevt.name = np->name;
+		to->clkevt.name = np->full_name;
 
 	to->np = np;
 
-- 
2.17.1


  parent reply	other threads:[~2019-10-16 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 14:47 [PATCH v4 0/4] clocksource/drivers/timer-of/renesas-ostm improvements Geert Uytterhoeven
2019-10-16 14:47 ` [PATCH v4 1/4] clocksource/drivers/timer-of: Convert last full_name to %pOF Geert Uytterhoeven
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 14:47 ` Geert Uytterhoeven [this message]
2019-10-16 15:02   ` [PATCH v4 2/4] clocksource/drivers/timer-of: Use unique device name instead of timer Rob Herring
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 14:47 ` [PATCH v4 3/4] clocksource/drivers/renesas-ostm: Convert to timer_of Geert Uytterhoeven
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 14:47 ` [PATCH v4 4/4] clocksource/drivers/renesas-ostm: Use unique device name instead of ostm Geert Uytterhoeven
2019-11-04 17:54   ` [tip: timers/core] " tip-bot2 for Geert Uytterhoeven
2019-10-16 15:03 ` [PATCH v4 0/4] clocksource/drivers/timer-of/renesas-ostm improvements Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016144747.29538-3-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=chris.brandt@renesas.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.