All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>, <ard.biesheuvel@linaro.org>
Cc: <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 03/10] crypto: omap-aes: remove the sysfs group during driver removal
Date: Thu, 17 Oct 2019 15:25:42 +0300	[thread overview]
Message-ID: <20191017122549.4634-4-t-kristo@ti.com> (raw)
In-Reply-To: <20191017122549.4634-1-t-kristo@ti.com>

The driver removal should also cleanup the created sysfs group. If not,
the driver fails the subsequent probe as the files exist already. Also,
drop a completely unnecessary pointer assignment from the removal
function at the same time.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/crypto/omap-aes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index a1fc03ed01f3..38c750e83dbe 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1296,7 +1296,8 @@ static int omap_aes_remove(struct platform_device *pdev)
 	tasklet_kill(&dd->done_task);
 	omap_aes_dma_cleanup(dd);
 	pm_runtime_disable(dd->dev);
-	dd = NULL;
+
+	sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group);
 
 	return 0;
 }
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
	linux-crypto@vger.kernel.org, ard.biesheuvel@linaro.org
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] crypto: omap-aes: remove the sysfs group during driver removal
Date: Thu, 17 Oct 2019 15:25:42 +0300	[thread overview]
Message-ID: <20191017122549.4634-4-t-kristo@ti.com> (raw)
In-Reply-To: <20191017122549.4634-1-t-kristo@ti.com>

The driver removal should also cleanup the created sysfs group. If not,
the driver fails the subsequent probe as the files exist already. Also,
drop a completely unnecessary pointer assignment from the removal
function at the same time.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/crypto/omap-aes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index a1fc03ed01f3..38c750e83dbe 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1296,7 +1296,8 @@ static int omap_aes_remove(struct platform_device *pdev)
 	tasklet_kill(&dd->done_task);
 	omap_aes_dma_cleanup(dd);
 	pm_runtime_disable(dd->dev);
-	dd = NULL;
+
+	sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group);
 
 	return 0;
 }
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
	<linux-crypto@vger.kernel.org>, <ard.biesheuvel@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] crypto: omap-aes: remove the sysfs group during driver removal
Date: Thu, 17 Oct 2019 15:25:42 +0300	[thread overview]
Message-ID: <20191017122549.4634-4-t-kristo@ti.com> (raw)
In-Reply-To: <20191017122549.4634-1-t-kristo@ti.com>

The driver removal should also cleanup the created sysfs group. If not,
the driver fails the subsequent probe as the files exist already. Also,
drop a completely unnecessary pointer assignment from the removal
function at the same time.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/crypto/omap-aes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index a1fc03ed01f3..38c750e83dbe 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1296,7 +1296,8 @@ static int omap_aes_remove(struct platform_device *pdev)
 	tasklet_kill(&dd->done_task);
 	omap_aes_dma_cleanup(dd);
 	pm_runtime_disable(dd->dev);
-	dd = NULL;
+
+	sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group);
 
 	return 0;
 }
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-10-17 12:26 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17 12:25 [PATCH 00/10] crypto: omap fixes towards 5.5 Tero Kristo
2019-10-17 12:25 ` Tero Kristo
2019-10-17 12:25 ` Tero Kristo
2019-10-17 12:25 ` [PATCH 01/10] crypto: omap-sham: split up data to multiple sg elements with huge data Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` [PATCH 02/10] crypto: omap-sham: remove the sysfs group during driver removal Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` Tero Kristo [this message]
2019-10-17 12:25   ` [PATCH 03/10] crypto: omap-aes: " Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` [PATCH 04/10] crypto: omap-des: add IV output handling Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` [PATCH 05/10] crypto: omap-aes: " Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` [PATCH 06/10] crypto: omap-sham: fix buffer handling for split test cases Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` [PATCH 07/10] crypto: omap-aes-gcm: fix corner case with only auth data Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-26 15:04   ` Ard Biesheuvel
2019-10-26 15:04     ` Ard Biesheuvel
2019-10-26 15:04     ` Ard Biesheuvel
2019-10-17 12:25 ` [PATCH 08/10] crypto: omap-sham: fix split update cases with cryptomgr tests Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25 ` [PATCH 09/10] crypto: add timeout to crypto_wait_req Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-11-05 17:42   ` Eric Biggers
2019-11-05 17:42     ` Eric Biggers
2019-11-05 17:42     ` Eric Biggers
2019-11-06  6:39   ` Gilad Ben-Yossef
2019-11-06  6:39     ` Gilad Ben-Yossef
2019-11-06  7:25     ` Tero Kristo
2019-11-06  7:25       ` Tero Kristo
2019-11-06  7:33       ` Gilad Ben-Yossef
2019-11-06  7:33         ` Gilad Ben-Yossef
2019-11-06  7:33         ` Gilad Ben-Yossef
2019-11-08  2:27         ` Eric Biggers
2019-11-08  2:27           ` Eric Biggers
2019-11-08  2:27           ` Eric Biggers
2019-11-08  7:40           ` Tero Kristo
2019-11-08  7:40             ` Tero Kristo
2019-11-08  7:40             ` Tero Kristo
2019-11-08  9:16             ` Herbert Xu
2019-11-08  9:16               ` Herbert Xu
2019-11-08  9:16               ` Herbert Xu
2019-11-08  9:22               ` Tero Kristo
2019-11-08  9:22                 ` Tero Kristo
2019-11-08  9:22                 ` Tero Kristo
2019-11-09  2:27                 ` Eric Biggers
2019-11-09  2:27                   ` Eric Biggers
2019-11-09  2:27                   ` Eric Biggers
2019-11-09  5:01                   ` Herbert Xu
2019-11-09  5:01                     ` Herbert Xu
2019-10-17 12:25 ` [PATCH 10/10] crypto: omap-aes: fixup aligned data cleanup Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-17 12:25   ` Tero Kristo
2019-10-25 11:33 ` [PATCH 00/10] crypto: omap fixes towards 5.5 Ard Biesheuvel
2019-10-25 11:33   ` Ard Biesheuvel
2019-10-25 11:33   ` Ard Biesheuvel
2019-10-25 11:55   ` Tero Kristo
2019-10-25 11:55     ` Tero Kristo
2019-10-25 11:55     ` Tero Kristo
2019-10-25 11:56     ` Tero Kristo
2019-10-25 11:56       ` Tero Kristo
2019-10-25 12:05       ` Ard Biesheuvel
2019-10-25 12:05         ` Ard Biesheuvel
2019-10-25 12:05         ` Ard Biesheuvel
2019-10-25 12:18         ` Tero Kristo
2019-10-25 12:18           ` Tero Kristo
2019-10-25 12:18           ` Tero Kristo
2019-10-26 15:06           ` Ard Biesheuvel
2019-10-26 15:06             ` Ard Biesheuvel
2019-10-26 15:06             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017122549.4634-4-t-kristo@ti.com \
    --to=t-kristo@ti.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.